From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E7BC432BE for ; Fri, 20 Aug 2021 21:05:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A079F6103B for ; Fri, 20 Aug 2021 21:05:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240532AbhHTVFo (ORCPT ); Fri, 20 Aug 2021 17:05:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbhHTVFn (ORCPT ); Fri, 20 Aug 2021 17:05:43 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66EFBC061575 for ; Fri, 20 Aug 2021 14:05:05 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id f15so10801263ilk.4 for ; Fri, 20 Aug 2021 14:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AHuE68SZeZJgo+ZJ5047NRixzSrlnFN0gqAr82i7YR8=; b=mn6E6ELoWiFgPJPOOfbw3ckSVf0xoK3tXZ1RucjWFtWtIdk6bbX+bhVl69KHevLS6o 5eT2qowd6SG4JEwqxjmWQcE+aL1SElXiJ+ofmGEyhpny9Fr8O6OEd3blMOBTfn4xPnFj Y0EcBTzvH76uzG2rh5QuY6BYihUcoEm2QMrQs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AHuE68SZeZJgo+ZJ5047NRixzSrlnFN0gqAr82i7YR8=; b=t2dpHgdesu46x0peFNWM9KHHmOBedDRx1jLdAWmEEFug4xzJujTQ6zIKQwYnm99DWH HpU6LJnSSp83a40Huqi6oPKXAoTsEafFqKC+HZ41vnWA8H0gy9rNeuB/iJbs/MBD+dI3 QmwlifOkDSLlzHPbZC+ahI8C2e92/39RsxqAXfssTVSPsR24TvlVxFfwwNvnKfJVqUlF BJ/vGwJe5cMdzBw79HRlgxYLk3ojmOKWje1bi73T+1/pozo6oSeLHZKwaAWeCasTAtQy Px12aZsJKDYj7jiDEy63V9RtMHrPrDU2rGntjJm9Mh2XKvQ8VMBXvT/sBSHpzCVdWrCq UeJg== X-Gm-Message-State: AOAM532ZmI7eCoT6u58uagTbHkgrgCXVgKWJevJmY7Jko7vNEpZSDjVg bZuJ5H8YQFxUfiySsPYXCa467qkeFFy97g== X-Google-Smtp-Source: ABdhPJzK0cQB+Niv7bw12fMvpdCw9Z5xlpR+GW1L9XaD4FRTGxESgPSaWmOYk28cjkt8AsE+08UTNQ== X-Received: by 2002:a92:1812:: with SMTP id 18mr14766151ily.83.1629493504616; Fri, 20 Aug 2021 14:05:04 -0700 (PDT) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com. [209.85.166.173]) by smtp.gmail.com with ESMTPSA id m184sm4002476ioa.17.2021.08.20.14.05.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 14:05:04 -0700 (PDT) Received: by mail-il1-f173.google.com with SMTP id b4so1247394ilr.11 for ; Fri, 20 Aug 2021 14:05:04 -0700 (PDT) X-Received: by 2002:a92:d304:: with SMTP id x4mr15198676ila.82.1629493503689; Fri, 20 Aug 2021 14:05:03 -0700 (PDT) MIME-Version: 1.0 References: <20210820133829.1.Ica46f428de8c3beb600760dbcd63cf879ec24baf@changeid> In-Reply-To: <20210820133829.1.Ica46f428de8c3beb600760dbcd63cf879ec24baf@changeid> From: Doug Anderson Date: Fri, 20 Aug 2021 14:04:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: add RK3399 Gru gpio-line-names To: Brian Norris Cc: Heiko Stuebner , Linux ARM , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Aug 20, 2021 at 1:38 PM Brian Norris wrote: > > It's convenient to get nice names for GPIOs. In particular, Chrome OS > tooling looks for "AP_FLASH_WP" and "AP_FLASH_WP_L". The rest are > provided for convenience. > > Gru-Bob and Gru-Kevin share the gru-chromebook.dtsi, and for the most > part they share pin meanings. I omitted a few areas where components > were available only on one or the other. > > Signed-off-by: Brian Norris > --- > > .../dts/rockchip/rk3399-gru-chromebook.dtsi | 176 +++++++++++++++++ > .../boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 180 ++++++++++++++++++ > 2 files changed, 356 insertions(+) I didn't walk through the schematics and double-check the rails personally, but the idea here is right. This matches the type of thing we did for veyron, like in commit ca3516b32cd9 ("ARM: dts: rockchip: Add pin names for rk3288-veyron-minnie") I guess one minor nit (now that I look back on the veyron patch where I mentioned it explicitly in the commit message) is that on the veyron ones we sorted this down at the bottom with the other pinctrl stuff instead of sorting it alphabetically with everything else. I'll let Heiko say which he likes better. I also notice for veyron that we had a second "ABI" exception for the recovery mode pin, but I believe that goes through a different mechanism now so we're good there. Even though I didn't do a line-by-line review, I'll still give: Reviewed-by: Douglas Anderson ...though it's possible an "Acked-by" would be more in the spirit of that? Not sure... -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0FEC4338F for ; Fri, 20 Aug 2021 21:05:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82D4E610CC for ; Fri, 20 Aug 2021 21:05:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 82D4E610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ykGklTBPOp/cvIUdtZQ1AOpYqmGzTX/1BQTyz5nLFI=; b=ifs+bym9jK//ni sBdrqdGgLaGME6zUXHx++YEcNXciWJ3ge5iHkbxhy+eXqNqRzPQCy2D8UUnGMp0nqt3/0g4hQd42G miWc96z9icBqNEfCctDQoAC8GSzz261I+kQxwTBhvBfm0jsAAzYZ8j1QxYdCiOb2LIvHT9h4lNcHQ cJkBejUDMYYGwfAlTTHBZUjbvPJzeiFSmVEY0c26kjLuAu5RerYx63lYrRQWVskkvcDaxkqyh/zkz FzKJ8Qf5qyTJzRIFbzaa61nJUtEAl1ENZ6XNR/kYbTbocBkfC2MdGl1liLP1kCbwlYJhsGzh+2hu9 aEYzfiHp7x1wXbOegaPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHBhP-00C76q-Rh; Fri, 20 Aug 2021 21:05:11 +0000 Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHBhK-00C75n-PD for linux-rockchip@lists.infradead.org; Fri, 20 Aug 2021 21:05:10 +0000 Received: by mail-il1-x130.google.com with SMTP id j18so10794212ile.8 for ; Fri, 20 Aug 2021 14:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AHuE68SZeZJgo+ZJ5047NRixzSrlnFN0gqAr82i7YR8=; b=mn6E6ELoWiFgPJPOOfbw3ckSVf0xoK3tXZ1RucjWFtWtIdk6bbX+bhVl69KHevLS6o 5eT2qowd6SG4JEwqxjmWQcE+aL1SElXiJ+ofmGEyhpny9Fr8O6OEd3blMOBTfn4xPnFj Y0EcBTzvH76uzG2rh5QuY6BYihUcoEm2QMrQs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AHuE68SZeZJgo+ZJ5047NRixzSrlnFN0gqAr82i7YR8=; b=bJ4XZdwbqNuCrVEdRGgJj9ZE6gjhejInwaKF5ioX8hLI1s+lf+sQoQeA6PA6vWX8Jq XI6rBQPKrXg480ZkD3TfnksO82SyQ4UUYnN25QSPC3BE6PynXS4Z/Zhv6sIjI/Rd3Z4O yR9+ys6WQBaeB7S8IxtnEBdm2WbGR517QAuwDdeXZzpEKL1v1C8x6kSGWLiPPFpJEyF4 ueUf/AK6JnOTHMaFygoTJ+aSR52Iyjj6T0YEHC/OvtWeqW2g22yo9NudI77lC0WgkLIF ApxuktMKsHOjLITXva52c/J54Dozx1LGwp8bc+AQZOFgHwURJR56/wUrNX6D+TsiIwz6 1MHg== X-Gm-Message-State: AOAM532NcBV0XpYaf4dpZvgvtfWq3aFzCQGqEgqv/2hWbuzNlBD0nCJR Jz8RipWYOJFfF7Tyza4EHRJm6aoFuOXFnQ== X-Google-Smtp-Source: ABdhPJwL5Tf6mPmnKICH1knSxNNe+3JpT1Gh0cY7TS/XOPmPvRkodqlrmhQHCFXPDbYszRVbLUuR4w== X-Received: by 2002:a92:870b:: with SMTP id m11mr14239716ild.132.1629493504516; Fri, 20 Aug 2021 14:05:04 -0700 (PDT) Received: from mail-il1-f176.google.com (mail-il1-f176.google.com. [209.85.166.176]) by smtp.gmail.com with ESMTPSA id s5sm553824iol.33.2021.08.20.14.05.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 14:05:04 -0700 (PDT) Received: by mail-il1-f176.google.com with SMTP id s16so10772416ilo.9 for ; Fri, 20 Aug 2021 14:05:04 -0700 (PDT) X-Received: by 2002:a92:d304:: with SMTP id x4mr15198676ila.82.1629493503689; Fri, 20 Aug 2021 14:05:03 -0700 (PDT) MIME-Version: 1.0 References: <20210820133829.1.Ica46f428de8c3beb600760dbcd63cf879ec24baf@changeid> In-Reply-To: <20210820133829.1.Ica46f428de8c3beb600760dbcd63cf879ec24baf@changeid> From: Doug Anderson Date: Fri, 20 Aug 2021 14:04:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: add RK3399 Gru gpio-line-names To: Brian Norris Cc: Heiko Stuebner , Linux ARM , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/Rockchip SoC..." X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_140506_898515_68AC74AD X-CRM114-Status: GOOD ( 18.36 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi, On Fri, Aug 20, 2021 at 1:38 PM Brian Norris wrote: > > It's convenient to get nice names for GPIOs. In particular, Chrome OS > tooling looks for "AP_FLASH_WP" and "AP_FLASH_WP_L". The rest are > provided for convenience. > > Gru-Bob and Gru-Kevin share the gru-chromebook.dtsi, and for the most > part they share pin meanings. I omitted a few areas where components > were available only on one or the other. > > Signed-off-by: Brian Norris > --- > > .../dts/rockchip/rk3399-gru-chromebook.dtsi | 176 +++++++++++++++++ > .../boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 180 ++++++++++++++++++ > 2 files changed, 356 insertions(+) I didn't walk through the schematics and double-check the rails personally, but the idea here is right. This matches the type of thing we did for veyron, like in commit ca3516b32cd9 ("ARM: dts: rockchip: Add pin names for rk3288-veyron-minnie") I guess one minor nit (now that I look back on the veyron patch where I mentioned it explicitly in the commit message) is that on the veyron ones we sorted this down at the bottom with the other pinctrl stuff instead of sorting it alphabetically with everything else. I'll let Heiko say which he likes better. I also notice for veyron that we had a second "ABI" exception for the recovery mode pin, but I believe that goes through a different mechanism now so we're good there. Even though I didn't do a line-by-line review, I'll still give: Reviewed-by: Douglas Anderson ...though it's possible an "Acked-by" would be more in the spirit of that? Not sure... -Doug _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4566DC4338F for ; Fri, 20 Aug 2021 21:07:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07668610CC for ; Fri, 20 Aug 2021 21:07:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 07668610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MMWxuDguUjCGtz7Y9mzuKjJfU6OJ8vk6C+OV95pvOwU=; b=UbdmSIpK8jXbSp ljLlGEXipFKCK/RZn9B5OXHj3Mf+aoQqqJm0/B+0+M4G20yVJFa6E9gIz91gGs5kOi9aObkhoy665 d6e5lZrBO6/AIDnOa3tNMJzL9PPaok6zhEWR9P7MtLAbquPyCFGSpfZ5/A6hdoPj1H2JYDKNtrhRI IshgRNYHi0XMEiksrRZtfyrCyo2c8kzqAMu7Yvg2NcJVVIYO8rJZtGyR2I+nqcs6eS5RA1PrT0qFM wlbGrPw9D88viAZqvb3u4UqtsxyCNUDm7eYHKlrOKfg4PA5umQF4U2Fg5O6HLW/OAhsYXP+5pWfS1 IYmCjg1pMkE55TekVtGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHBhR-00C76w-FQ; Fri, 20 Aug 2021 21:05:13 +0000 Received: from mail-il1-x136.google.com ([2607:f8b0:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHBhK-00C75o-PD for linux-arm-kernel@lists.infradead.org; Fri, 20 Aug 2021 21:05:10 +0000 Received: by mail-il1-x136.google.com with SMTP id v16so10784261ilo.10 for ; Fri, 20 Aug 2021 14:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AHuE68SZeZJgo+ZJ5047NRixzSrlnFN0gqAr82i7YR8=; b=mn6E6ELoWiFgPJPOOfbw3ckSVf0xoK3tXZ1RucjWFtWtIdk6bbX+bhVl69KHevLS6o 5eT2qowd6SG4JEwqxjmWQcE+aL1SElXiJ+ofmGEyhpny9Fr8O6OEd3blMOBTfn4xPnFj Y0EcBTzvH76uzG2rh5QuY6BYihUcoEm2QMrQs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AHuE68SZeZJgo+ZJ5047NRixzSrlnFN0gqAr82i7YR8=; b=TxemKpqEExOsMgMkCidfbHk+9JhePbik7vc+6ORVX7jBFoczFIKSTwmTry0c/xO6dg EfB+VxFMQnbsYSmhdoHLnt1Kx/FXQPJKGbu/WVbYvQWl3z6MoCI0zxsxSqqEYr0Wkukr HubWqRTXod5QoX6YBpvczc38UKET3iwuobbO0JXWPau3d+1NB//Xill9deddoRgIW1i/ v5fjEVF249wSb87Anqx/8t3Yq7KP9bzIHqwX/APCOmzEHmsTycwiVqo9Dcl9RvFNp3jZ znSirFnTudH4oct6xuVp5jixbzQVspcHEnN4M2NXUThuzi2FT5crur9SHgwUS6zK77Su b1lg== X-Gm-Message-State: AOAM532RECgLJO9wwHnb/Oy5194Cbokcyvg0trREtLcOqf6liqB/8ZVw KB7wnqfXX/GYduKn6TQmmo73Bn/tdOLs3g== X-Google-Smtp-Source: ABdhPJyHow2+SGemu4MdGkuLYyVYqSIgxP7iD7fN74bbhB+/36lGZcbemC4xfuuxFB9lDb9imJIP0Q== X-Received: by 2002:a92:c80e:: with SMTP id v14mr15728044iln.57.1629493504548; Fri, 20 Aug 2021 14:05:04 -0700 (PDT) Received: from mail-il1-f175.google.com (mail-il1-f175.google.com. [209.85.166.175]) by smtp.gmail.com with ESMTPSA id u15sm2148169ilk.53.2021.08.20.14.05.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 14:05:04 -0700 (PDT) Received: by mail-il1-f175.google.com with SMTP id v2so10780584ilg.12 for ; Fri, 20 Aug 2021 14:05:04 -0700 (PDT) X-Received: by 2002:a92:d304:: with SMTP id x4mr15198676ila.82.1629493503689; Fri, 20 Aug 2021 14:05:03 -0700 (PDT) MIME-Version: 1.0 References: <20210820133829.1.Ica46f428de8c3beb600760dbcd63cf879ec24baf@changeid> In-Reply-To: <20210820133829.1.Ica46f428de8c3beb600760dbcd63cf879ec24baf@changeid> From: Doug Anderson Date: Fri, 20 Aug 2021 14:04:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: add RK3399 Gru gpio-line-names To: Brian Norris Cc: Heiko Stuebner , Linux ARM , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/Rockchip SoC..." X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_140506_898323_12172CC5 X-CRM114-Status: GOOD ( 19.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, Aug 20, 2021 at 1:38 PM Brian Norris wrote: > > It's convenient to get nice names for GPIOs. In particular, Chrome OS > tooling looks for "AP_FLASH_WP" and "AP_FLASH_WP_L". The rest are > provided for convenience. > > Gru-Bob and Gru-Kevin share the gru-chromebook.dtsi, and for the most > part they share pin meanings. I omitted a few areas where components > were available only on one or the other. > > Signed-off-by: Brian Norris > --- > > .../dts/rockchip/rk3399-gru-chromebook.dtsi | 176 +++++++++++++++++ > .../boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 180 ++++++++++++++++++ > 2 files changed, 356 insertions(+) I didn't walk through the schematics and double-check the rails personally, but the idea here is right. This matches the type of thing we did for veyron, like in commit ca3516b32cd9 ("ARM: dts: rockchip: Add pin names for rk3288-veyron-minnie") I guess one minor nit (now that I look back on the veyron patch where I mentioned it explicitly in the commit message) is that on the veyron ones we sorted this down at the bottom with the other pinctrl stuff instead of sorting it alphabetically with everything else. I'll let Heiko say which he likes better. I also notice for veyron that we had a second "ABI" exception for the recovery mode pin, but I believe that goes through a different mechanism now so we're good there. Even though I didn't do a line-by-line review, I'll still give: Reviewed-by: Douglas Anderson ...though it's possible an "Acked-by" would be more in the spirit of that? Not sure... -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel