All of
 help / color / mirror / Atom feed
From: Doug Anderson <>
To: Stephen Boyd <>
Cc: Dmitry Torokhov <>,
	LKML <>,,
	 "open list:HID CORE LAYER" <>,,
	 Benson Leung <>,
	Guenter Roeck <>,
	 Hsin-Yi Wang <>
Subject: Re: [PATCH 1/2] Input: cros-ec-keyb: Only register keyboard if rows/columns exist
Date: Wed, 13 Apr 2022 13:44:12 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


On Tue, Apr 12, 2022 at 8:33 PM Stephen Boyd <> wrote:
> If the device is a detachable, we may still probe this device because
> there are some button switches, e.g. volume buttons and power buttons,
> registered by this driver. Let's allow the device node to be missing row
> and column device properties to indicate that the keyboard matrix
> shouldn't be registered. This removes an input device on Trogdor devices
> such as Wormdingler that don't have a matrix keyboard, but still have
> power and volume buttons. That helps userspace understand there isn't
> a keyboard present when the detachable keyboard is disconnected.
> Cc: Benson Leung <>
> Cc: Guenter Roeck <>
> Cc: Douglas Anderson <>
> Cc: Hsin-Yi Wang <>
> Signed-off-by: Stephen Boyd <>
> ---
> I tried to use mkbp info to query the number of rows and columns, but my
> EC firmware doesn't have commit 8505881ed0b9 ("mkbp: Separate MKBP_INFO
> host command from the keyboard driver") so it always returns 8 and 13
> for the rows and columns. Sigh. With updated firmware we could query it,
> or we could rely on DT like we do already.
> Originally I was setting the properties to 0, but
> matrix_keypad_parse_properties() spits out an error message in that case
> and so it seems better to delete the properties and check for their
> existence instead. Another alternative would be to change the compatible
> to be "google,cros-ec-keyb-switches" or something that indicates there
> are only switches and no matrix keyboard.
>  drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

I do wonder if there will be any unintentional side effects here.
Specifically, even though there is truly no keyboard here, I wonder if
anything in the system is relying on the EC to simulate keypresses
even on tablets where the keyboard isn't actually there...

OK, I guess not. While I think it _used_ to be the case that you could
simulate keyboard inputs from the EC console even for devices w/out a
keyboard, it doesn't seem to be the case anymore. I just tried it and
nothing made it through to the AP.

Seems reasonable to me:

Reviewed-by: Douglas Anderson <>

  reply	other threads:[~2022-04-13 20:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13  3:33 [PATCH 0/2] Input: cros-ec-keyb: Don't register keyboard if doesn't exist Stephen Boyd
2022-04-13  3:33 ` [PATCH 1/2] Input: cros-ec-keyb: Only register keyboard if rows/columns exist Stephen Boyd
2022-04-13 20:44   ` Doug Anderson [this message]
2022-04-25  3:47   ` Dmitry Torokhov
2022-04-25 20:12     ` Stephen Boyd
2022-04-13  3:33 ` [RFC/PATCH 2/2] arm64: dts: qcom: sc7180-trogdor: Remove cros-ec keyboard from detachables Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.