From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Maulik Shah <mkshah@codeaurora.org>
Subject: Re: [PATCHv3/RESEND 1/3] soc: qcom: rpmh-rsc: Remove tcs_is_free() API
Date: Thu, 28 May 2020 11:04:00 -0700 [thread overview]
Message-ID: <CAD=FV=UyT+opi5hgtmfKQ9gSs0FWK0W=+uHdPv-mJF2MTHQS5g@mail.gmail.com> (raw)
In-Reply-To: <20200521060425.24285-2-swboyd@chromium.org>
Hi,
On Wed, May 20, 2020 at 11:04 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> This API does very little. Let's replace all the callsites with the
> normal operations that would be done on top of the bitmap that
> tcs_in_use is. This simplifies and reduces the code size.
>
> Cc: Maulik Shah <mkshah@codeaurora.org>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/soc/qcom/rpmh-rsc.c | 59 +++++++++++++------------------------
> 1 file changed, 20 insertions(+), 39 deletions(-)
Sorry for the delay in getting to this review. Looks great.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2020-05-28 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 6:04 [PATCH v3/RESEND 0/3] Even moar rpmh cleanups Stephen Boyd
2020-05-21 6:04 ` [PATCHv3/RESEND 1/3] soc: qcom: rpmh-rsc: Remove tcs_is_free() API Stephen Boyd
2020-05-26 7:07 ` Maulik Shah
2020-05-28 18:04 ` Doug Anderson [this message]
2020-05-21 6:04 ` [PATCHv3/RESEND 2/3] soc: qcom: rpmh-rsc: Loop over fewer bits in irq handler Stephen Boyd
2020-05-21 6:04 ` [PATCHv3/RESEND 3/3] soc: qcom: rpmh-rsc: Fold WARN_ON() into if condition Stephen Boyd
2020-05-21 6:11 ` [PATCH v3/RESEND 0/3] Even moar rpmh cleanups Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UyT+opi5hgtmfKQ9gSs0FWK0W=+uHdPv-mJF2MTHQS5g@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkshah@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.