From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F53AC48BE8 for ; Wed, 16 Jun 2021 15:08:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39178613B4 for ; Wed, 16 Jun 2021 15:08:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234428AbhFPPKF (ORCPT ); Wed, 16 Jun 2021 11:10:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234011AbhFPPKE (ORCPT ); Wed, 16 Jun 2021 11:10:04 -0400 Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD6E0C061574 for ; Wed, 16 Jun 2021 08:07:57 -0700 (PDT) Received: by mail-oo1-xc34.google.com with SMTP id o5-20020a4a2c050000b0290245d6c7b555so748006ooo.11 for ; Wed, 16 Jun 2021 08:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j51VtbWEsPmNthXDSqqlA/0JAvr0xhkR2POpSAUOx9c=; b=ZUIi2qzqYGHwJx+79Fc4944r16x9UMQqqYLtcBz8HCOT0nsZkxfGcmRp23lvyNfAP+ 2knAodSGIE5+PM0wcoqn9rQAvNIbG2+5Sas5+iUH6G+5iioPe8sGy4aqBr4h9MHBFQLA j4DhsbCGODeTQCqVCt1gM8KYJ3xJ2R6oiax+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j51VtbWEsPmNthXDSqqlA/0JAvr0xhkR2POpSAUOx9c=; b=aC3QA74bnm+LTJZihEl85UT6jcsBXDAJARuXEjB87Qu/Meqa95yndeL/a1AorG71Wl 8l7sXVjQUWuuotrz0zhoY2Z2twrUgo6+9KDLDhWtx1d+KrH7AmahmTT5/QxTTom9/H6W 5/S8Bzr62T8UrTCi8LNtNZFGPUIg+ZAfwv0iULS39B0HT56ZLjVKhhL1f1x0053YttN8 B7a606MSJmnTBC/PQ0j67sN07nrgC/iwoUZn12jKjmnZt3VcV7WZdrBq616vxzmEqaUC Wk5DeDAWYqzj3NmQxQ+FzqzceaO+ryV3mx4vfzLDcvUx51Bfnxa9KWyeVaDVB0Jotipx MPng== X-Gm-Message-State: AOAM531ESErPgSrsqZjxxLKQsmS6052/REkb8/3YB65wph5EE+JrO6DL TDdfgMVK8F5cirl5+mZyLZD8m0ZvXiFxGw== X-Google-Smtp-Source: ABdhPJx4IEC74b+AZx7qBkIQtGfSfPTpymFx2MtMXU+YWC/4x0sFfLSn5GlEquaPh0Xh36kP+cjFTw== X-Received: by 2002:a4a:d781:: with SMTP id c1mr396631oou.23.1623856076970; Wed, 16 Jun 2021 08:07:56 -0700 (PDT) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com. [209.85.210.52]) by smtp.gmail.com with ESMTPSA id c205sm475263oib.20.2021.06.16.08.07.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 08:07:56 -0700 (PDT) Received: by mail-ot1-f52.google.com with SMTP id 66-20020a9d02c80000b02903615edf7c1aso2748859otl.13 for ; Wed, 16 Jun 2021 08:07:56 -0700 (PDT) X-Received: by 2002:a5b:54a:: with SMTP id r10mr207252ybp.476.1623855739461; Wed, 16 Jun 2021 08:02:19 -0700 (PDT) MIME-Version: 1.0 References: <1623499682-2140-1-git-send-email-rajeevny@codeaurora.org> <1623499682-2140-6-git-send-email-rajeevny@codeaurora.org> In-Reply-To: <1623499682-2140-6-git-send-email-rajeevny@codeaurora.org> From: Doug Anderson Date: Wed, 16 Jun 2021 08:02:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v6 5/5] drm/panel-simple: Add Samsung ATNA33XC20 To: Rajeev Nandan Cc: dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Thierry Reding , Sam Ravnborg , Rob Clark , Lyude Paul , Jani Nikula , Rob Herring , Laurent Pinchart , Andrzej Hajda , Daniel Thompson , "Kristian H. Kristensen" , Abhinav Kumar , Sean Paul , Kalyan Thota , Krishna Manikandan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Sat, Jun 12, 2021 at 5:09 AM Rajeev Nandan wrote: > > +static const struct panel_desc samsung_atna33xc20 = { > + .modes = &samsung_atna33xc20_mode, > + .num_modes = 1, > + .bpc = 10, > + .size = { > + .width = 294, > + .height = 165, > + }, > + .delay = { > + .disable_to_power_off = 150, > + .power_to_enable = 150, As per it's apparently been discovered that these should be: .disable_to_power_off = 200, .power_to_enable = 400, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86905C48BE6 for ; Wed, 16 Jun 2021 15:02:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F8AF600EF for ; Wed, 16 Jun 2021 15:02:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F8AF600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A60FD89FA6; Wed, 16 Jun 2021 15:02:25 +0000 (UTC) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1EBA389E86 for ; Wed, 16 Jun 2021 15:02:24 +0000 (UTC) Received: by mail-qv1-xf33.google.com with SMTP id f5so1688633qvu.8 for ; Wed, 16 Jun 2021 08:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j51VtbWEsPmNthXDSqqlA/0JAvr0xhkR2POpSAUOx9c=; b=ZUIi2qzqYGHwJx+79Fc4944r16x9UMQqqYLtcBz8HCOT0nsZkxfGcmRp23lvyNfAP+ 2knAodSGIE5+PM0wcoqn9rQAvNIbG2+5Sas5+iUH6G+5iioPe8sGy4aqBr4h9MHBFQLA j4DhsbCGODeTQCqVCt1gM8KYJ3xJ2R6oiax+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j51VtbWEsPmNthXDSqqlA/0JAvr0xhkR2POpSAUOx9c=; b=t1CWr29AoV0Cz1+48RdMVkBcbfMZlQr+CehqIL8dqTVWYiCDBzd9erQGhqWqF1j4XR NAlexKmE9892HmpYKFOFBz507XBnWzLj0zfC4QzzkSW/3tzieRF1BYPiNm2Mhpz9jhKJ MZOkrZww3sppwd39aQ/ZhYhWCpJeWyUnFjGN2gZrwfZsvAQeTTI/PX2tqH1VzKlp4GS3 0E7bTioVLORO7tFqwNVWOiB+dYeYmrXVTTZkTEqtWuOkDAV5ZMXEfciuJ6UMVTaVnW+6 KnS2jBrxJnpjFnna+/12tCBrbqONS4E2hkwG/usxNwRi4+QdhrSB7Eu9sDqAXyGgHkrr nOvA== X-Gm-Message-State: AOAM531/NnXhedm6H0I0kDNuV9lLuC/dPXcjKHGYzdya9VpM1ikzCFFX 9KnvXRM9KtPgLFOULiAUVeGRiurQvUeLdA== X-Google-Smtp-Source: ABdhPJxiVLxCtZDovdmpy4OnlxGWui2LBimwWQxNHC992HIjkBY0pYRuvOh9N1c00fkWhsHW6U3yoA== X-Received: by 2002:ad4:4631:: with SMTP id x17mr474635qvv.28.1623855742470; Wed, 16 Jun 2021 08:02:22 -0700 (PDT) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com. [209.85.219.170]) by smtp.gmail.com with ESMTPSA id t11sm1372287qta.8.2021.06.16.08.02.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 08:02:21 -0700 (PDT) Received: by mail-yb1-f170.google.com with SMTP id m9so3477086ybo.5 for ; Wed, 16 Jun 2021 08:02:19 -0700 (PDT) X-Received: by 2002:a5b:54a:: with SMTP id r10mr207252ybp.476.1623855739461; Wed, 16 Jun 2021 08:02:19 -0700 (PDT) MIME-Version: 1.0 References: <1623499682-2140-1-git-send-email-rajeevny@codeaurora.org> <1623499682-2140-6-git-send-email-rajeevny@codeaurora.org> In-Reply-To: <1623499682-2140-6-git-send-email-rajeevny@codeaurora.org> From: Doug Anderson Date: Wed, 16 Jun 2021 08:02:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v6 5/5] drm/panel-simple: Add Samsung ATNA33XC20 To: Rajeev Nandan Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Daniel Thompson , Krishna Manikandan , Sam Ravnborg , Jani Nikula , linux-arm-msm , Abhinav Kumar , LKML , dri-devel , Andrzej Hajda , Rob Clark , Thierry Reding , Sean Paul , Laurent Pinchart , Kalyan Thota , "Kristian H. Kristensen" , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Sat, Jun 12, 2021 at 5:09 AM Rajeev Nandan wrote: > > +static const struct panel_desc samsung_atna33xc20 = { > + .modes = &samsung_atna33xc20_mode, > + .num_modes = 1, > + .bpc = 10, > + .size = { > + .width = 294, > + .height = 165, > + }, > + .delay = { > + .disable_to_power_off = 150, > + .power_to_enable = 150, As per it's apparently been discovered that these should be: .disable_to_power_off = 200, .power_to_enable = 400,