From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79FC7C07E9C for ; Mon, 12 Jul 2021 13:39:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6212D61006 for ; Mon, 12 Jul 2021 13:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231721AbhGLNmd (ORCPT ); Mon, 12 Jul 2021 09:42:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231351AbhGLNmd (ORCPT ); Mon, 12 Jul 2021 09:42:33 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A5BAC0613DD for ; Mon, 12 Jul 2021 06:39:44 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id s6so15069059qkc.8 for ; Mon, 12 Jul 2021 06:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/y3AswAn7xrfStWckKQ4mdfAYQv8LuashoWFVm7wmnI=; b=JIUoCU9T0XfyuPyJPuVrcxCa8UoWsH/qeP/iWmQomkfVNKt6Mnzy8lEYTsbBLAjQDY qA2lrYcGl7R7GwRo7zb4EcRYe0d2sy5LWLilGAQERXHWRpwcRsU4AXvQl2DgNurV6j9N GaO1ghyx3qKRzIY5oEx/5Ib8QbPhKF1MbPyX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/y3AswAn7xrfStWckKQ4mdfAYQv8LuashoWFVm7wmnI=; b=rHXQzn4dwAhdZBvPVAP2lIZW8/BnvlXxrFpiYPKdJqRkdvQHcp80LRWQOiS2WisEki X8PtsTIBc+TcR7mdc8zKL13BAO7yfgwzemd+O90Wk6seNNUTkAUljz8Mjblyixoc+IZq iIJntrC6oY5j8mvWq6sj9YjT396n/A5FwRMBTM7jhExvi4fdQUC7iwymz7x/q+/LJF6F pRTT/Ro98btBhQeny1b0THT98/Et2gZn7cVefVEdcES3ZHVjueKjifKGYPskllKGOf/Z Z74dRIyWTRPIvUrOn0DswKlqaX1Tu7bM2KCbveBKwnPMDuXx4I85rd5VF74YeyGUHrvQ mkBA== X-Gm-Message-State: AOAM531gduasvS0T2K2fEeUwDLRQ7OiNFZHT0fsR1TqeG1hoZ9eUKOio U/KAQ682c7vpDqdYf6D990BMJSonjjKDpg== X-Google-Smtp-Source: ABdhPJyN0HPtH/WLdWpPpSgbaCx1jgl1Lgo/8M9c68veVXKtKmhC5kFnwu149mSQ2ZcrrUgJj9453Q== X-Received: by 2002:a37:59c7:: with SMTP id n190mr52063539qkb.146.1626097183323; Mon, 12 Jul 2021 06:39:43 -0700 (PDT) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com. [209.85.219.179]) by smtp.gmail.com with ESMTPSA id d200sm2920598qke.95.2021.07.12.06.39.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 06:39:42 -0700 (PDT) Received: by mail-yb1-f179.google.com with SMTP id g5so28959837ybu.10 for ; Mon, 12 Jul 2021 06:39:42 -0700 (PDT) X-Received: by 2002:a25:3486:: with SMTP id b128mr71633896yba.523.1626097181672; Mon, 12 Jul 2021 06:39:41 -0700 (PDT) MIME-Version: 1.0 References: <1624726268-14869-1-git-send-email-rajeevny@codeaurora.org> <1624726268-14869-2-git-send-email-rajeevny@codeaurora.org> <7f8562df-7e1f-dcfb-1c58-f1edd9dcc606@suse.de> In-Reply-To: <7f8562df-7e1f-dcfb-1c58-f1edd9dcc606@suse.de> From: Doug Anderson Date: Mon, 12 Jul 2021 06:39:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v8 1/6] drm/panel: add basic DP AUX backlight support To: Thomas Zimmermann Cc: Rajeev Nandan , dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Thierry Reding , Sam Ravnborg , Rob Clark , Lyude Paul , Jani Nikula , Rob Herring , Laurent Pinchart , Andrzej Hajda , Daniel Thompson , "Kristian H. Kristensen" , Abhinav Kumar , Sean Paul , Kalyan Thota , Krishna Manikandan , Lee Jones , Jingoo Han , linux-fbdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > + EDP_DISPLAY_CTL_CAP_SIZE); > > This creates a cyclic dependency between drm_kms_helper-ko and drm.ko. > drm_panel.c is in the latter, while drm_dp_dpcd_read() in > drm_dp_helper.c is in the former. Please fix. Yeah, this was reported Friday and I posted a patch to try to fix it: https://lore.kernel.org/lkml/20210709152909.1.I23eb4cc5a680341e7b3e791632a635566fa5806a@changeid/ I see Rajeev had some feedback on it. Once I've dug out of my weekend email hole I'll take a look at plan to post a v2 ASAP. -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C247AC07E99 for ; Mon, 12 Jul 2021 13:39:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91B6660230 for ; Mon, 12 Jul 2021 13:39:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91B6660230 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1678C898EA; Mon, 12 Jul 2021 13:39:45 +0000 (UTC) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59176898EA for ; Mon, 12 Jul 2021 13:39:44 +0000 (UTC) Received: by mail-qk1-x72b.google.com with SMTP id j184so17938783qkd.6 for ; Mon, 12 Jul 2021 06:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/y3AswAn7xrfStWckKQ4mdfAYQv8LuashoWFVm7wmnI=; b=JIUoCU9T0XfyuPyJPuVrcxCa8UoWsH/qeP/iWmQomkfVNKt6Mnzy8lEYTsbBLAjQDY qA2lrYcGl7R7GwRo7zb4EcRYe0d2sy5LWLilGAQERXHWRpwcRsU4AXvQl2DgNurV6j9N GaO1ghyx3qKRzIY5oEx/5Ib8QbPhKF1MbPyX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/y3AswAn7xrfStWckKQ4mdfAYQv8LuashoWFVm7wmnI=; b=OvA2ThtROmAnxbb+GXIa24k7SxQbvlsk1tW/8fqgEipsQTrj3hGtZkFNciy1L3eg3f I3q6mShGAom0XLnWJ+pJklcw/5EF1PcE/UoP12/cuT2lYRLJMDlYiC4zcxILVetvyLGL y1hCD+Z1a9CJ5b7fq7P85Uk5rwzzYz3Ab83YPARktUpLbJEDJCkHSItf4YXXtc4eZ6Aq v6JIQebQ1T1BfOXKXiVfndicfzMwZJE2mMDw1Djw5si64XpjxqlQ5zEiCsbst24WiJLG cfaikREUDQHzVE1dzPwQz63oUFz+DNsCJgvonMlpoxJ4ZK/Fpe3Lt7Q9xVl6G9uz/hbe R3ww== X-Gm-Message-State: AOAM533AdCmQplOQZGqbJt40fbGU7cVrRAy/7EoFIxrEucKWDqhvTH/G LH+wQ08qvQ3FdYLiTJgzD5RTpSKQsenr0g== X-Google-Smtp-Source: ABdhPJzdjN+6nt6zyWTMDAt+SE1h0G8hOnPB9BvJQlIVrn54REQZcmuTzx3kAiJv8D92hZVchS2O2A== X-Received: by 2002:a05:620a:16cf:: with SMTP id a15mr6353880qkn.484.1626097183409; Mon, 12 Jul 2021 06:39:43 -0700 (PDT) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com. [209.85.219.178]) by smtp.gmail.com with ESMTPSA id h2sm6763143qkf.106.2021.07.12.06.39.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 06:39:42 -0700 (PDT) Received: by mail-yb1-f178.google.com with SMTP id o139so28942435ybg.9 for ; Mon, 12 Jul 2021 06:39:42 -0700 (PDT) X-Received: by 2002:a25:3486:: with SMTP id b128mr71633896yba.523.1626097181672; Mon, 12 Jul 2021 06:39:41 -0700 (PDT) MIME-Version: 1.0 References: <1624726268-14869-1-git-send-email-rajeevny@codeaurora.org> <1624726268-14869-2-git-send-email-rajeevny@codeaurora.org> <7f8562df-7e1f-dcfb-1c58-f1edd9dcc606@suse.de> In-Reply-To: <7f8562df-7e1f-dcfb-1c58-f1edd9dcc606@suse.de> From: Doug Anderson Date: Mon, 12 Jul 2021 06:39:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v8 1/6] drm/panel: add basic DP AUX backlight support To: Thomas Zimmermann Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, dri-devel , Andrzej Hajda , Thierry Reding , Laurent Pinchart , "Kristian H. Kristensen" , Lee Jones , Daniel Thompson , Sam Ravnborg , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jani Nikula , linux-arm-msm , Abhinav Kumar , Sean Paul , Kalyan Thota , Krishna Manikandan , Rajeev Nandan , Jingoo Han , LKML , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > + EDP_DISPLAY_CTL_CAP_SIZE); > > This creates a cyclic dependency between drm_kms_helper-ko and drm.ko. > drm_panel.c is in the latter, while drm_dp_dpcd_read() in > drm_dp_helper.c is in the former. Please fix. Yeah, this was reported Friday and I posted a patch to try to fix it: https://lore.kernel.org/lkml/20210709152909.1.I23eb4cc5a680341e7b3e791632a635566fa5806a@changeid/ I see Rajeev had some feedback on it. Once I've dug out of my weekend email hole I'll take a look at plan to post a v2 ASAP. -Doug