From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0D5EC43218 for ; Thu, 25 Apr 2019 18:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BD3920685 for ; Thu, 25 Apr 2019 18:15:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fndoZu57" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728966AbfDYSPr (ORCPT ); Thu, 25 Apr 2019 14:15:47 -0400 Received: from mail-ua1-f68.google.com ([209.85.222.68]:45431 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbfDYSPq (ORCPT ); Thu, 25 Apr 2019 14:15:46 -0400 Received: by mail-ua1-f68.google.com with SMTP id o33so282339uae.12 for ; Thu, 25 Apr 2019 11:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TQLgG97dgP+LAcJARy+HeEVPUWpQAXRDJse4J8Yqksc=; b=fndoZu57/uSjDnDsOB8vKFRDbouEL0l5f/xch1VjgyLz9v1vZ5DmF7dh1EeXxqzMHt MEINOdPyCer56YQiGTGCzyIgIVwjUQiYOzRX8tyBbXB2Q0+5iaOXps3DuqZpLC3rLFIU YewgAH2ZA4cLnl0GCLlvS1LHbf8unD/6+sj0k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TQLgG97dgP+LAcJARy+HeEVPUWpQAXRDJse4J8Yqksc=; b=ZlS6fnvw2dVSD+KVT3OCyP283TxVqFVwqBa5V2z/I64LMtFcfzTfxFcntteEQ3u2vt 5G9ji3dUZE5cDVgE2F4Ga9/8Qmd4v/IDP5sJOHopOfxuPASIggWDLIVH2/Pkv58EptFg OvgibqMaDu4mYQypdsecFu2YCcmoZEbadH7ozRPUV25bau8XbteoSnxXLwj9ZqjQboCW HRhum+lG4t2OLelvy7OJF/iKI8vQht1Ir8eQrCvmHirwgcKleXb/XbX16SwJ5H7oNmee Q6RdMNOdz567bClT1a2pVh037PcmZaPwUlbHyidicKo2o8U6BNALXPUPylDBRFRZowrd 4zTQ== X-Gm-Message-State: APjAAAWUirX1a5A3PRs4IiAibROB/UJ7XdkLEpVBRmxYfqULoywelkJQ QBDNfPaVcgwT7u30WnNVYN0WBOc4sXM= X-Google-Smtp-Source: APXvYqxE9PRNBZa+c0Kh3mDif1P2VcV+GJ+kgrpec/D+9zXaNVnEOXflfcutlkFcHdIALBcGiEPFdw== X-Received: by 2002:ab0:6704:: with SMTP id q4mr20584910uam.132.1556216145371; Thu, 25 Apr 2019 11:15:45 -0700 (PDT) Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com. [209.85.222.54]) by smtp.gmail.com with ESMTPSA id l9sm3802494uae.1.2019.04.25.11.15.45 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2019 11:15:45 -0700 (PDT) Received: by mail-ua1-f54.google.com with SMTP id t15so297934uao.5 for ; Thu, 25 Apr 2019 11:15:45 -0700 (PDT) X-Received: by 2002:a9f:204a:: with SMTP id 68mr2037252uam.19.1556215810968; Thu, 25 Apr 2019 11:10:10 -0700 (PDT) MIME-Version: 1.0 References: <20190418001356.124334-1-dianders@chromium.org> <20190418001356.124334-4-dianders@chromium.org> <87pnpas1fx.fsf@linux.intel.com> In-Reply-To: <87pnpas1fx.fsf@linux.intel.com> From: Doug Anderson Date: Thu, 25 Apr 2019 11:09:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB To: Felipe Balbi Cc: Minas Harutyunyan , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Alan Stern , Artur Petrosyan , Alexandru M Stan , "open list:ARM/Rockchip SoC..." , William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , Chris , Matthias Kaehlcke , Ryan Case , Amelie Delaunay , Julius Werner , Dinh Nguyen , Elaine Zhang , devicetree@vger.kernel.org, LKML , Rob Herring , Greg Kroah-Hartman , Mark Rutland Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Apr 25, 2019 at 5:40 AM Felipe Balbi wrote: > > Douglas Anderson writes: > > > Some SoCs with a dwc2 USB controller may need to keep the PHY on to > > support remote wakeup. Allow specifying this as a device tree > > property. > > > > Signed-off-by: Douglas Anderson > > --- > > For relevant prior discussion on this patch, see: > > > > https://lkml.kernel.org/r/1435017144-2971-3-git-send-email-dianders@chromium.org > > > > I didn't make any changes from the prior version since I never found > > out what Rob thought of my previous arguments. If folks want a > > change, perhaps they could choose from these options: > > > > 1. Assume that all dwc2 hosts would like to keep their PHY on for > > suspend if there's a USB wakeup enabled, thus we totally drop this > > binding. This doesn't seem super great to me since I'd bet that > > many devices that use dwc2 weren't designed for USB wakeup (they > > may not keep enough clocks or rails on) so we might be wasting > > power for nothing. > > 2. Rename this property to "snps,wakeup-from-suspend-with-phy" to make > > it more obvious that this property is intended both to document > > that wakeup from suspend is possible and that we need the PHY for > > said wakeup. > > 3. Rename this property to "snps,can-wakeup-from-suspend" and assume > > it's implicit that if we can wakeup from suspend that we need to > > keep the PHY on. If/when someone shows that a device exists using > > dwc2 where we can wakeup from suspend without the PHY they can add > > a new property. > > > > Changes in v2: None > > > > Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++ > > 1 file changed, 3 insertions(+) > > checking file Documentation/devicetree/bindings/usb/dwc2.txt > Hunk #1 FAILED at 37. > Hunk #2 succeeded at 52 (offset -1 lines). > 1 out of 2 hunks FAILED Yeah, as Minas pointed out in the cover letter [1] my series conflicts with Artur's. I have it on my list to try out his series and see if, perhaps, it allows me to enable the partial power down and also just generally rebase. It's fairly high on my list to do that--hopefully in the next week. [1] https://lkml.kernel.org/r/e4b3cd69-1c91-dfbe-bea7-bbca89ca1348@synopsys.com -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH v2 3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB Date: Thu, 25 Apr 2019 11:09:59 -0700 Message-ID: References: <20190418001356.124334-1-dianders@chromium.org> <20190418001356.124334-4-dianders@chromium.org> <87pnpas1fx.fsf@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <87pnpas1fx.fsf@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Felipe Balbi Cc: Minas Harutyunyan , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Alan Stern , Artur Petrosyan , Alexandru M Stan , "open list:ARM/Rockchip SoC..." , William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , Chris , Matthias Kaehlcke , Ryan Case , Amelie Delaunay , Julius Werner , Dinh Nguyen , Elaine Zhang , devicetree@vger.kernel.org, LKML , Rob List-Id: devicetree@vger.kernel.org Hi, On Thu, Apr 25, 2019 at 5:40 AM Felipe Balbi wrote: > > Douglas Anderson writes: > > > Some SoCs with a dwc2 USB controller may need to keep the PHY on to > > support remote wakeup. Allow specifying this as a device tree > > property. > > > > Signed-off-by: Douglas Anderson > > --- > > For relevant prior discussion on this patch, see: > > > > https://lkml.kernel.org/r/1435017144-2971-3-git-send-email-dianders@chromium.org > > > > I didn't make any changes from the prior version since I never found > > out what Rob thought of my previous arguments. If folks want a > > change, perhaps they could choose from these options: > > > > 1. Assume that all dwc2 hosts would like to keep their PHY on for > > suspend if there's a USB wakeup enabled, thus we totally drop this > > binding. This doesn't seem super great to me since I'd bet that > > many devices that use dwc2 weren't designed for USB wakeup (they > > may not keep enough clocks or rails on) so we might be wasting > > power for nothing. > > 2. Rename this property to "snps,wakeup-from-suspend-with-phy" to make > > it more obvious that this property is intended both to document > > that wakeup from suspend is possible and that we need the PHY for > > said wakeup. > > 3. Rename this property to "snps,can-wakeup-from-suspend" and assume > > it's implicit that if we can wakeup from suspend that we need to > > keep the PHY on. If/when someone shows that a device exists using > > dwc2 where we can wakeup from suspend without the PHY they can add > > a new property. > > > > Changes in v2: None > > > > Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++ > > 1 file changed, 3 insertions(+) > > checking file Documentation/devicetree/bindings/usb/dwc2.txt > Hunk #1 FAILED at 37. > Hunk #2 succeeded at 52 (offset -1 lines). > 1 out of 2 hunks FAILED Yeah, as Minas pointed out in the cover letter [1] my series conflicts with Artur's. I have it on my list to try out his series and see if, perhaps, it allows me to enable the partial power down and also just generally rebase. It's fairly high on my list to do that--hopefully in the next week. [1] https://lkml.kernel.org/r/e4b3cd69-1c91-dfbe-bea7-bbca89ca1348@synopsys.com -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB From: Doug Anderson Message-Id: Date: Thu, 25 Apr 2019 11:09:59 -0700 To: Felipe Balbi Cc: Minas Harutyunyan , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Alan Stern , Artur Petrosyan , Alexandru M Stan , "open list:ARM/Rockchip SoC..." , William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , Chris , Matthias Kaehlcke , Ryan Case , Amelie Delaunay , Julius Werner , Dinh Nguyen , Elaine Zhang , devicetree@vger.kernel.org, LKML , Rob Herring , Greg Kroah-Hartman , Mark Rutland List-ID: SGksCgpPbiBUaHUsIEFwciAyNSwgMjAxOSBhdCA1OjQwIEFNIEZlbGlwZSBCYWxiaQo8ZmVsaXBl LmJhbGJpQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4KPiBEb3VnbGFzIEFuZGVyc29uIDxkaWFu ZGVyc0BjaHJvbWl1bS5vcmc+IHdyaXRlczoKPgo+ID4gU29tZSBTb0NzIHdpdGggYSBkd2MyIFVT QiBjb250cm9sbGVyIG1heSBuZWVkIHRvIGtlZXAgdGhlIFBIWSBvbiB0bwo+ID4gc3VwcG9ydCBy ZW1vdGUgd2FrZXVwLiAgQWxsb3cgc3BlY2lmeWluZyB0aGlzIGFzIGEgZGV2aWNlIHRyZWUKPiA+ IHByb3BlcnR5Lgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IERvdWdsYXMgQW5kZXJzb24gPGRpYW5k ZXJzQGNocm9taXVtLm9yZz4KPiA+IC0tLQo+ID4gRm9yIHJlbGV2YW50IHByaW9yIGRpc2N1c3Np b24gb24gdGhpcyBwYXRjaCwgc2VlOgo+ID4KPiA+IGh0dHBzOi8vbGttbC5rZXJuZWwub3JnL3Iv MTQzNTAxNzE0NC0yOTcxLTMtZ2l0LXNlbmQtZW1haWwtZGlhbmRlcnNAY2hyb21pdW0ub3JnCj4g Pgo+ID4gSSBkaWRuJ3QgbWFrZSBhbnkgY2hhbmdlcyBmcm9tIHRoZSBwcmlvciB2ZXJzaW9uIHNp bmNlIEkgbmV2ZXIgZm91bmQKPiA+IG91dCB3aGF0IFJvYiB0aG91Z2h0IG9mIG15IHByZXZpb3Vz IGFyZ3VtZW50cy4gIElmIGZvbGtzIHdhbnQgYQo+ID4gY2hhbmdlLCBwZXJoYXBzIHRoZXkgY291 bGQgY2hvb3NlIGZyb20gdGhlc2Ugb3B0aW9uczoKPiA+Cj4gPiAxLiBBc3N1bWUgdGhhdCBhbGwg ZHdjMiBob3N0cyB3b3VsZCBsaWtlIHRvIGtlZXAgdGhlaXIgUEhZIG9uIGZvcgo+ID4gICAgc3Vz cGVuZCBpZiB0aGVyZSdzIGEgVVNCIHdha2V1cCBlbmFibGVkLCB0aHVzIHdlIHRvdGFsbHkgZHJv cCB0aGlzCj4gPiAgICBiaW5kaW5nLiAgVGhpcyBkb2Vzbid0IHNlZW0gc3VwZXIgZ3JlYXQgdG8g bWUgc2luY2UgSSdkIGJldCB0aGF0Cj4gPiAgICBtYW55IGRldmljZXMgdGhhdCB1c2UgZHdjMiB3 ZXJlbid0IGRlc2lnbmVkIGZvciBVU0Igd2FrZXVwICh0aGV5Cj4gPiAgICBtYXkgbm90IGtlZXAg ZW5vdWdoIGNsb2NrcyBvciByYWlscyBvbikgc28gd2UgbWlnaHQgYmUgd2FzdGluZwo+ID4gICAg cG93ZXIgZm9yIG5vdGhpbmcuCj4gPiAyLiBSZW5hbWUgdGhpcyBwcm9wZXJ0eSB0byAic25wcyx3 YWtldXAtZnJvbS1zdXNwZW5kLXdpdGgtcGh5IiB0byBtYWtlCj4gPiAgICBpdCBtb3JlIG9idmlv dXMgdGhhdCB0aGlzIHByb3BlcnR5IGlzIGludGVuZGVkIGJvdGggdG8gZG9jdW1lbnQKPiA+ICAg IHRoYXQgd2FrZXVwIGZyb20gc3VzcGVuZCBpcyBwb3NzaWJsZSBhbmQgdGhhdCB3ZSBuZWVkIHRo ZSBQSFkgZm9yCj4gPiAgICBzYWlkIHdha2V1cC4KPiA+IDMuIFJlbmFtZSB0aGlzIHByb3BlcnR5 IHRvICJzbnBzLGNhbi13YWtldXAtZnJvbS1zdXNwZW5kIiBhbmQgYXNzdW1lCj4gPiAgICBpdCdz IGltcGxpY2l0IHRoYXQgaWYgd2UgY2FuIHdha2V1cCBmcm9tIHN1c3BlbmQgdGhhdCB3ZSBuZWVk IHRvCj4gPiAgICBrZWVwIHRoZSBQSFkgb24uICBJZi93aGVuIHNvbWVvbmUgc2hvd3MgdGhhdCBh IGRldmljZSBleGlzdHMgdXNpbmcKPiA+ICAgIGR3YzIgd2hlcmUgd2UgY2FuIHdha2V1cCBmcm9t IHN1c3BlbmQgd2l0aG91dCB0aGUgUEhZIHRoZXkgY2FuIGFkZAo+ID4gICAgYSBuZXcgcHJvcGVy dHkuCj4gPgo+ID4gQ2hhbmdlcyBpbiB2MjogTm9uZQo+ID4KPiA+ICBEb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvdXNiL2R3YzIudHh0IHwgMyArKysKPiA+ICAxIGZpbGUgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspCj4KPiBjaGVja2luZyBmaWxlIERvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy91c2IvZHdjMi50eHQKPiBIdW5rICMxIEZBSUxFRCBhdCAzNy4KPiBIdW5r ICMyIHN1Y2NlZWRlZCBhdCA1MiAob2Zmc2V0IC0xIGxpbmVzKS4KPiAxIG91dCBvZiAyIGh1bmtz IEZBSUxFRAoKWWVhaCwgYXMgTWluYXMgcG9pbnRlZCBvdXQgaW4gdGhlIGNvdmVyIGxldHRlciBb MV0gbXkgc2VyaWVzIGNvbmZsaWN0cwp3aXRoIEFydHVyJ3MuICBJIGhhdmUgaXQgb24gbXkgbGlz dCB0byB0cnkgb3V0IGhpcyBzZXJpZXMgYW5kIHNlZSBpZiwKcGVyaGFwcywgaXQgYWxsb3dzIG1l IHRvIGVuYWJsZSB0aGUgcGFydGlhbCBwb3dlciBkb3duIGFuZCBhbHNvIGp1c3QKZ2VuZXJhbGx5 IHJlYmFzZS4gIEl0J3MgZmFpcmx5IGhpZ2ggb24gbXkgbGlzdCB0byBkbyB0aGF0LS1ob3BlZnVs bHkKaW4gdGhlIG5leHQgd2Vlay4KClsxXSBodHRwczovL2xrbWwua2VybmVsLm9yZy9yL2U0YjNj ZDY5LTFjOTEtZGZiZS1iZWE3LWJiY2E4OWNhMTM0OEBzeW5vcHN5cy5jb20KCi1Eb3VnCg==