From: Doug Anderson <dianders@chromium.org>
To: ryandcase@chromium.org
Cc: Mark Brown <broonie@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Stephen Boyd <swboyd@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Trent Piepho <tpiepho@impinj.com>,
boris.brezillon@bootlin.com,
Girish Mahadevan <girishm@codeaurora.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation
Date: Tue, 2 Oct 2018 08:15:10 -0700 [thread overview]
Message-ID: <CAD=FV=VArNPwqxdjCo772V7ZmBQuirHSUpaeVvziiKgdUc-meA@mail.gmail.com> (raw)
In-Reply-To: <20181002013142.209751-1-ryandcase@chromium.org>
Hi,
On Mon, Oct 1, 2018 at 6:32 PM Ryan Case <ryandcase@chromium.org> wrote:
>
> From: Girish Mahadevan <girishm@codeaurora.org>
>
> Bindings for Qualcomm Quad SPI used on SoCs such as sdm845.
>
> Signed-off-by: Girish Mahadevan <girishm@codeaurora.org>
> Signed-off-by: Ryan Case <ryandcase@chromium.org>
> ---
>
> Changes in v5:
> - None
>
> Changes in v4:
> - Changed qspi@ to spi@ and device@ to flash@ to match Rob's review
Rob said that with those changes you could add his reviewed by [1], so
this patch should have carried:
Reviewed-by: Rob Herring <robh@kernel.org>
I'd also say that usually when changes are minor you can make a
judgement call and carry previous reviews. If there's any question
about whether previous reviews can be carried you can mention it
somewhere in your changelog. In this particular case I would have
called the changes minor / non-controversial so I would have kept
Stephen and my reviews when posting the new patch. In any case
Stephen has already re-provided his review and you can feel free to
add:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
[1] https://lkml.kernel.org/r/20180927204624.GA7072@bogus
next prev parent reply other threads:[~2018-10-02 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 1:31 [PATCH v5 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation Ryan Case
2018-10-02 1:31 ` [PATCH v5 2/2] spi: Introduce new driver for Qualcomm QuadSPI controller Ryan Case
2018-10-02 18:45 ` Doug Anderson
2018-10-02 7:20 ` [PATCH v5 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation Stephen Boyd
2018-10-02 7:20 ` Stephen Boyd
2018-10-02 15:15 ` Doug Anderson [this message]
2018-10-11 14:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VArNPwqxdjCo772V7ZmBQuirHSUpaeVvziiKgdUc-meA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=girishm@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=ryandcase@chromium.org \
--cc=swboyd@chromium.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.