All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	"Ravi Kumar Bokka (Temp)" <rbokka@codeaurora.org>
Subject: Re: [PATCH 2/3] nvmem: qfprom: sc7280: Handle the additional power-domains vote
Date: Fri, 23 Jul 2021 09:43:47 -0700	[thread overview]
Message-ID: <CAD=FV=VHP9GbyueqrM1pJ-ZjgndYWj9Q6883pDHnZmK2mMYN2Q@mail.gmail.com> (raw)
In-Reply-To: <1626931716-10591-3-git-send-email-rnayak@codeaurora.org>

Hi,

On Wed, Jul 21, 2021 at 10:29 PM Rajendra Nayak <rnayak@codeaurora.org> wrote:
>
> On sc7280, to reliably blow fuses, we need an additional vote
> on max performance state of 'MX' power-domain.
> Add support for power-domain performance state voting in the
> driver.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
>  drivers/nvmem/qfprom.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
> index 81fbad5..4d0a576 100644
> --- a/drivers/nvmem/qfprom.c
> +++ b/drivers/nvmem/qfprom.c
> @@ -12,6 +12,8 @@
>  #include <linux/mod_devicetable.h>
>  #include <linux/nvmem-provider.h>
>  #include <linux/platform_device.h>
> +#include <linux/pm_domain.h>
> +#include <linux/pm_runtime.h>
>  #include <linux/property.h>
>  #include <linux/regulator/consumer.h>
>
> @@ -149,6 +151,11 @@ static void qfprom_disable_fuse_blowing(const struct qfprom_priv *priv,
>         if (ret)
>                 dev_warn(priv->dev, "Failed to set 0 voltage (ignoring)\n");
>
> +       if (priv->dev->pm_domain) {
> +               dev_pm_genpd_set_performance_state(priv->dev, 0);
> +               pm_runtime_put(priv->dev);
> +       }
> +
>         ret = regulator_disable(priv->vcc);
>         if (ret)
>                 dev_warn(priv->dev, "Failed to disable regulator (ignoring)\n");
> @@ -212,6 +219,16 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
>                 goto err_clk_rate_set;
>         }
>
> +       if (priv->dev->pm_domain) {
> +               ret = pm_runtime_get_sync(priv->dev);
> +               if (ret < 0) {
> +                       pm_runtime_put_noidle(priv->dev);
> +                       dev_err(priv->dev, "Failed to enable power-domain\n");
> +                       goto err_reg_enable;
> +               }
> +               dev_pm_genpd_set_performance_state(priv->dev, INT_MAX);
> +       }
> +
>         old->timer_val = readl(priv->qfpconf + QFPROM_BLOW_TIMER_OFFSET);
>         old->accel_val = readl(priv->qfpconf + QFPROM_ACCEL_OFFSET);
>         writel(priv->soc_data->qfprom_blow_timer_value,
> @@ -221,6 +238,8 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
>
>         return 0;
>
> +err_reg_enable:
> +       regulator_disable(priv->vcc);
>  err_clk_rate_set:
>         clk_set_rate(priv->secclk, old->clk_rate);
>  err_clk_prepared:
> @@ -420,6 +439,9 @@ static int qfprom_probe(struct platform_device *pdev)
>                         econfig.reg_write = qfprom_reg_write;
>         }
>
> +       if (dev->pm_domain)
> +               pm_runtime_enable(dev);
> +

Where is the matching pm_runtime_disable()? Should be one in
.remove(), or use devm_add_action_or_reset() to wrap a call to it.

Also: do you really need to test for dev->pm_domain in your patch?
Seems like it should always be fine to call pm_runtime_enable() and
then always fine to call the get/put. ...and presumably always fine to
even set the performance state?

-Doug

  reply	other threads:[~2021-07-23 16:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  5:28 [PATCH 0/3] nvmem: qfprom: Add binding updates and power-domain handling Rajendra Nayak
2021-07-22  5:28 ` [PATCH 1/3] dt-bindings: nvmem: qfprom: Add optional power-domains property Rajendra Nayak
2021-07-22  5:28 ` [PATCH 2/3] nvmem: qfprom: sc7280: Handle the additional power-domains vote Rajendra Nayak
2021-07-23 16:43   ` Doug Anderson [this message]
2021-07-27 12:20     ` Rajendra Nayak
2021-07-22  5:28 ` [PATCH 3/3] arm64: dts: qcom: sc7280: Add qfprom node Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=VHP9GbyueqrM1pJ-ZjgndYWj9Q6883pDHnZmK2mMYN2Q@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rbokka@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --subject='Re: [PATCH 2/3] nvmem: qfprom: sc7280: Handle the additional power-domains vote' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.