From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0322C433DB for ; Thu, 11 Mar 2021 19:57:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BBAE64F95 for ; Thu, 11 Mar 2021 19:57:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229938AbhCKT5O (ORCPT ); Thu, 11 Mar 2021 14:57:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbhCKT5G (ORCPT ); Thu, 11 Mar 2021 14:57:06 -0500 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DCEBC061760 for ; Thu, 11 Mar 2021 11:57:06 -0800 (PST) Received: by mail-qv1-xf2e.google.com with SMTP id t5so3146424qvs.5 for ; Thu, 11 Mar 2021 11:57:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i0RGEdH4qXmWUyxNfL/0Qo4+5Mh265qbBkTRMR+tqRI=; b=OAERhww90Ydo9cxJC3XtIm6VlKfEfVD/B1Wrc3Lo7PDMjqvJ0MDVxP7v5PlekaTETo /0cCyd9BnnjRsw1GVjAR3R4ocwjMs95l6AaJOmhskigSHLLgyX4XAHjopgVsX3K9Vsyu ewDcNw0kzpX6SuEtmoml2wkkWBwDFevbJKolE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i0RGEdH4qXmWUyxNfL/0Qo4+5Mh265qbBkTRMR+tqRI=; b=W8Bhmpy+ntBbp5ca4osUCJsw/wr1JAa3UgH9xDigpXKRjV2XEFzgmmvYG1ZQwZ8l7L lI4q9CDzmkhlrC4xoysWNlS6wI9T2UT8yH9q7GZDbKzk4t9/BigKv0F/aEJ8fSoh6gxm BHfmYfv/lGuc3h9HM3EQBSPC5WsXPYfb0xqlGLMWpJoym9+M+Idbwlc+oTvzISzog1cX tFQ2JI+jDR88r7Dyl/7VNKJDges4QhGune3bK4P8+GPbnd+BeOpUwXuzvF6D6WCL6G/9 dFl46U+hXsow7R8Aw6ZGV9kfk4WlBtybn9+Vz8uskoSIzs+0V6sCiCIHaEYdit1rw1OG hyvA== X-Gm-Message-State: AOAM530Wk2a9UjlVS7ItYI69atBVDcXiRtOuVTwgVHkVvFWSFwanphU7 xL/9kZtD7Gqkbpw693U1R+HhrfqX7PKuyA== X-Google-Smtp-Source: ABdhPJx6eAjV8VBhop9I7DtazrrJAfNjq70wai9NDbfNEVkg79RxNNrcCV2ouP0VhwP4IbRw9QMahA== X-Received: by 2002:a0c:ff06:: with SMTP id w6mr3226247qvt.51.1615492625126; Thu, 11 Mar 2021 11:57:05 -0800 (PST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id o7sm2732627qkb.104.2021.03.11.11.57.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 11:57:04 -0800 (PST) Received: by mail-yb1-f174.google.com with SMTP id p186so22983253ybg.2 for ; Thu, 11 Mar 2021 11:57:04 -0800 (PST) X-Received: by 2002:a25:aa43:: with SMTP id s61mr14771793ybi.32.1615492624004; Thu, 11 Mar 2021 11:57:04 -0800 (PST) MIME-Version: 1.0 References: <20210311164815.14113-1-srivasam@codeaurora.org> <20210311164815.14113-2-srivasam@codeaurora.org> In-Reply-To: <20210311164815.14113-2-srivasam@codeaurora.org> From: Doug Anderson Date: Thu, 11 Mar 2021 11:56:52 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver To: Srinivasa Rao Mandadapu Cc: gross@kernel.org, Bjorn Andersson , Rob Herring , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rohit kumar , Srinivas Kandagatla , Stephen Boyd , Judy Hsiao , Ajit Pandey , V Sujith Kumar Reddy Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Thu, Mar 11, 2021 at 8:49 AM Srinivasa Rao Mandadapu wrote: > > From: Ajit Pandey > > Add dai link for supporting lpass I2S driver, which is used > for audio capture and playback. > Add lpass-cpu node with pin controls and i2s primary > and secondary dai-links > > Signed-off-by: Ajit Pandey > Signed-off-by: V Sujith Kumar Reddy > Signed-off-by: Srinivasa Rao Mandadapu > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 58 ++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 436582279dad..501e3d4c9097 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include It seems marginally better to include "sc7180-lpass.h" to get this? I don't really know the difference between the two but since unless we're planning to delete the sc7180 version it seems like you might as well include that one? > /* PMICs depend on spmi_bus label and so must come after SoC */ > #include "pm6150.dtsi" > @@ -283,6 +284,42 @@ keyboard_backlight: keyboard-backlight { > max-brightness = <1023>; > }; > }; > + > + sound: sound { > + compatible = "google,sc7180-trogdor"; > + model = "sc7180-rt5682-max98357a-1mic"; > + > + audio-routing = > + "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + dai-link@0 { > + link-name = "MultiMedia0"; > + reg = ; > + cpu { > + sound-dai = <&lpass_cpu MI2S_PRIMARY>; > + }; > + > + codec { > + sound-dai = <&alc5682 MI2S_PRIMARY>; I'm an audio noob but isn't "MI2S_PRIMARY" something to be used with "lpass_cpu", not with "alc5682" ? I have no idea what the IDs correspond to on "alc5682". Are you sure we even need an extra ID there? The "alc5682" bindings upstream don't talk anything about dai-cells, but maybe they're just wrong... -Doug