From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF05ECAAD8 for ; Thu, 1 Sep 2022 15:06:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233225AbiIAPGh (ORCPT ); Thu, 1 Sep 2022 11:06:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231455AbiIAPGg (ORCPT ); Thu, 1 Sep 2022 11:06:36 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8D624B0F4 for ; Thu, 1 Sep 2022 08:06:34 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id bj12so35289913ejb.13 for ; Thu, 01 Sep 2022 08:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=IlxL6IIaFuuRNDQjytli2ml/vYALP5M5BTyWKS8IYmo=; b=fluYmR7isgbi0UhdGPH/rCcV8CVSTZzQ30EzUf2S4tWpVa3KRnRW8EGTlC2qUoG5FQ agPIsAeoq0IlNJWDEreDvHhRiyr1/OZyStPUBDfXY6sp4T6SMQigQU4J5t1KNJOHTNip boANLPHMu02BcLK1PKFeQa0VvnUhAVO6DyaOo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=IlxL6IIaFuuRNDQjytli2ml/vYALP5M5BTyWKS8IYmo=; b=QWOkqSlOjfnWA7pa/3M5s1Q8pQGMwk9NeSqwQru15W67Np2ddRPb2VW88g/m7uuMrq 8iexPQmspe00O+RZRWeGPHzQJiXZU5Nuxwg2gifhjoto7cQwF4CBUFswXVPC9H4mydhR 5/umEanbGV+GH478G0S+5qCO2R1R4FYVBfTlb9dWW72DjFizl3Z9L0RTSDCzgaCpWOJ6 i3kQjxXQ0FDb4wBKxKBgdyVurfUsXAB11SjXMKlXq03hQEtmn55KSiADSEb8vDiTXgjY dKipLqd+vI+CTsRsNFBY1CcvYSGA98J4ZBBgoSbRJfgjyUrhYoyspqgeTvk0I/eNFirp QCTw== X-Gm-Message-State: ACgBeo1ZJKuENrsY71GY9vI2zdVD4zJcqjF4UDnehb0ri5FC5rqYRXwI sZYSlTMhL6lTUM5XX6SJNk3IRtdM26agebca X-Google-Smtp-Source: AA6agR4A0IQtwr2CzxEMtEcEpKtmFJ/jIfQakfoiVhoDv5H00KOLgFa+MIVseBGsCz+XnH3SHslqvA== X-Received: by 2002:a17:906:6a21:b0:741:430f:baca with SMTP id qw33-20020a1709066a2100b00741430fbacamr18684920ejc.507.1662044793159; Thu, 01 Sep 2022 08:06:33 -0700 (PDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id g6-20020a50d0c6000000b0044821b0be7bsm1495748edf.59.2022.09.01.08.06.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 08:06:31 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id u18so10094765wrq.10 for ; Thu, 01 Sep 2022 08:06:30 -0700 (PDT) X-Received: by 2002:adf:f90d:0:b0:20c:de32:4d35 with SMTP id b13-20020adff90d000000b0020cde324d35mr15009507wrr.583.1662044789962; Thu, 01 Sep 2022 08:06:29 -0700 (PDT) MIME-Version: 1.0 References: <20220901091253.93333-1-sheng-liang.pan@quanta.corp-partner.google.com> <20220901170958.1.I7dd7a79c4cc5fe91c3feb004473feb3b34b7b2d8@changeid> In-Reply-To: From: Doug Anderson Date: Thu, 1 Sep 2022 08:06:25 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker To: Krzysztof Kozlowski Cc: Sheng-Liang Pan , LKML , Matthias Kaehlcke , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Thu, Sep 1, 2022 at 3:01 AM Krzysztof Kozlowski wrote: > > On 01/09/2022 12:12, Sheng-Liang Pan wrote: > > Add a basic device tree for the herobrine evoker board. > > > > Signed-off-by: Sheng-Liang Pan > > --- > > And this is third v1? At least this is what your subject is suggesting. > Patches should be properly versioned. Git format-patch helps in that, > but you can use any other tools if you wish. Just to make it clear, what Krzysztof is pointing at is the subject line of your email. Based on your email headers it looks like you're using "patman" to send out your emails. That means you can get what Krzysztof wants by putting a "Series-version" in one of your patches. Given that you had three v1 posts, maybe call the next version "v4"? That means that one of the patches should have: Series-version: 4 Then in each patch you'll have details about what changed in each version. I guess we could sorta call the one where you added the bindings "v2". So in the bindings patch you could add: Series-changes: 2 - Bindings patch added ...and in both patches you could add: Series-changes: 4 - Got the version number correct You've already got a cover letter setup, so in that you should attempt to explain some of this mess, like saying: Sorry about getting mixed up with version numbers. Here are links to previous postings and what I'll assume the version number is: v1: https://lore.kernel.org/r/20220830053307.3997495-1-sheng-liang.pan@quanta.corp-partner.google.com/ v2: https://lore.kernel.org/r/20220901061336.61386-1-sheng-liang.pan@quanta.corp-partner.google.com/ v3: https://lore.kernel.org/r/20220901091253.93333-1-sheng-liang.pan@quanta.corp-partner.google.com/ As an extra note: the bindings patch should be patch #1 and the device tree should be patch #2. That means you should reorder your patches. -Doug > > I pointed you to documentation you must read before posting. You can > keep ignoring it, so we keep ignoring your patch. > > That's a NAK :( > > Best regards, > Krzysztof