From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH v11 04/10] drivers: qcom: rpmh: add RPMH helper functions Date: Mon, 18 Jun 2018 12:54:07 -0700 Message-ID: References: <1529329040-2606-1-git-send-email-rplsssn@codeaurora.org> <1529329040-2606-5-git-send-email-rplsssn@codeaurora.org> <20180618163945.GE21724@codeaurora.org> <20180618190637.GG21724@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180618190637.GG21724@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Lina Iyer Cc: Raju P L S S S N , Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, "open list:ARM/QUALCOMM SUPPORT" , Rajendra Nayak , Bjorn Andersson , LKML , Stephen Boyd , Evan Green , Matthias Kaehlcke List-Id: linux-arm-msm@vger.kernel.org Hi, On Mon, Jun 18, 2018 at 12:06 PM, Lina Iyer wrote: > On Mon, Jun 18 2018 at 12:33 -0600, Doug Anderson wrote: >> >> Lina, >> >> On Mon, Jun 18, 2018 at 9:39 AM, Lina Iyer wrote: >>>> >>>> +/** >>>> * struct rsc_drv: the Direct Resource Voter (DRV) of the >>>> * Resource State Coordinator controller (RSC) >>>> * >>>> @@ -52,6 +78,7 @@ struct tcs_group { >>>> * @tcs: TCS groups >>>> * @tcs_in_use: s/w state of the TCS >>>> * @lock: synchronize state of the controller >>>> + * @ctrl: controller to handle cases like batch requests >>> >>> >>> This is not only for batch requests. >>> This is handle to the DRV's client. @client might be a better name than >>> @ctrlr. >> >> >> The name "ctrlr" also matches the name of the structure. Are you >> suggesting also renaming "struct rpmh_ctrlr" to "struct rpmh_client", >> or you think they should be different names? >> > Just the name of the variable. I was just a nice to have. I wouldn't > block for this though. > > I also got a couple Bot reported issues on this and the previous > revision that I have sent to Raju. He is planning to the post the v12 > tomorrow his time after fixing them. If you can wait until then, I would > recommend picking up the v12 instead of this. OK, if Raju can post the v12 tomorrow his time then that sounds like a great plan to me. While you're at it, I noticed that checkpatch yelled about a few lines that were > 80 characters long for no good reason. Those would be nice to fix too. -Doug