From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E63C433DB for ; Thu, 4 Feb 2021 17:37:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45B5764E4E for ; Thu, 4 Feb 2021 17:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238656AbhBDRgn (ORCPT ); Thu, 4 Feb 2021 12:36:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237552AbhBDRfh (ORCPT ); Thu, 4 Feb 2021 12:35:37 -0500 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 408AAC061793 for ; Thu, 4 Feb 2021 09:34:55 -0800 (PST) Received: by mail-qt1-x82a.google.com with SMTP id o18so2954445qtp.10 for ; Thu, 04 Feb 2021 09:34:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5xmJVsVdWUE9F9n1Lv8bIW1y5TAc3hCeceqbQVJQ3kA=; b=aDxeiSQQzZ+jvYCu9zsBzOqE41xXqisDBldzgBIrkJILMT6Umm8PovVXlab75DnLcv rWO3S7m21IsXtB7Cqc9cADYU6bYG0/4Sa4xROWpVZ0IBAo7bTqh/FZXBasEJXw3zk25E kqq4wN1WBOUkfuPH3h+PJVMViJKBbIFE2LXN8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5xmJVsVdWUE9F9n1Lv8bIW1y5TAc3hCeceqbQVJQ3kA=; b=dPMMNpv2hRCwNOKGxstzM16Z8d2a+33IEuFcOiOcl4RSKDTWIviY9mqWSVnjk28zUv 36SFscAze/LMbmuwXyjr0zUzDgI6WqylK5VvfHnR0UgBt5k7tbhZsdexbPmjD5tPs28W k7f3TM9g9utmDoGfzQntxoFnmRVv+07R1LiTJODc4Sl+Dya40oSwihxhPvKdCiq7syAj qxcKs4Ix3Bk2j9Su3pMXlC0zFcYeSlR5UMjLPndekio9P56xHhz7CBZ0r3Zy8NZYXfbz Q6me9wqDC2zDh9lJiKH4ZkJY92HuFJxQgRtS5UiiIBnEb2YRFXhqjB/n4wRvQ/ro5cQe +aUw== X-Gm-Message-State: AOAM530lYILhi1vED91o3u8RZHDxbvwnzudkKMm5fEGRXG3Bf8XbcHxi rB1koy+1dThTZJCKrMufhJI461AU/AW2Bw== X-Google-Smtp-Source: ABdhPJzClcvb4FaXCb1LucUcsVuJhWH4p6DCVuJCTAYT0L684+Fdb719OWOjGiC9hUmmdlVsEI5f0A== X-Received: by 2002:ac8:59cd:: with SMTP id f13mr659555qtf.258.1612460094042; Thu, 04 Feb 2021 09:34:54 -0800 (PST) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com. [209.85.219.173]) by smtp.gmail.com with ESMTPSA id 138sm5931697qkd.80.2021.02.04.09.34.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Feb 2021 09:34:53 -0800 (PST) Received: by mail-yb1-f173.google.com with SMTP id c3so4002039ybi.3 for ; Thu, 04 Feb 2021 09:34:52 -0800 (PST) X-Received: by 2002:a25:4fc3:: with SMTP id d186mr335253ybb.343.1612460092412; Thu, 04 Feb 2021 09:34:52 -0800 (PST) MIME-Version: 1.0 References: <1612433660-32661-1-git-send-email-sumit.garg@linaro.org> In-Reply-To: <1612433660-32661-1-git-send-email-sumit.garg@linaro.org> From: Doug Anderson Date: Thu, 4 Feb 2021 09:34:40 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] kdb: Refactor env variables get/set code To: Sumit Garg Cc: kgdb-bugreport@lists.sourceforge.net, Jason Wessel , Daniel Thompson , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Feb 4, 2021 at 2:14 AM Sumit Garg wrote: > > Add two new kdb environment access methods as kdb_setenv() and > kdb_printenv() in order to abstract out environment access code > from kdb command functions. > > Also, replace (char *)0 with NULL as an initializer for environment > variables array. > > Signed-off-by: Sumit Garg > --- > > Changes in v2: > - Get rid of code motion to separate kdb_env.c file. > - Replace (char *)0 with NULL. > - Use kernel-doc style function comments. > - s/kdb_prienv/kdb_printenv/ > > kernel/debug/kdb/kdb_main.c | 166 +++++++++++++++++++++++++------------------- > 1 file changed, 93 insertions(+), 73 deletions(-) Reviewed-by: Douglas Anderson