From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F88C43331 for ; Tue, 24 Mar 2020 14:35:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0C1E2080C for ; Tue, 24 Mar 2020 14:35:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YiMsSpud" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727453AbgCXOfk (ORCPT ); Tue, 24 Mar 2020 10:35:40 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:36718 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727511AbgCXOff (ORCPT ); Tue, 24 Mar 2020 10:35:35 -0400 Received: by mail-vs1-f67.google.com with SMTP id n6so11252980vsc.3 for ; Tue, 24 Mar 2020 07:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vHxRlatObgRvnysxTZAZ7i5pl1JSDT2R3bHKmGhkgUE=; b=YiMsSpudpT6FxZHxA6De/saSAHGXK7VlyDXtpNtN9hNzxOPelBBcnUkk9LPz8Mz4Ir KztvWvGmrqbAk7jwUQE14sSAWV4hf05oN5i6odmjR/cou/29qpALc9peKPyrjgXDkrAc oq6V4L/S8pZ9LSBWm00J5so+SUpk1hSQ8Va+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vHxRlatObgRvnysxTZAZ7i5pl1JSDT2R3bHKmGhkgUE=; b=KIDk0SHSxv/pIpeXbZIiJsUgE90TX/6B/srCfiuj2UqIktyWYLF9sHb+DeCCA/CZkZ dP+zADBif8warE3i4bQnoy9qK4XSHbj7BkIAEaLOhA8M2vmOAzWn8S6i8L0LLaTBrKn4 YNpUKOZUIdSYtJwtelpTNnZhE+hIMH5DyGdzFRRfYuTmG1QFayRKVGamlHF7ep7z4VX0 1ZcMP9Lh+cD+YBD4JPcsr4zT8pyu9cEUiMgAJTS6bgi+oFJxt0VskjoLulImNoxM9ZPk EJ0qlH8BMKTNWczyaDn00ssis5twuv5CPye7GQvt/79HxEHQt2gr8DRrqJ/zpLZLz0EI aGXw== X-Gm-Message-State: ANhLgQ2qUXlmq5D8HptQyRpinfAI3So9Pz67hHlaRamKrKmsw6rOzW4l GAx/t+1sFlYjUJMCS+HVgWRcwluQA+U= X-Google-Smtp-Source: ADFU+vuxxt9vAcLdT9GAxgH3aqfloo7bLzgvPoxTcWwPp5D1VeRdASrjsBeigdqESFo1ZERiGaUvww== X-Received: by 2002:a67:e24c:: with SMTP id w12mr1520500vse.153.1585060533894; Tue, 24 Mar 2020 07:35:33 -0700 (PDT) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com. [209.85.222.47]) by smtp.gmail.com with ESMTPSA id 94sm10553496ual.8.2020.03.24.07.35.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2020 07:35:32 -0700 (PDT) Received: by mail-ua1-f47.google.com with SMTP id l18so2187617uak.4 for ; Tue, 24 Mar 2020 07:35:32 -0700 (PDT) X-Received: by 2002:a9f:300a:: with SMTP id h10mr18039835uab.91.1585060531555; Tue, 24 Mar 2020 07:35:31 -0700 (PDT) MIME-Version: 1.0 References: <1584944027-1730-1-git-send-email-kalyan_t@codeaurora.org> In-Reply-To: <1584944027-1730-1-git-send-email-kalyan_t@codeaurora.org> From: Doug Anderson Date: Tue, 24 Mar 2020 07:35:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep To: Kalyan Thota Cc: dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rob Clark , Sean Paul , "Kristian H. Kristensen" , Jeykumar Sankaran , mkrishn@codeaurora.org, travitej@codeaurora.org, nganji@codeaurora.org Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Sun, Mar 22, 2020 at 11:14 PM Kalyan Thota wrote: > > "The PM core always increments the runtime usage counter > before calling the ->suspend() callback and decrements it > after calling the ->resume() callback" > > DPU and DSI are managed as runtime devices. When > suspend is triggered, PM core adds a refcount on all the > devices and calls device suspend, since usage count is > already incremented, runtime suspend was not getting called > and it kept the clocks on which resulted in target not > entering into XO shutdown. > > Add changes to manage runtime devices during pm sleep. > > Changes in v1: > - Remove unnecessary checks in the function > _dpu_kms_disable_dpu (Rob Clark). I'm wondering what happened with my feedback on v1, AKA: https://lore.kernel.org/r/CAD=FV=VxzEV40g+ieuEN+7o=34+wM8MHO8o7T5zA1Yosx7SVWg@mail.gmail.com Maybe you didn't see it? ...or if you or Rob think I'm way off base (always possible) then please tell me so. Thanks! -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6EB1C2BAEE for ; Tue, 24 Mar 2020 14:35:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B51420774 for ; Tue, 24 Mar 2020 14:35:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YiMsSpud" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B51420774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 30CCE6E287; Tue, 24 Mar 2020 14:35:36 +0000 (UTC) Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADE4E6E287 for ; Tue, 24 Mar 2020 14:35:34 +0000 (UTC) Received: by mail-vs1-xe44.google.com with SMTP id j128so4659737vsd.6 for ; Tue, 24 Mar 2020 07:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vHxRlatObgRvnysxTZAZ7i5pl1JSDT2R3bHKmGhkgUE=; b=YiMsSpudpT6FxZHxA6De/saSAHGXK7VlyDXtpNtN9hNzxOPelBBcnUkk9LPz8Mz4Ir KztvWvGmrqbAk7jwUQE14sSAWV4hf05oN5i6odmjR/cou/29qpALc9peKPyrjgXDkrAc oq6V4L/S8pZ9LSBWm00J5so+SUpk1hSQ8Va+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vHxRlatObgRvnysxTZAZ7i5pl1JSDT2R3bHKmGhkgUE=; b=gWpQzTvQXafLFL/Rex1JPqVEUpbQlazgmKtzZ9kRp7ZBz67CeYlop6UVTQIpn/CZyf CFYeLyAgRYTgwiAIWa6Aox5OF+ATNN8tlTICUFfWEc/hzQ5o/joGkdYVGwGjPw5urc24 GfeKu5pU8V5pXUI6t3XCqqdnzOlU6oBBM2nfnd+zr+t59yIJ16X33at4Qztidqfq15pQ hYineporieiIgMq1lwCaCa4u6dCzXQdmbk1AkSZixANG4WV4VjyR05ekzahAAjpoMWWp AAgt2/61005TlOGsdF6KKMr6vdepbccn132VLQ3aZKYwN7uYLZAX7ztyjU//I0oFh0wc NWOg== X-Gm-Message-State: ANhLgQ3n1tLHIm3P2TyP3KnCiU7kOIhZEu5n0l1Q/JunUhFSyje8A1Pg Zo9DkDUJQzBTLmHCjTIUCI8cvyYgnK8= X-Google-Smtp-Source: ADFU+vvEXoHp1sMv4WlM2FBSRtHCy2Ds++G5EB1UyTQaTsGeDlDKXPpYuITpiAmEN+uOZe6X8ZctnQ== X-Received: by 2002:a67:ffd0:: with SMTP id w16mr11272260vsq.151.1585060533332; Tue, 24 Mar 2020 07:35:33 -0700 (PDT) Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com. [209.85.222.42]) by smtp.gmail.com with ESMTPSA id s17sm8991192vsc.27.2020.03.24.07.35.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2020 07:35:32 -0700 (PDT) Received: by mail-ua1-f42.google.com with SMTP id o16so6378379uap.6 for ; Tue, 24 Mar 2020 07:35:32 -0700 (PDT) X-Received: by 2002:a9f:300a:: with SMTP id h10mr18039835uab.91.1585060531555; Tue, 24 Mar 2020 07:35:31 -0700 (PDT) MIME-Version: 1.0 References: <1584944027-1730-1-git-send-email-kalyan_t@codeaurora.org> In-Reply-To: <1584944027-1730-1-git-send-email-kalyan_t@codeaurora.org> From: Doug Anderson Date: Tue, 24 Mar 2020 07:35:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep To: Kalyan Thota X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , mkrishn@codeaurora.org, linux-arm-msm , travitej@codeaurora.org, LKML , dri-devel , Sean Paul , "Kristian H. Kristensen" , freedreno Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Sun, Mar 22, 2020 at 11:14 PM Kalyan Thota wrote: > > "The PM core always increments the runtime usage counter > before calling the ->suspend() callback and decrements it > after calling the ->resume() callback" > > DPU and DSI are managed as runtime devices. When > suspend is triggered, PM core adds a refcount on all the > devices and calls device suspend, since usage count is > already incremented, runtime suspend was not getting called > and it kept the clocks on which resulted in target not > entering into XO shutdown. > > Add changes to manage runtime devices during pm sleep. > > Changes in v1: > - Remove unnecessary checks in the function > _dpu_kms_disable_dpu (Rob Clark). I'm wondering what happened with my feedback on v1, AKA: https://lore.kernel.org/r/CAD=FV=VxzEV40g+ieuEN+7o=34+wM8MHO8o7T5zA1Yosx7SVWg@mail.gmail.com Maybe you didn't see it? ...or if you or Rob think I'm way off base (always possible) then please tell me so. Thanks! -Doug _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel