From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 940B5C433F5 for ; Fri, 20 May 2022 20:39:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353523AbiETUjk (ORCPT ); Fri, 20 May 2022 16:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353517AbiETUjj (ORCPT ); Fri, 20 May 2022 16:39:39 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEF3A19FF53 for ; Fri, 20 May 2022 13:39:38 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id f9so17731335ejc.0 for ; Fri, 20 May 2022 13:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iSGqP8k10DFS00Kv/7Pr3iy8rKQRiyeNX2aJmQ3LLsM=; b=FTMVepZP6e/k7QioiDdbKxNtwhWGQn0dhQoWkprd/KGGrVjGhD8TaFhu0SKJJneTu3 WXVoqKaj9KwLoKuh0hSVIaVAyLbluk+TKxuDlLVhpkvClzrdh8/2Zsf2NWWy/OXqPpZ5 rJaozeD4h4ZnFkjfHsMC40Q208VRfheGECHpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iSGqP8k10DFS00Kv/7Pr3iy8rKQRiyeNX2aJmQ3LLsM=; b=uVmUmb5WNgdJWG5vew190K+E9db73E8D0W2k42J4H4bZpw3gPqnmlDY5PdDyPvnMTH 2QhvvlzYcPURn57D+bLkWG7IprPMr5w7PN+8pTF8uqCm5QlZkiuV1TOG7cqTiEFAdc2U iQSbgOYHMLLhyTD4wcjvIbGB0+U7jEZw3BDFkGhj2G6G24AzQM5dYs7G/Mok3q5Y2Vcg v1rqozP8wF5DnVAeRJHxDQf0SJI0R+po/D6Dg4aJGPKRQfaoOQ1p71+UiYscZvuUlRXV h4hKz1JMvFpoVFMXCogWi8fSFew7N4JqmfLB6Wbld/hJGwdH8iewpOHLzE9144qn8T30 hhyw== X-Gm-Message-State: AOAM533OS/+oC8+ZrSrxL9J5wXvYgl34OwBOc27XGmmllxiKISveSnYR YXjkSCiA3b4s0OLK+eS1iY6Lvhz6gWWoU60ch1A= X-Google-Smtp-Source: ABdhPJwfGGYlsJZZofeAv3bATTjBJYyhadMQgqOI0iPWE9kEYxktT+DzhAgqT5+lbgFhCZLeQswNZg== X-Received: by 2002:a17:907:1c8f:b0:6e8:f898:63bb with SMTP id nb15-20020a1709071c8f00b006e8f89863bbmr10565378ejc.721.1653079177271; Fri, 20 May 2022 13:39:37 -0700 (PDT) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com. [209.85.221.50]) by smtp.gmail.com with ESMTPSA id 15-20020a170906004f00b006f3ef214dd9sm3058687ejg.63.2022.05.20.13.39.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 13:39:35 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id t6so12954663wra.4 for ; Fri, 20 May 2022 13:39:33 -0700 (PDT) X-Received: by 2002:a05:6000:1c03:b0:20e:5cac:1eb5 with SMTP id ba3-20020a0560001c0300b0020e5cac1eb5mr9870704wrb.422.1653079173296; Fri, 20 May 2022 13:39:33 -0700 (PDT) MIME-Version: 1.0 References: <20220520161004.1141554-1-judyhsiao@chromium.org> <20220520161004.1141554-2-judyhsiao@chromium.org> In-Reply-To: From: Doug Anderson Date: Fri, 20 May 2022 13:39:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 To: Stephen Boyd Cc: Andy Gross , Judy Hsiao , Bjorn Andersson , Rob Herring , Srini Kandagatla , Matthias Kaehlcke , Jimmy Cheng-Yi Chiang , Judy Hsiao , Tzung-Bi Shih , Linux ARM , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Fri, May 20, 2022 at 1:38 PM Stephen Boyd wrote: > > Quoting Judy Hsiao (2022-05-20 09:10:02) > > 1. Add drive strength property for mi2s1 on sc7280 based platforms. > > 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk. > > s/Disbale/Disable/ > > The commit text is a list of things done but no reason why they're done. > I'd appreciate more freeform text with a blurb why a drive strength is > chosen and why pulls are disabled. > > > Signed-off-by: Judy Hsiao > > --- > > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > > index 9cb1bc8ed6b5..6d8744e130b0 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > > @@ -612,6 +612,20 @@ &dp_hot_plug_det { > > bias-disable; > > }; > > > > +&mi2s1_data0 { > > + drive-strength = <6>; > > + bias-disable; > > Is there an external pull on this line? > > > +}; > > + > > +&mi2s1_sclk { > > + drive-strength = <6>; > > + bias-disable; > > Is there an external pull on this line? If so please add that details as > a comment like we do for other external pulls. Actually, I think they are output lines, which is why they have a drive-strength. I think for output lines we don't usually comment about why we're disabling the pulls, only for input lines? -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C95E7C433EF for ; Fri, 20 May 2022 20:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3/dckojfrLQgIeDCsgmZLKd7HB68W7++tV+1xLuz04M=; b=mSulDMh/Z1Wcs0 unOoua6WUEPg3IHq3pSfq67ActlZfhfm1muECjVCBdFEhAgrPTeioCA0erMBCzbrArqru8Ekltoz6 sqd2D0evcupduJ3qt4pgxG6UlOyr8fIh5q32WEnlr37lQyr81PELooW2TwRkoQ9t6pk/AV7F3vhjF hEs9dhYVfZ35X4J3v+KgHdDI2Lj+yl57IOI7w068EPlt+aPKl3KNeYvzwvN38O9fBiU5JHYNkil0V +jXsReK0YrfoR5zj91L/Nt/UaTyU1iBabgR4pqjo9RUmB4hJ0iNvTt4vn0eSVExCz7r474amHMok1 Zi9VsMMKUt9M/tFrhuXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns9PS-00ETNB-V0; Fri, 20 May 2022 20:39:43 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns9PP-00ETMJ-QF for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 20:39:41 +0000 Received: by mail-ej1-x633.google.com with SMTP id rs12so5914286ejb.13 for ; Fri, 20 May 2022 13:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iSGqP8k10DFS00Kv/7Pr3iy8rKQRiyeNX2aJmQ3LLsM=; b=FTMVepZP6e/k7QioiDdbKxNtwhWGQn0dhQoWkprd/KGGrVjGhD8TaFhu0SKJJneTu3 WXVoqKaj9KwLoKuh0hSVIaVAyLbluk+TKxuDlLVhpkvClzrdh8/2Zsf2NWWy/OXqPpZ5 rJaozeD4h4ZnFkjfHsMC40Q208VRfheGECHpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iSGqP8k10DFS00Kv/7Pr3iy8rKQRiyeNX2aJmQ3LLsM=; b=X8w4StlJpM+pQkB3xsaEJlwCKma9D+GhJVp9bKiA6wwoalXtrJgzk1iN/7WMYZ7qX2 /BZ5dpTrOQd4WGqTRDL/SXBaSjM8pf6U+S1wDcsfUrgd5htIQYY3g0yC+rDAF7pfPhwO 3JDZaqV2QTzA1vj6LZp0+zLHQk50WzeIgX14CDoXknRQ3D4G8+nEOpHx3C9oFBFfPxYv mgamg5AgUN3p6knAe2ooFE5wb8WDjQ36tUjbHMYzge98GhDS8fDB25uhoFUrPyjWwEWe IiMQ2TkYWaHaeWr+Wok+ybrUIwAfeTyfEDURqnY8Eq3JtLMf3huEtd42LkNAir0W7lxl 0CIg== X-Gm-Message-State: AOAM5307C5VFf6hPuvOMGE4eeYGBrhW+HgmT8LdGmkhGrXISuxanXSDJ z79ITXaTjDR0+r2bh7WDGBhJBqCnlUgGudxib30= X-Google-Smtp-Source: ABdhPJzy7Y951U/73a2EutW9KtBbulbpU5GWcMiKnWctnQlsgn/S930T+uel9m5PfcU4RjFoHB/psA== X-Received: by 2002:a17:906:9f0c:b0:6f5:bed:d0a8 with SMTP id fy12-20020a1709069f0c00b006f50bedd0a8mr10316530ejc.94.1653079177505; Fri, 20 May 2022 13:39:37 -0700 (PDT) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com. [209.85.221.47]) by smtp.gmail.com with ESMTPSA id a23-20020a05640213d700b0042ab4e20543sm4772994edx.48.2022.05.20.13.39.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 13:39:35 -0700 (PDT) Received: by mail-wr1-f47.google.com with SMTP id u3so12965141wrg.3 for ; Fri, 20 May 2022 13:39:33 -0700 (PDT) X-Received: by 2002:a05:6000:1c03:b0:20e:5cac:1eb5 with SMTP id ba3-20020a0560001c0300b0020e5cac1eb5mr9870704wrb.422.1653079173296; Fri, 20 May 2022 13:39:33 -0700 (PDT) MIME-Version: 1.0 References: <20220520161004.1141554-1-judyhsiao@chromium.org> <20220520161004.1141554-2-judyhsiao@chromium.org> In-Reply-To: From: Doug Anderson Date: Fri, 20 May 2022 13:39:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 To: Stephen Boyd Cc: Andy Gross , Judy Hsiao , Bjorn Andersson , Rob Herring , Srini Kandagatla , Matthias Kaehlcke , Jimmy Cheng-Yi Chiang , Judy Hsiao , Tzung-Bi Shih , Linux ARM , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_133939_932600_F53503C9 X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, May 20, 2022 at 1:38 PM Stephen Boyd wrote: > > Quoting Judy Hsiao (2022-05-20 09:10:02) > > 1. Add drive strength property for mi2s1 on sc7280 based platforms. > > 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk. > > s/Disbale/Disable/ > > The commit text is a list of things done but no reason why they're done. > I'd appreciate more freeform text with a blurb why a drive strength is > chosen and why pulls are disabled. > > > Signed-off-by: Judy Hsiao > > --- > > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > > index 9cb1bc8ed6b5..6d8744e130b0 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > > @@ -612,6 +612,20 @@ &dp_hot_plug_det { > > bias-disable; > > }; > > > > +&mi2s1_data0 { > > + drive-strength = <6>; > > + bias-disable; > > Is there an external pull on this line? > > > +}; > > + > > +&mi2s1_sclk { > > + drive-strength = <6>; > > + bias-disable; > > Is there an external pull on this line? If so please add that details as > a comment like we do for other external pulls. Actually, I think they are output lines, which is why they have a drive-strength. I think for output lines we don't usually comment about why we're disabling the pulls, only for input lines? -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel