From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF9B0C433E0 for ; Fri, 17 Jul 2020 17:39:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98B8820737 for ; Fri, 17 Jul 2020 17:39:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="h50OyDj1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727953AbgGQRj3 (ORCPT ); Fri, 17 Jul 2020 13:39:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727932AbgGQRjW (ORCPT ); Fri, 17 Jul 2020 13:39:22 -0400 Received: from mail-ua1-x943.google.com (mail-ua1-x943.google.com [IPv6:2607:f8b0:4864:20::943]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5CBAC0619D3 for ; Fri, 17 Jul 2020 10:39:21 -0700 (PDT) Received: by mail-ua1-x943.google.com with SMTP id p6so3111464uaq.12 for ; Fri, 17 Jul 2020 10:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=oOIi1T3qSHBH51MzlGC0XDR/RneCxeHWL3lEOGZbKJY=; b=h50OyDj1X58pC7yEJMwCHYam/5JpjacNj4lnzko/r7vN8UfLwGNHM+oCutt8YGlrWX sPZ3WG4CgGPiEsti7uJRLIjgLGclvu+gWYfbmNJlNQmexUpO+essviBd/mlHsE8bWYcQ XyzSByoFKpUZu/3vuZVc8VRbmooB91m5COMos= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=oOIi1T3qSHBH51MzlGC0XDR/RneCxeHWL3lEOGZbKJY=; b=Twb5CCRhFySKDCA9iRnKKDXoxyLJAhJjyNRhvUWHfupFnt8OLbf0EEtnQwWe0EsSXl HbB7o2zQMsutmruRMeh4A6ZfWNXKl14CWMpH3JFHd5iLuHVroTDHaIbMUhdsfhdiDx7Z s/FEueTBD4kwezJlRjR5GTG/NlfdR0cHreRc8XwhFElUywkCGikj83kYb/LI1CVU58Sf qVVkPxfOkx6pcfau1heC+AxOymlYvIcKZx9eOIifeOj0BA+18AaIA7hNG7hb1gZ/3km7 AfeDH8WeB1OtCBzz0HX3eThiovFAeANNXekiEWsnC9vUKiHnBEYob9xefq3In8YCFg7M WOiw== X-Gm-Message-State: AOAM532cUwBreU1oXTw4gApIFDUseGpHx0ccd0+pgkL+Jqr8nqgE/XtJ KfS/3x1is+KJFuXfCj8Cnnan12AZdao= X-Google-Smtp-Source: ABdhPJxgt6rIUzHs5MIp6snEVDi+g6XtP53uqX5MmmhheHtk9S5l3BTDo5RhlRVGwBGbNs89kVHvnQ== X-Received: by 2002:a9f:3b0e:: with SMTP id i14mr8279289uah.138.1595007560374; Fri, 17 Jul 2020 10:39:20 -0700 (PDT) Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com. [209.85.217.51]) by smtp.gmail.com with ESMTPSA id i4sm1327660vkg.55.2020.07.17.10.39.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2020 10:39:19 -0700 (PDT) Received: by mail-vs1-f51.google.com with SMTP id s20so5267477vsq.5 for ; Fri, 17 Jul 2020 10:39:19 -0700 (PDT) X-Received: by 2002:a67:69c1:: with SMTP id e184mr8687935vsc.119.1595007558792; Fri, 17 Jul 2020 10:39:18 -0700 (PDT) MIME-Version: 1.0 References: <1594996458-15529-1-git-send-email-akhilpo@codeaurora.org> <20200717144607.GA16703@jcrouse1-lnx.qualcomm.com> In-Reply-To: <20200717144607.GA16703@jcrouse1-lnx.qualcomm.com> From: Doug Anderson Date: Fri, 17 Jul 2020 10:39:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] drm: msm: a6xx: fix gpu failure after system resume To: Akhil P Oommen , freedreno , dri-devel@freedesktop.org, linux-arm-msm , LKML , Matthias Kaehlcke , Rob Clark , Doug Anderson Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Fri, Jul 17, 2020 at 7:46 AM Jordan Crouse wrote: > > On Fri, Jul 17, 2020 at 08:04:18PM +0530, Akhil P Oommen wrote: > > On targets where GMU is available, GMU takes over the ownership of GX GDSC > > during its initialization. So, move the refcount-get on GX PD before we > > initialize the GMU. This ensures that nobody can collapse the GX GDSC > > once GMU owns the GX GDSC. This patch fixes some GMU OOB errors seen > > during GPU wake up during a system resume. > > > Signed-off-by: Akhil P Oommen > > Reported-by: Matthias Kaehlcke > > Tested-by: Matthias Kaehlcke > > The Signed-off-by needs to be at the end but I think Rob can do that for you. It does? I've always been told that this is supposed to be roughly a log of what happens. In that sense you added your SoB before the review/test happened so it should come before. I know some maintainers seem to do things differently but that seems to be the most common. In that sense, I think the order that Akhil has is correct. ...but, obviously, it's up to the maintainer. ;-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E97C433E2 for ; Fri, 17 Jul 2020 17:39:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A523722C9C for ; Fri, 17 Jul 2020 17:39:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="h50OyDj1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A523722C9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2779C6EE17; Fri, 17 Jul 2020 17:39:22 +0000 (UTC) Received: from mail-vk1-xa41.google.com (mail-vk1-xa41.google.com [IPv6:2607:f8b0:4864:20::a41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FF6D6EE17 for ; Fri, 17 Jul 2020 17:39:21 +0000 (UTC) Received: by mail-vk1-xa41.google.com with SMTP id b205so2298714vkb.8 for ; Fri, 17 Jul 2020 10:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=oOIi1T3qSHBH51MzlGC0XDR/RneCxeHWL3lEOGZbKJY=; b=h50OyDj1X58pC7yEJMwCHYam/5JpjacNj4lnzko/r7vN8UfLwGNHM+oCutt8YGlrWX sPZ3WG4CgGPiEsti7uJRLIjgLGclvu+gWYfbmNJlNQmexUpO+essviBd/mlHsE8bWYcQ XyzSByoFKpUZu/3vuZVc8VRbmooB91m5COMos= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=oOIi1T3qSHBH51MzlGC0XDR/RneCxeHWL3lEOGZbKJY=; b=D+OsYSpNWIccKs5uhGAYOWRdCh5iqIIXpjrZKG982+KFFLfQR9MOWUkwiR/DG8GKmU 6jtlRMkvMIz/pCR2W4pnfthwC9qLg3CbRVeiz995avSVPzPVgB/tjLfCjQ9SVA4v2caf hZrJSa5kRC1PIzzM1QHHXy9kU9hs6o+yRnMTu+R4rhcXkghfm4FkDCAiX1GFgCLeBtUk JcA4VYEVF6xM2jGK7Z4U7SQlow74DWlc9niEdz3aNi3mLj/nmdwLuFiLvufEEBRR3ztK wMuUJeAYhHMkilLKaKnsQUMhxMiA9GZJAtDJGK/riA/U3Vx4Qe3NWorbFnDUarmdGVnk 3Q/g== X-Gm-Message-State: AOAM532IXslTsgZcZfT/oxYu/cvww0uRSMVARmKn2YAjr7r2D2qwGt1T s7w3Hf6AVbHk+v1zZ4DMnucse+R2+pI= X-Google-Smtp-Source: ABdhPJzs3FdlYkBTt0atNgY0I4FjIN92KheKnj9IuQdtGjA+Fq1gAUp3firBNexjQxf49Pd5jnobSg== X-Received: by 2002:a1f:a18f:: with SMTP id k137mr8313859vke.69.1595007560138; Fri, 17 Jul 2020 10:39:20 -0700 (PDT) Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com. [209.85.217.54]) by smtp.gmail.com with ESMTPSA id c11sm1304398vke.50.2020.07.17.10.39.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2020 10:39:19 -0700 (PDT) Received: by mail-vs1-f54.google.com with SMTP id k7so5268613vso.2 for ; Fri, 17 Jul 2020 10:39:19 -0700 (PDT) X-Received: by 2002:a67:69c1:: with SMTP id e184mr8687935vsc.119.1595007558792; Fri, 17 Jul 2020 10:39:18 -0700 (PDT) MIME-Version: 1.0 References: <1594996458-15529-1-git-send-email-akhilpo@codeaurora.org> <20200717144607.GA16703@jcrouse1-lnx.qualcomm.com> In-Reply-To: <20200717144607.GA16703@jcrouse1-lnx.qualcomm.com> From: Doug Anderson Date: Fri, 17 Jul 2020 10:39:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] drm: msm: a6xx: fix gpu failure after system resume To: Akhil P Oommen , freedreno , dri-devel@freedesktop.org, linux-arm-msm , LKML , Matthias Kaehlcke , Rob Clark , Doug Anderson X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Fri, Jul 17, 2020 at 7:46 AM Jordan Crouse wrote: > > On Fri, Jul 17, 2020 at 08:04:18PM +0530, Akhil P Oommen wrote: > > On targets where GMU is available, GMU takes over the ownership of GX GDSC > > during its initialization. So, move the refcount-get on GX PD before we > > initialize the GMU. This ensures that nobody can collapse the GX GDSC > > once GMU owns the GX GDSC. This patch fixes some GMU OOB errors seen > > during GPU wake up during a system resume. > > > Signed-off-by: Akhil P Oommen > > Reported-by: Matthias Kaehlcke > > Tested-by: Matthias Kaehlcke > > The Signed-off-by needs to be at the end but I think Rob can do that for you. It does? I've always been told that this is supposed to be roughly a log of what happens. In that sense you added your SoB before the review/test happened so it should come before. I know some maintainers seem to do things differently but that seems to be the most common. In that sense, I think the order that Akhil has is correct. ...but, obviously, it's up to the maintainer. ;-) _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel