From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE9F5C433F5 for ; Thu, 12 May 2022 22:19:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359106AbiELWTt (ORCPT ); Thu, 12 May 2022 18:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359099AbiELWTs (ORCPT ); Thu, 12 May 2022 18:19:48 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9F64280E00 for ; Thu, 12 May 2022 15:19:45 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id g6so12910268ejw.1 for ; Thu, 12 May 2022 15:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=McSS2ps7lAda0B7Hjqm4GcEs6ir76cLprhYeL3EvtQM=; b=FpKUMneT2lkBkxD8QufbxsbC3iS2M4kA4XRmF3F+SntKp7qqDK9yyAtfeOxgnr9a3j wwP3HiFOGA9hJIaks57Co+DyFPOq1f1kjR1dq4QGVQ0NSV6f5vppoZjBxU3toP3xQccx Z0uZZ9G3jvEjNFvB4TkXgwrYoNmR0Hgz+ts1M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=McSS2ps7lAda0B7Hjqm4GcEs6ir76cLprhYeL3EvtQM=; b=S6cKUWaBfr896ncEMVr6FQhJLkKSenafWLSIQ4+Or0jNoKN7U0gH8NpiZdSIgGIpOS uTzWZTyK0PkeY4ytV1woj3Zik5y2JpkacoC753MerOXsdSO5r/38+QR6u3MTmYh1V5x4 YnZoW8mojKdl952d+/Mv5lljmLD3fyVemBEsb7xyrJ36XoDyMs5HdoyFaX52g98/9BD9 nZzQqyY6nspyTt4s5S4utPA+5GqLgqpvsIJiy1H1wahA03f/q7tNBhagMRN5zOuUV/N5 difEfDmOS/1Vh1MHSI7305CrWcmdZawbPiq6IA4DqsvLDZo3KcSI8PwfeT5DuWpbvSKZ iN9Q== X-Gm-Message-State: AOAM532EFcZ7dYXCRnK5Dk1TMkdKMmUE7RdE1hugUPnUDObYUn9tDoJm hzx5EjNU3h18Zf5DvQLMp34tqb7OvjIiP5/N X-Google-Smtp-Source: ABdhPJx7g6XqcOFsonVOhiJTw8dGb/M6dAUL9ZK7z7+h2B5Z80AWk9ZUDk81k+Lqk7Nnwun45EBkPg== X-Received: by 2002:a17:906:60cd:b0:6fd:d95c:3e34 with SMTP id f13-20020a17090660cd00b006fdd95c3e34mr1794125ejk.250.1652393984207; Thu, 12 May 2022 15:19:44 -0700 (PDT) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com. [209.85.221.49]) by smtp.gmail.com with ESMTPSA id d2-20020a170907272200b006f3ef214dcfsm174799ejl.53.2022.05.12.15.19.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 15:19:43 -0700 (PDT) Received: by mail-wr1-f49.google.com with SMTP id u3so9107424wrg.3 for ; Thu, 12 May 2022 15:19:43 -0700 (PDT) X-Received: by 2002:a5d:6d09:0:b0:20c:53a9:cc30 with SMTP id e9-20020a5d6d09000000b0020c53a9cc30mr1382071wrq.513.1652393982520; Thu, 12 May 2022 15:19:42 -0700 (PDT) MIME-Version: 1.0 References: <20220510154406.v5.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid> In-Reply-To: <20220510154406.v5.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid> From: Doug Anderson Date: Thu, 12 May 2022 15:19:30 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 1/5] arm64: dts: qcom: sc7180: Add wormdingler dts files To: "Joseph S. Barrera III" Cc: LKML , Alexandru M Stan , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , Stephen Boyd Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Tue, May 10, 2022 at 3:46 PM Joseph S. Barrera III wrote: > > Wormdingler is a trogdor-based board, shipping to customers as the > Lenovo IdeaPad Chromebook Duet 3. These dts files are copies from > the downstream Chrome OS 5.4 kernel, but with the camera > (sc7180-trogdor-mipi-camera.dtsi) #include removed. > > Signed-off-by: Joseph S. Barrera III > > --- > > Changes in v5: > - Replaced _ in node name with - > - Ordered nodes by name So it's a bit of a judgement call, but generally the rule is that if you didn't make very big changes from one version of a patch to the next that you should keep "Reviewed-by" tags that you've already received. In this case the changes you made from v4 to v5 were very small and also very non-controversial (it's hard to believe I would object to these changes). Thus, it would have been better to keep my Reviewed-by tag. Everyone understands that it's a judgement call so as long as it's within reason people won't be too upset at you for making your best guess. If you're unsure, you can always add a note "after the cut" (AKA "Commit-notes" in patman speak) explaining why you did or didn't choose to keep someone's tags. That being said, offline Stephen pointed out a problem with all of your v5 patches. Specifically, in the meantime while you were spinning your patches, Stephen's patch series landed in the upstream tree. Namely: 19794489fa24 arm64: dts: qcom: Only include sc7180.dtsi in sc7180-trogdor.dtsi d277cab7afc7 arm64: dts: qcom: sc7180-trogdor: Simplify spi0/spi6 labeling 51d30402be75 arm64: dts: qcom: sc7180-trogdor: Simplify trackpad enabling Since he won the race of getting the patches landed, that means it's on you to adjust. You should modify your patches to match what Stephen did in those 3. ...and, presumably, the changes Stephen is requesting here probably _are_ big enough that you'd want to remove my Reviewed-by tag for v6. Speaking of Stephen, he reviewed your v4 patches, but you didn't copy him on v5. In general if someone responds to a patch in the series you should CC them on the next version. -Doug