From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756761AbcCaQCv (ORCPT ); Thu, 31 Mar 2016 12:02:51 -0400 Received: from mail-vk0-f47.google.com ([209.85.213.47]:35549 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752963AbcCaQCs (ORCPT ); Thu, 31 Mar 2016 12:02:48 -0400 MIME-Version: 1.0 In-Reply-To: <20160331095600.GD26032@ulmo.nvidia.com> References: <1455534576-1486-1-git-send-email-ykk@rock-chips.com> <20160330203204.GA24156@roeck-us.net> <20160331095600.GD26032@ulmo.nvidia.com> Date: Thu, 31 Mar 2016 09:02:47 -0700 X-Google-Sender-Auth: zGVVfAsiYI6F9JW974Ei6ruYnzQ Message-ID: Subject: Re: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory From: Doug Anderson To: Thierry Reding Cc: Guenter Roeck , Yakir Yang , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Krzysztof Kozlowski , Rob Herring , Heiko Stuebner , Mark Yao , Russell King , Daniel Kurtz , Sean Paul , Kukjin Kim , Kumar Gala , Emil Velikov , Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , Ajay kumar , Rob Herring , Javier Martinez Canillas , Andy Yan , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-samsung-soc , "open list:ARM/Rockchip SoC..." , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Mar 31, 2016 at 2:56 AM, Thierry Reding wrote: > Ugh... most of these functions shouldn't be there in the first place. We > have helpers in the core that already do this. Most of the functionality > is duplicated in this driver. > > I realize that this is a problem that existed in the Exynos DP driver, > but somebody really ought to rewrite those parts to make use of the DRM > DP helpers. As I understand it from discussions in and , we shouldn't block merging the series but someone should pick up this work after the merge. So probably Yakir should fixup the problem pointed out by Guenter and send a new pull. -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Date: Thu, 31 Mar 2016 09:02:47 -0700 Message-ID: References: <1455534576-1486-1-git-send-email-ykk@rock-chips.com> <20160330203204.GA24156@roeck-us.net> <20160331095600.GD26032@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20160331095600.GD26032-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Guenter Roeck , Yakir Yang , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Krzysztof Kozlowski , Rob Herring , Heiko Stuebner , Mark Yao , Russell King , Daniel Kurtz , Sean Paul , Kukjin Kim , Kumar Gala , Emil Velikov , Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , Ajay kumar Ro List-Id: devicetree@vger.kernel.org Hi, On Thu, Mar 31, 2016 at 2:56 AM, Thierry Reding wrote: > Ugh... most of these functions shouldn't be there in the first place. We > have helpers in the core that already do this. Most of the functionality > is duplicated in this driver. > > I realize that this is a problem that existed in the Exynos DP driver, > but somebody really ought to rewrite those parts to make use of the DRM > DP helpers. As I understand it from discussions in and , we shouldn't block merging the series but someone should pick up this work after the merge. So probably Yakir should fixup the problem pointed out by Guenter and send a new pull. -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: dianders@chromium.org (Doug Anderson) Date: Thu, 31 Mar 2016 09:02:47 -0700 Subject: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory In-Reply-To: <20160331095600.GD26032@ulmo.nvidia.com> References: <1455534576-1486-1-git-send-email-ykk@rock-chips.com> <20160330203204.GA24156@roeck-us.net> <20160331095600.GD26032@ulmo.nvidia.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thu, Mar 31, 2016 at 2:56 AM, Thierry Reding wrote: > Ugh... most of these functions shouldn't be there in the first place. We > have helpers in the core that already do this. Most of the functionality > is duplicated in this driver. > > I realize that this is a problem that existed in the Exynos DP driver, > but somebody really ought to rewrite those parts to make use of the DRM > DP helpers. As I understand it from discussions in and , we shouldn't block merging the series but someone should pick up this work after the merge. So probably Yakir should fixup the problem pointed out by Guenter and send a new pull. -Doug