From: Doug Anderson <dianders@chromium.org>
To: Mansur Alisha Shaik <mansur@codeaurora.org>
Cc: stanimir.varbanov@linaro.org, LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
vgarodia@codeaurora.org
Subject: Re: [PATCH V2] venus: fix multiple encoder crash
Date: Mon, 1 Jun 2020 20:37:43 -0700 [thread overview]
Message-ID: <CAD=FV=Vt8je1AtT8id-rPC3JToF_7uGKpC-uDuSpzCkwi3e4Sw@mail.gmail.com> (raw)
In-Reply-To: <1588314480-22409-1-git-send-email-mansur@codeaurora.org>
Hi,
On Thu, Apr 30, 2020 at 11:28 PM Mansur Alisha Shaik
<mansur@codeaurora.org> wrote:
>
> Currently we are considering the instances which are available
> in core->inst list for load calculation in min_loaded_core()
> function, but this is incorrect because by the time we call
> decide_core() for second instance, the third instance not
> filled yet codec_freq_data pointer.
>
> Solve this by considering the instances whose session has started.
>
> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
> ---
> Changes in V2:
> - As per Alex and Jeffrey comments, elaborated problem
> and addressed review comments.
>
> drivers/media/platform/qcom/venus/pm_helpers.c | 4 ++++
> 1 file changed, 4 insertions(+)
This fixes the same crash I reported here:
https://lore.kernel.org/r/20200601150314.RFC.1.I1e40623bbe8fa43ff1415fc273cba66503b9b048@changeid
Thus:
Fixes: eff82f79c562 ("media: venus: introduce core selection")
Tested-by: Douglas Anderson <dianders@chromium.org>
I still have the same reservations I expressed in the patch I posed
about whether this is truly safe from a locking point of view, but
certainly it puts us in a better state than we are today.
-Doug
prev parent reply other threads:[~2020-06-02 3:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 6:28 [PATCH V2] venus: fix multiple encoder crash Mansur Alisha Shaik
2020-06-02 3:37 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Vt8je1AtT8id-rPC3JToF_7uGKpC-uDuSpzCkwi3e4Sw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mansur@codeaurora.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.