From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97978C433E0 for ; Fri, 29 May 2020 19:46:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 720C42067B for ; Fri, 29 May 2020 19:46:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fU1bOuEt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbgE2Tqm (ORCPT ); Fri, 29 May 2020 15:46:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726829AbgE2Tql (ORCPT ); Fri, 29 May 2020 15:46:41 -0400 Received: from mail-vk1-xa44.google.com (mail-vk1-xa44.google.com [IPv6:2607:f8b0:4864:20::a44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEB3DC08C5C8 for ; Fri, 29 May 2020 12:46:40 -0700 (PDT) Received: by mail-vk1-xa44.google.com with SMTP id e1so982182vkd.1 for ; Fri, 29 May 2020 12:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O4W5Sat/5R+Ack57F4Z6oQH+X3by1m0TX8wOY8Irmk0=; b=fU1bOuEt5ZzOPNFtsNlrTYxfPSrX/xHwM5J5MKGPDD6kgAzyoE6ZK5uDdK6EM1pkmb hRfASs8dsVBYo8LNKhDOUFKq3v+0ur6pZsEjP6dGBEEADcKT2QjKJ8Kr1pdyYWXrmxck r+P2wwlEVgG8xPVZY/Tnph8PuFxg8Ik4xRzJc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O4W5Sat/5R+Ack57F4Z6oQH+X3by1m0TX8wOY8Irmk0=; b=LkNFfBO3F0SGOA2lF67/47O6xPhIlRuDiF9YCAywYMzSYUMQP0CPbzrGt+oeN+TTos rGIo4ysykU+K1isLkqUZbBSTvStKDpnhuEw3lJCv1srUggsTTZq3nNneG+95R7q2F7kf c67wUrKvaebg6oV8qcTwNDopqGErU/o1Me6LTW96WspqwQ1nFx105aKDSA6FcCYuoQzG 2Z+9gyraG7OZpJYBZaNupYPj5CtgzXI2hUDrLXFvodyki12FTE7mbf4IS+QCR7vtcEmZ B7s2fANAdV6XWHFbBfGTcXs04Dl0PpXC31AhYZrntfMQLJqdU2tDC1XJPhQ1423P8fTG E9HA== X-Gm-Message-State: AOAM531pm8+2m0rVmL7+v5mRqDIr7gnWJ6hC1AHTatPozInUTrAhy/l0 5AnSkWYMnFtN61JcOBDmHBiF73aImy4= X-Google-Smtp-Source: ABdhPJwqsZRkQ1RZB1qTf1FgKRTB7GVClEIdjv4MTd5oTP7RiWiN+KhhYUzIpDQ/jLQgL9vvMXb7Tg== X-Received: by 2002:a1f:26c4:: with SMTP id m187mr7128180vkm.45.1590781599368; Fri, 29 May 2020 12:46:39 -0700 (PDT) Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com. [209.85.217.48]) by smtp.gmail.com with ESMTPSA id i27sm889912uab.17.2020.05.29.12.46.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2020 12:46:38 -0700 (PDT) Received: by mail-vs1-f48.google.com with SMTP id 1so2176025vsl.9 for ; Fri, 29 May 2020 12:46:38 -0700 (PDT) X-Received: by 2002:a67:1703:: with SMTP id 3mr7608885vsx.169.1590781598116; Fri, 29 May 2020 12:46:38 -0700 (PDT) MIME-Version: 1.0 References: <1d3bae1b3048f5d6e19f7ef569dd77e9e160a026.1590753016.git.hminas@synopsys.com> <0f6b1580-41d8-b7e7-206b-64cda87abfd5@synopsys.com> <20200529190031.GA2271@rowland.harvard.edu> <52f936c5-7f3f-5da0-33b8-3e6d4a4008d1@synopsys.com> In-Reply-To: From: Doug Anderson Date: Fri, 29 May 2020 12:46:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] usb: dwc2: Fix shutdown callback in platform To: Frank Mori Hess Cc: Minas Harutyunyan , Alan Stern , John Youn , Felipe Balbi , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "# 4.0+" Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi, On Fri, May 29, 2020 at 12:45 PM Frank Mori Hess wrote: > > On Fri, May 29, 2020 at 3:33 PM Minas Harutyunyan > wrote: > > So, can we conclude on this solution? > > > > dwc2_disable_global_interrupts(hsotg); > > synchronize_irq(hsotg->irq) > > That solution is fine with me. Disabling the dwc2 interrupt sources > in initialization before the handlers are registered is also worth > doing, but it doesn't have to be in the same patch. Sounds fine to me. -Doug