From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2A6A29A9 for ; Tue, 24 May 2022 23:01:08 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id gi33so29760050ejc.3 for ; Tue, 24 May 2022 16:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AfXveykq3TD1zXiLiN8Xn+jomOknax5klVDzfrxBWaI=; b=OVloHcVb8ZYQpTxf0U+F/gbrHMubuXtp7VHA1LNpOxiXYLSNwA4Eiz4qJxhrVc+FgR KzEyZhevzpjaUF9s8t0Qt8/rEIIp+N+hfCHG8CMS8QgZ3gvLVuDcHsq+cesjge/jtvaO HU9dsk2rML4K/QvxL+gdujr/Sd703RETVGdLM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AfXveykq3TD1zXiLiN8Xn+jomOknax5klVDzfrxBWaI=; b=k6JT+acqfVQ/lHTMas6TSR7TYFbWGf4qFun4rNCqKFgs2gAhSnTcLkjZtw1sz5tv07 8mgyK5mn22C/3Yr+EoRQETtSbWu5to/fe0uOw1iNPepEw9iJhC/lTYUnfZ3xtvJsjYw+ chYogy0VsOhzJAtTUtSw27aiobjXmh2UgV08BDdLoUbttV+jqHIzUX8BqS9zmaeZUAff KTazvWjpamlbVKLu1q+KSB+5dBWaKmnDwdLOBHujwGukzl3MsCOBxrfPo+X4soyx6laA Ut4vnJUS9sIxIKbg79SjnvEkBqcVmmteE6cHa0Kekea1hjvubDxQlJIeP0EA+vdGh1AV 27kw== X-Gm-Message-State: AOAM5316c2O48CVOcgEkUMmMgj+4u/+Lu2FciaRks5cJhuCiNesTOC4X Jyp7NAm9DDyfx5hXrWLyqV8YBLvFRtdBYh8hQfA= X-Google-Smtp-Source: ABdhPJyXIIJ2CBykcEoMaBsK7N0QOHcLowUUN0qdo1CjRj0jI6uybfbvABb9S5FfqQ0ZArs41ns0hw== X-Received: by 2002:a17:907:3d8a:b0:6ff:a9a:bea7 with SMTP id he10-20020a1709073d8a00b006ff0a9abea7mr2897385ejc.134.1653433266988; Tue, 24 May 2022 16:01:06 -0700 (PDT) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com. [209.85.128.53]) by smtp.gmail.com with ESMTPSA id fj11-20020a1709069c8b00b006ff05d4726esm914606ejc.50.2022.05.24.16.01.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 16:01:05 -0700 (PDT) Received: by mail-wm1-f53.google.com with SMTP id 67-20020a1c1946000000b00397382b44f4so2309117wmz.2 for ; Tue, 24 May 2022 16:01:05 -0700 (PDT) X-Received: by 2002:a05:600c:3d8c:b0:394:6097:9994 with SMTP id bi12-20020a05600c3d8c00b0039460979994mr5614440wmb.29.1653433264517; Tue, 24 May 2022 16:01:04 -0700 (PDT) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220520143502.v4.1.I71e42c6174f1cec17da3024c9f73ba373263b9b6@changeid> <20220520143502.v4.3.I9804fcd5d6c8552ab25f598dd7a3ea71b15b55f0@changeid> <7c1598a9-476d-0115-ab13-11dfa0d89436@linaro.org> In-Reply-To: From: Doug Anderson Date: Tue, 24 May 2022 16:00:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings To: Krzysztof Kozlowski Cc: Rob Herring , Bjorn Andersson , Matthias Kaehlcke , Alexandru M Stan , patches@lists.linux.dev, linux-arm-msm , Julius Werner , Andy Gross , Stephen Boyd , Krzysztof Kozlowski , Rajendra Nayak , "Joseph S . Barrera III" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Stephen Boyd , LKML Content-Type: text/plain; charset="UTF-8" Hi, On Tue, May 24, 2022 at 2:34 AM Krzysztof Kozlowski wrote: > > On 23/05/2022 18:16, Doug Anderson wrote: > > Hi, > > > > On Sun, May 22, 2022 at 12:57 AM Krzysztof Kozlowski > > wrote: > >> > >> On 20/05/2022 23:38, Douglas Anderson wrote: > >>> This copy-pastes compatibles from sc7180-based boards from the device > >>> trees to the yaml file so that `make dtbs_check` will be happy. > >>> > >>> NOTES: > >>> - I make no attempt to try to share an "item" for all sc7180 based > >>> Chromebooks. Because of the revision matching scheme used by the > >>> Chromebook bootloader, at times we need a different number of > >>> revisions listed. > >>> - Some of the odd entries in here (like google,homestar-rev23 or the > >>> fact that "Google Lazor Limozeen without Touchscreen" changed from > >>> sku5 to sku6) are not typos but simply reflect reality. > >>> - Many revisions of boards here never actually went to consumers, but > >>> they are still in use within various companies that were involved in > >>> Chromebook development. Since Chromebooks are developed with an > >>> "upstream first" methodology, having these revisions supported with > >>> upstream Linux is important. Making it easy for Chromebooks to be > >>> developed with an "upstream first" methodology is valuable to the > >>> upstream community because it improves the quality of upstream and > >>> gets Chromebooks supported with vanilla upstream faster. > >>> > >>> One other note here is that, though the bootloader effectively treats > >>> the list of compatibles in a given device tree as unordered, some > >>> people would prefer future boards to list higher-numbered revisions > >>> first in the list. Chromebooks here are not changing and typically > >>> list lower revisions first just to avoid churn. > >>> > >>> Signed-off-by: Douglas Anderson > >>> Reviewed-by: Matthias Kaehlcke > >>> --- > >>> > >>> (no changes since v3) > >>> > >>> Changes in v3: > >>> - Split link to Chromebook boot doc into a separate patch. > >>> - Added a note to desc about revision ordering within a device tree. > >>> > >>> Changes in v2: > >>> - Add link to doc about how Chromebook devicetrees work. > >>> - Use a "description" instead of a comment for each item. > >>> - Use the marketing name instead of the code name where possible. > >>> > >>> .../devicetree/bindings/arm/qcom.yaml | 182 +++++++++++++++++- > >>> 1 file changed, 181 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > >>> index 5ac28e11ea7b..01e40ea40724 100644 > >>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml > >>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > >>> @@ -219,11 +219,191 @@ properties: > >>> - qcom,ipq8074-hk10-c2 > >>> - const: qcom,ipq8074 > >>> > >>> - - items: > >>> + - description: Qualcomm Technologies, Inc. SC7180 IDP > >>> + items: > >>> - enum: > >>> - qcom,sc7180-idp > >>> - const: qcom,sc7180 > >>> > >>> + - description: HP Chromebook x2 11c (rev1 - 2) > >>> + items: > >>> + - const: google,coachz-rev1 > >>> + - const: google,coachz-rev2 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: HP Chromebook x2 11c (newest rev) > >>> + items: > >>> + - const: google,coachz > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: HP Chromebook x2 11c with LTE (rev1 - 2) > >>> + items: > >>> + - const: google,coachz-rev1-sku0 > >>> + - const: google,coachz-rev2-sku0 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: HP Chromebook x2 11c with LTE (newest rev) > >>> + items: > >>> + - const: google,coachz-sku0 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Lenovo Chromebook Duet 5 13 (rev2) > >>> + items: > >>> + - const: google,homestar-rev2 > >>> + - const: google,homestar-rev23 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Lenovo Chromebook Duet 5 13 (rev3) > >>> + items: > >>> + - const: google,homestar-rev3 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Lenovo Chromebook Duet 5 13 (newest rev) > >>> + items: > >>> + - const: google,homestar > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook Spin 513 (rev0) > >>> + items: > >>> + - const: google,lazor-rev0 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook Spin 513 (rev1 - 2) > >>> + items: > >>> + - const: google,lazor-rev1 > >>> + - const: google,lazor-rev2 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook Spin 513 (rev3 - 8) > >>> + items: > >>> + - const: google,lazor-rev3 > >>> + - const: google,lazor-rev4 > >>> + - const: google,lazor-rev5 > >>> + - const: google,lazor-rev6 > >>> + - const: google,lazor-rev7 > >>> + - const: google,lazor-rev8 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook Spin 513 (newest rev) > >>> + items: > >>> + - const: google,lazor > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook Spin 513 with KB Backlight (rev1 - 2) > >>> + items: > >>> + - const: google,lazor-rev1-sku2 > >>> + - const: google,lazor-rev2-sku2 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook Spin 513 with KB Backlight (rev3 - 8) > >>> + items: > >>> + - const: google,lazor-rev3-sku2 > >>> + - const: google,lazor-rev4-sku2 > >>> + - const: google,lazor-rev5-sku2 > >>> + - const: google,lazor-rev6-sku2 > >>> + - const: google,lazor-rev7-sku2 > >>> + - const: google,lazor-rev8-sku2 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook Spin 513 with KB Backlight (newest rev) > >>> + items: > >>> + - const: google,lazor-sku2 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook Spin 513 with LTE (rev1 - 2) > >>> + items: > >>> + - const: google,lazor-rev1-sku0 > >>> + - const: google,lazor-rev2-sku0 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook Spin 513 with LTE (rev3 - 8) > >>> + items: > >>> + - const: google,lazor-rev3-sku0 > >>> + - const: google,lazor-rev4-sku0 > >>> + - const: google,lazor-rev5-sku0 > >>> + - const: google,lazor-rev6-sku0 > >>> + - const: google,lazor-rev7-sku0 > >>> + - const: google,lazor-rev8-sku0 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook Spin 513 with LTE (newest rev) > >>> + items: > >>> + - const: google,lazor-sku0 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook 511 (rev4 - rev8) > >>> + items: > >>> + - const: google,lazor-rev4-sku4 > >>> + - const: google,lazor-rev5-sku4 > >>> + - const: google,lazor-rev6-sku4 > >>> + - const: google,lazor-rev7-sku4 > >>> + - const: google,lazor-rev8-sku4 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook 511 (newest rev) > >>> + items: > >>> + - const: google,lazor-sku4 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook 511 without Touchscreen (rev4) > >>> + items: > >>> + - const: google,lazor-rev4-sku5 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook 511 without Touchscreen (rev5 - rev8) > >>> + items: > >>> + - const: google,lazor-rev5-sku5 > >>> + - const: google,lazor-rev5-sku6 > >>> + - const: google,lazor-rev6-sku6 > >>> + - const: google,lazor-rev7-sku6 > >>> + - const: google,lazor-rev8-sku6 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Acer Chromebook 511 without Touchscreen (newest rev) > >>> + items: > >>> + - const: google,lazor-sku6 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Sharp Dynabook Chromebook C1 (rev1) > >>> + items: > >>> + - const: google,pompom-rev1 > >>> + - const: qcom,sc7180 > >>> + > >>> + - description: Sharp Dynabook Chromebook C1 (rev2) > >>> + items: > >>> + - const: google,pompom-rev2 > >> > >> I understand why you do not share "item" (your first notes) for some of > >> boards, but I don't get why "google,pompom-rev1" cannot be combined with > >> "google,pompom-rev2". Do you see any chances to alter the bindings for > >> these two boards? > >> > >> The same for other such cases (not newest revision). > > > > Yeah, I thought about it when I was writing the file and decided > > against it. I guess it's just a style decision. If we combine these > > two then I guess it raises the question: do we only combine entries > > that list a single revision if they're the same board, or do we have > > one uber entry at the end of the list that combines all > > single-revision sc7180 Chromebooks? ...and in either case, what should > > the description be? > > > > Personally, though it takes up more lines of code, I prefer the > > simplicity of having each entry here correspond to a single dts file. > > > > Unless you feel really strongly about it, I'd tend to leave the > > decision here to Bjorn. > > Sure. I would prefer to combine such obvious entries, so not everything > into one, but the same boards with revision/SKU difference. > > For both cases: > Reviewed-by: Krzysztof Kozlowski OK, thanks! For now, I'll wait for a tiebreaker. If Bjorn or Stephen or Matthias wants to chime in and says they'd prefer things be combined too then I'll spin like that. Otherwise, I'll leave it like this. -Doug