From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B85C43334 for ; Thu, 2 Jun 2022 21:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239493AbiFBVsj (ORCPT ); Thu, 2 Jun 2022 17:48:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234954AbiFBVsh (ORCPT ); Thu, 2 Jun 2022 17:48:37 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59B821DA77 for ; Thu, 2 Jun 2022 14:48:36 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id s6so909329eja.0 for ; Thu, 02 Jun 2022 14:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PlQ+AfYx33ch5Af1MOc8eSZOWrp4sa+5BG8p2IQdVOQ=; b=LQbMJioZzGwe6/fK5um+5Ha94Y3saA4t6tLL33c0D7+smsDYIjGyCJ62XISlVIfDnb k7+IGE4QIPIQO60LtADGNIslNBNGIZ5QqLEoOEwAapZhW8OmMhz8yMIQrfL9zX/HltC7 qkwO9hwIWO1HMZSqakKMcSasFiJdp5cXvDCAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PlQ+AfYx33ch5Af1MOc8eSZOWrp4sa+5BG8p2IQdVOQ=; b=jaeEKKSkR3inz3O8aPtMWe+LbVGDjFkd+X3vhWsLXR4v8C4fyKq7xbFuyFXkUPvcvA heDMEFNtMwbznEAQdDGDMZ7rM5YkPNfe+xM3xPDfEgaj9TzxK65yuP8wnlMjiMEeH2+q qGZeswQX3U8jhnIjh5QfoceU7AH/zFLuVM1RhTQo7GXMeIDBsxw6rhaYZYcFEpLGXaMI di7kp4nWljL35y4TbxRhaKpw7z2X1tV7o4s1WUaUPXVwVCA0NOw0oOC93BZM6TVw+wTV KTfczGSC2VhFfwpVMsDnCo7WwEBGRoBAcGLnPCrctWDuBUrLefAyuYmCJSkqYFllbEkf MATQ== X-Gm-Message-State: AOAM530TpKrL3UTifbd3k0lnXvvBZ/4P/t4QyNCvsTbAlnZ3N9Fe2Fkc HnksfSOaFVrWi63m2tmd0w0/h0SY9hLtCpHJ X-Google-Smtp-Source: ABdhPJwwz+bUVOpWXkknSNSCJSxFuzavZHAFV1WyqPS/Ej6uTrQLFYaLsQVVutCmJtmbibcw50b59Q== X-Received: by 2002:a17:907:2daa:b0:6fe:b449:6a8f with SMTP id gt42-20020a1709072daa00b006feb4496a8fmr5980945ejc.318.1654206514601; Thu, 02 Jun 2022 14:48:34 -0700 (PDT) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com. [209.85.128.49]) by smtp.gmail.com with ESMTPSA id l1-20020a1709060e0100b006fec4ee28d0sm722773eji.189.2022.06.02.14.48.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 14:48:33 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id n185so3190390wmn.4 for ; Thu, 02 Jun 2022 14:48:33 -0700 (PDT) X-Received: by 2002:a05:600c:4f0c:b0:397:75d7:613 with SMTP id l12-20020a05600c4f0c00b0039775d70613mr35121379wmq.34.1654206512562; Thu, 02 Jun 2022 14:48:32 -0700 (PDT) MIME-Version: 1.0 References: <20220601094637.1200634-1-hsinyi@chromium.org> In-Reply-To: <20220601094637.1200634-1-hsinyi@chromium.org> From: Doug Anderson Date: Thu, 2 Jun 2022 14:48:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/8] Add a panel API to return panel orientation To: Hsin-Yi Wang Cc: Chun-Kuang Hu , Hans de Goede , Thierry Reding , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel , "moderated list:ARM/Mediatek SoC support" , Rob Clark , Stephen Boyd , Rob Herring , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jun 1, 2022 at 2:46 AM Hsin-Yi Wang wrote: > > Panels usually call drm_connector_set_panel_orientation(), which is > later than drm/kms driver calling drm_dev_register(). This leads to a > WARN()[1]. > > The orientation property is known earlier. For example, some panels > parse the property through device tree during probe. > > The series add a panel API drm_panel_get_orientation() for drm/kms > drivers. The drivers can use the API to get panel's orientation, so they > can call drm_connector_set_panel_orientation() before drm_dev_register(). > > Panel needs to implement .get_orientation callback to return the property. > > [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220530081910.3947168-2-hsinyi@chromium.org/ > > Hsin-Yi Wang (8): > drm/panel: Add an API drm_panel_get_orientation() to return panel > orientation > drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback > drm/panel: panel-edp: Implement .get_orientation callback > drm/panel: lvds: Implement .get_orientation callback > drm/panel: panel-simple: Implement .get_orientation callback > drm/panel: ili9881c: Implement .get_orientation callback > drm/panel: elida-kd35t133: Implement .get_orientation callback > drm/mediatek: Config orientation property if panel provides it > > drivers/gpu/drm/drm_panel.c | 8 ++++++++ > drivers/gpu/drm/mediatek/mtk_dsi.c | 10 ++++++++++ > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-edp.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-lvds.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-simple.c | 9 +++++++++ > include/drm/drm_panel.h | 10 ++++++++++ > 9 files changed, 77 insertions(+) Seems reasonable to me. I added a request to the panel-edp patch that probably applies to all of the panel patches requesting a comment next to the old calls in get_modes(). I assume that all but patch #8 ought to land through drm-misc. I'm happy to help commit them once everyone is happy. If the Mediatek maintainer(s) want to Ack patch #8 I can land that in drm-misc too. If we want something fancier like an immutable branch you'll probably have to get someone involved that's got a higher drm pay grade than me. ;-) -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1038EC433EF for ; Thu, 2 Jun 2022 21:48:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7337710EF4A; Thu, 2 Jun 2022 21:48:39 +0000 (UTC) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E0FC10ED78 for ; Thu, 2 Jun 2022 21:48:37 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id w27so7892356edl.7 for ; Thu, 02 Jun 2022 14:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PlQ+AfYx33ch5Af1MOc8eSZOWrp4sa+5BG8p2IQdVOQ=; b=LQbMJioZzGwe6/fK5um+5Ha94Y3saA4t6tLL33c0D7+smsDYIjGyCJ62XISlVIfDnb k7+IGE4QIPIQO60LtADGNIslNBNGIZ5QqLEoOEwAapZhW8OmMhz8yMIQrfL9zX/HltC7 qkwO9hwIWO1HMZSqakKMcSasFiJdp5cXvDCAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PlQ+AfYx33ch5Af1MOc8eSZOWrp4sa+5BG8p2IQdVOQ=; b=yuZaZJHkbO0nLmWflf5r38wzB6Eh7Zc3AXdWL/gbUgA9oa8Vzi8OVPxF5KiHtnS/qK VyLqyqqPdzt+iyBpH0nnRL1ACQiAsDG3pklA3DetefnNSfOjl9Z2rEYMjVO36OHw6Xj+ L8wmu49uii1/6Wxy3LJvtkKdauuYprP3QrP11Kb26KqeOdsXlZWXMMOGIvjZ5fZFPfRN xis46E1Tm3aOLqMEyJAmCbanXLcpKMEJ5djSKifC98KSHFMBecy2pqWaKH8pgpjNv1BA zzov7N1JC4F0vUMxuItmuzAn0AuSD164BdxQqMwcn4MyTDBNI9VCQeRw4QEg5PNS044c HjhA== X-Gm-Message-State: AOAM532Z5dVQ3Ri+98AeWgp+dvmESyUgcNARlbrmhJOD6Lz9qovVFaSn N7M6P2iuNncVJ/QILZpbdZni5ajWUdDZQyug X-Google-Smtp-Source: ABdhPJzS7fGPW7zV/46btlx5HzR4lM69Cy497r5dDhK+LXlmYBOAXkLv2jQKdDe+NgaXNNeZy95yNA== X-Received: by 2002:a05:6402:378b:b0:42a:ad8c:628f with SMTP id et11-20020a056402378b00b0042aad8c628fmr7649768edb.90.1654206515708; Thu, 02 Jun 2022 14:48:35 -0700 (PDT) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com. [209.85.128.48]) by smtp.gmail.com with ESMTPSA id c18-20020a056402101200b0042dc6e250e3sm2992688edu.81.2022.06.02.14.48.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 14:48:33 -0700 (PDT) Received: by mail-wm1-f48.google.com with SMTP id r129so3188838wmr.3 for ; Thu, 02 Jun 2022 14:48:33 -0700 (PDT) X-Received: by 2002:a05:600c:4f0c:b0:397:75d7:613 with SMTP id l12-20020a05600c4f0c00b0039775d70613mr35121379wmq.34.1654206512562; Thu, 02 Jun 2022 14:48:32 -0700 (PDT) MIME-Version: 1.0 References: <20220601094637.1200634-1-hsinyi@chromium.org> In-Reply-To: <20220601094637.1200634-1-hsinyi@chromium.org> From: Doug Anderson Date: Thu, 2 Jun 2022 14:48:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/8] Add a panel API to return panel orientation To: Hsin-Yi Wang Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Chun-Kuang Hu , Rob Herring , David Airlie , LKML , Stephen Boyd , Hans de Goede , Thierry Reding , "moderated list:ARM/Mediatek SoC support" , dri-devel , Thomas Zimmermann , Matthias Brugger , Sam Ravnborg , Linux ARM Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Wed, Jun 1, 2022 at 2:46 AM Hsin-Yi Wang wrote: > > Panels usually call drm_connector_set_panel_orientation(), which is > later than drm/kms driver calling drm_dev_register(). This leads to a > WARN()[1]. > > The orientation property is known earlier. For example, some panels > parse the property through device tree during probe. > > The series add a panel API drm_panel_get_orientation() for drm/kms > drivers. The drivers can use the API to get panel's orientation, so they > can call drm_connector_set_panel_orientation() before drm_dev_register(). > > Panel needs to implement .get_orientation callback to return the property. > > [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220530081910.3947168-2-hsinyi@chromium.org/ > > Hsin-Yi Wang (8): > drm/panel: Add an API drm_panel_get_orientation() to return panel > orientation > drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback > drm/panel: panel-edp: Implement .get_orientation callback > drm/panel: lvds: Implement .get_orientation callback > drm/panel: panel-simple: Implement .get_orientation callback > drm/panel: ili9881c: Implement .get_orientation callback > drm/panel: elida-kd35t133: Implement .get_orientation callback > drm/mediatek: Config orientation property if panel provides it > > drivers/gpu/drm/drm_panel.c | 8 ++++++++ > drivers/gpu/drm/mediatek/mtk_dsi.c | 10 ++++++++++ > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-edp.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-lvds.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-simple.c | 9 +++++++++ > include/drm/drm_panel.h | 10 ++++++++++ > 9 files changed, 77 insertions(+) Seems reasonable to me. I added a request to the panel-edp patch that probably applies to all of the panel patches requesting a comment next to the old calls in get_modes(). I assume that all but patch #8 ought to land through drm-misc. I'm happy to help commit them once everyone is happy. If the Mediatek maintainer(s) want to Ack patch #8 I can land that in drm-misc too. If we want something fancier like an immutable branch you'll probably have to get someone involved that's got a higher drm pay grade than me. ;-) -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81C93C433EF for ; Thu, 2 Jun 2022 21:50:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P0xJOUVN53TNsviJJxuGDJDEhK/D9wy2L0xXmZqMYXA=; b=vazWXC14bruM+d XgX5l1TG6a4dV8pzS+Lze8lcPQAuc/mYMi9yoRIx5DphbxGJVyn8eily/6gaIHjwueAuG3milyxWR DYaYJgTUDNndbFM21mm1wpoVL4GWpfyX84aSM/xRkPv6l/dIzdOWn4OQnZ06ZzqLryHoqAfSv2V1v neJ8Yw1FIaCBYqVn2/JC++uTFTetvXjb6RrwKaNZhTt1pPKB+OSmuyQEUWzqnLfwcvHHJcNeE7TeF up5XfDjQjh0LVOH9p3xAfgwGm1vLW4xng+Txagd++AeUNs3VwZJRZ0ZZHqV8fgFb+fImmYdF1Z5yT gEMthqSNpNEdRfPR0Xfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwsgL-004QB4-Di; Thu, 02 Jun 2022 21:48:41 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwsgI-004Q9c-56 for linux-arm-kernel@lists.infradead.org; Thu, 02 Jun 2022 21:48:39 +0000 Received: by mail-ed1-x536.google.com with SMTP id x62so7904742ede.10 for ; Thu, 02 Jun 2022 14:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PlQ+AfYx33ch5Af1MOc8eSZOWrp4sa+5BG8p2IQdVOQ=; b=LQbMJioZzGwe6/fK5um+5Ha94Y3saA4t6tLL33c0D7+smsDYIjGyCJ62XISlVIfDnb k7+IGE4QIPIQO60LtADGNIslNBNGIZ5QqLEoOEwAapZhW8OmMhz8yMIQrfL9zX/HltC7 qkwO9hwIWO1HMZSqakKMcSasFiJdp5cXvDCAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PlQ+AfYx33ch5Af1MOc8eSZOWrp4sa+5BG8p2IQdVOQ=; b=nRDSWW/AP0NjHRNCGbTNOz69lAlp1OvkdhKKwi8QMPZ/0cIQh9mBE6DkHgrNd587l0 lCB+W0Rvm7dGpfdsaTSUJQa7PTm/7ohjoGhUPe2sVXux2CGLkShlL0m2g/AD0Bg7NWL+ jYLMdjct4QKdrjkNNC4phm/MAoBKmPtWgV0RnPb5xl0Tpd1B7e3GzbAmNwNKr3DnzAMN ImpXer8iYx2XsAhtHlekjsn/+HOScHiixzxNFXT72WW4ledhXRwkJb+CkAnn68KaMwmy YnoJ1YJjugZSC9Z5Xeql4/37VGzYurA5mktdLyWff2P7BXu+6ezhmwVPQ7tRArKFsFV/ Ctrg== X-Gm-Message-State: AOAM533Vjk5o7G0MFFmx4elC6B+z2LrogU1FrJX5XYlEsKiiqAY77scy e/WteM6vn4CFvctkJoNZSipOWnPHlanHm6TY X-Google-Smtp-Source: ABdhPJzQQkUKZ3cLm3iiQiVqqmXRxGwFx7eMGFQ1fGDJXS4qFQy7nGkXjW/ntxi1qHVIcNdq4rl/qw== X-Received: by 2002:a05:6402:5415:b0:42b:228:5cf with SMTP id ev21-20020a056402541500b0042b022805cfmr7481087edb.245.1654206515388; Thu, 02 Jun 2022 14:48:35 -0700 (PDT) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com. [209.85.128.50]) by smtp.gmail.com with ESMTPSA id kz10-20020a17090777ca00b0070beb9401d9sm778615ejc.171.2022.06.02.14.48.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 14:48:33 -0700 (PDT) Received: by mail-wm1-f50.google.com with SMTP id f23-20020a7bcc17000000b003972dda143eso5420129wmh.3 for ; Thu, 02 Jun 2022 14:48:33 -0700 (PDT) X-Received: by 2002:a05:600c:4f0c:b0:397:75d7:613 with SMTP id l12-20020a05600c4f0c00b0039775d70613mr35121379wmq.34.1654206512562; Thu, 02 Jun 2022 14:48:32 -0700 (PDT) MIME-Version: 1.0 References: <20220601094637.1200634-1-hsinyi@chromium.org> In-Reply-To: <20220601094637.1200634-1-hsinyi@chromium.org> From: Doug Anderson Date: Thu, 2 Jun 2022 14:48:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/8] Add a panel API to return panel orientation To: Hsin-Yi Wang Cc: Chun-Kuang Hu , Hans de Goede , Thierry Reding , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel , "moderated list:ARM/Mediatek SoC support" , Rob Clark , Stephen Boyd , Rob Herring , Linux ARM , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_144838_268784_04D6AB3E X-CRM114-Status: GOOD ( 21.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jun 1, 2022 at 2:46 AM Hsin-Yi Wang wrote: > > Panels usually call drm_connector_set_panel_orientation(), which is > later than drm/kms driver calling drm_dev_register(). This leads to a > WARN()[1]. > > The orientation property is known earlier. For example, some panels > parse the property through device tree during probe. > > The series add a panel API drm_panel_get_orientation() for drm/kms > drivers. The drivers can use the API to get panel's orientation, so they > can call drm_connector_set_panel_orientation() before drm_dev_register(). > > Panel needs to implement .get_orientation callback to return the property. > > [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220530081910.3947168-2-hsinyi@chromium.org/ > > Hsin-Yi Wang (8): > drm/panel: Add an API drm_panel_get_orientation() to return panel > orientation > drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback > drm/panel: panel-edp: Implement .get_orientation callback > drm/panel: lvds: Implement .get_orientation callback > drm/panel: panel-simple: Implement .get_orientation callback > drm/panel: ili9881c: Implement .get_orientation callback > drm/panel: elida-kd35t133: Implement .get_orientation callback > drm/mediatek: Config orientation property if panel provides it > > drivers/gpu/drm/drm_panel.c | 8 ++++++++ > drivers/gpu/drm/mediatek/mtk_dsi.c | 10 ++++++++++ > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-edp.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-lvds.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-simple.c | 9 +++++++++ > include/drm/drm_panel.h | 10 ++++++++++ > 9 files changed, 77 insertions(+) Seems reasonable to me. I added a request to the panel-edp patch that probably applies to all of the panel patches requesting a comment next to the old calls in get_modes(). I assume that all but patch #8 ought to land through drm-misc. I'm happy to help commit them once everyone is happy. If the Mediatek maintainer(s) want to Ack patch #8 I can land that in drm-misc too. If we want something fancier like an immutable branch you'll probably have to get someone involved that's got a higher drm pay grade than me. ;-) -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD422C433EF for ; Thu, 2 Jun 2022 21:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d7mJccDEWEJ90KwIeQfFnJ0JrwdhiykptFcHxoxE6m0=; b=dFGEt13iHPcmPq Ng0Yg4KkKcB7taPQappwQ28ipi32QA5HeMY5wNX+9H0Pj0e7FpK3VeXjPBSq36csfhIz8uqE95OrO zDbwasY/dCUmv2lWatwRGIHfULhfl8yfkt4emGZbKVrT9JPi6KWdHHKTLuhzrZMh5oZ9OBfugny7d kS3fcb7snon6VfECqhX2RqydT+8OGcw8Rs2LBEMO/XeNI0pJYG0Y0eGWppXVW785IQm2zpPtNd8WA COcrYiEtu8ZtmFC5F2Zj4xp1NKqhwGqweeSoTqN0oba4jBPWGe4CWJ0NEJGAbcWA5wiGUefNk8zf2 dBqsB4UCtYtnJpqps69A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwslK-004S9K-N8; Thu, 02 Jun 2022 21:53:50 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwslI-004S4v-8x for linux-mediatek@lists.infradead.org; Thu, 02 Jun 2022 21:53:49 +0000 Received: by mail-ej1-x62a.google.com with SMTP id s6so928873eja.0 for ; Thu, 02 Jun 2022 14:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PlQ+AfYx33ch5Af1MOc8eSZOWrp4sa+5BG8p2IQdVOQ=; b=LQbMJioZzGwe6/fK5um+5Ha94Y3saA4t6tLL33c0D7+smsDYIjGyCJ62XISlVIfDnb k7+IGE4QIPIQO60LtADGNIslNBNGIZ5QqLEoOEwAapZhW8OmMhz8yMIQrfL9zX/HltC7 qkwO9hwIWO1HMZSqakKMcSasFiJdp5cXvDCAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PlQ+AfYx33ch5Af1MOc8eSZOWrp4sa+5BG8p2IQdVOQ=; b=d8UTTDqVXFbSlEGkgsmtsjqa/uiB3+YIkqEfnSwMWtewJPvewM1fbzIuUlW7ep3SlR IEs89B52sUjt8I9EllL+19jRLsuD6r7VR42MaGtYtiASFA0d60Oa5Z3okDU9ZIIdfgPP te29q0DGWaiK3g6xM5rouotyumc0WVV8QWYLuWuJ1/LhBcZKtY4lwcNNC0gDSZnu40JC GQw4YDDUsVABAqY5mndaEwpP9LB9hC7P3eVmSxnvpufOS/RfuKeJhTyN3kNIkzN+xj58 paadl6wA4LqSsfzslH0TlZCfSktEdrikMNIg5zv4BNi8Ima3RSEprJ+nNtRmkyiRXnKN 3Rfg== X-Gm-Message-State: AOAM532Lss3lMIu9ZFP/zvlcG8Nd1VCnbkW8InbRGaTuzhXPsBzkFUrD 3Pv/07xFiTfzhE0WlTDW45XtpP9ElBca/NHE X-Google-Smtp-Source: ABdhPJyy/KnGqw8ilFRMp7kcbtkKv3fNz/S8knTtUvfdktBwjxBij3HN3AIsLURMWtYvGDgss0IUgg== X-Received: by 2002:a17:906:6806:b0:703:1f4e:9868 with SMTP id k6-20020a170906680600b007031f4e9868mr6065005ejr.699.1654206820525; Thu, 02 Jun 2022 14:53:40 -0700 (PDT) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com. [209.85.128.49]) by smtp.gmail.com with ESMTPSA id 8-20020a170906300800b00704dccefd2bsm2110304ejz.204.2022.06.02.14.53.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 14:53:40 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id a10so662197wmj.5 for ; Thu, 02 Jun 2022 14:53:39 -0700 (PDT) X-Received: by 2002:a05:600c:4f0c:b0:397:75d7:613 with SMTP id l12-20020a05600c4f0c00b0039775d70613mr35121379wmq.34.1654206512562; Thu, 02 Jun 2022 14:48:32 -0700 (PDT) MIME-Version: 1.0 References: <20220601094637.1200634-1-hsinyi@chromium.org> In-Reply-To: <20220601094637.1200634-1-hsinyi@chromium.org> From: Doug Anderson Date: Thu, 2 Jun 2022 14:48:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/8] Add a panel API to return panel orientation To: Hsin-Yi Wang Cc: Chun-Kuang Hu , Hans de Goede , Thierry Reding , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel , "moderated list:ARM/Mediatek SoC support" , Rob Clark , Stephen Boyd , Rob Herring , Linux ARM , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_145348_368723_7707CEC8 X-CRM114-Status: GOOD ( 20.23 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jun 1, 2022 at 2:46 AM Hsin-Yi Wang wrote: > > Panels usually call drm_connector_set_panel_orientation(), which is > later than drm/kms driver calling drm_dev_register(). This leads to a > WARN()[1]. > > The orientation property is known earlier. For example, some panels > parse the property through device tree during probe. > > The series add a panel API drm_panel_get_orientation() for drm/kms > drivers. The drivers can use the API to get panel's orientation, so they > can call drm_connector_set_panel_orientation() before drm_dev_register(). > > Panel needs to implement .get_orientation callback to return the property. > > [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220530081910.3947168-2-hsinyi@chromium.org/ > > Hsin-Yi Wang (8): > drm/panel: Add an API drm_panel_get_orientation() to return panel > orientation > drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback > drm/panel: panel-edp: Implement .get_orientation callback > drm/panel: lvds: Implement .get_orientation callback > drm/panel: panel-simple: Implement .get_orientation callback > drm/panel: ili9881c: Implement .get_orientation callback > drm/panel: elida-kd35t133: Implement .get_orientation callback > drm/mediatek: Config orientation property if panel provides it > > drivers/gpu/drm/drm_panel.c | 8 ++++++++ > drivers/gpu/drm/mediatek/mtk_dsi.c | 10 ++++++++++ > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-edp.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-lvds.c | 8 ++++++++ > drivers/gpu/drm/panel/panel-simple.c | 9 +++++++++ > include/drm/drm_panel.h | 10 ++++++++++ > 9 files changed, 77 insertions(+) Seems reasonable to me. I added a request to the panel-edp patch that probably applies to all of the panel patches requesting a comment next to the old calls in get_modes(). I assume that all but patch #8 ought to land through drm-misc. I'm happy to help commit them once everyone is happy. If the Mediatek maintainer(s) want to Ack patch #8 I can land that in drm-misc too. If we want something fancier like an immutable branch you'll probably have to get someone involved that's got a higher drm pay grade than me. ;-) -Doug _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek