From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8556DC47255 for ; Sat, 9 May 2020 22:50:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 598EA208DB for ; Sat, 9 May 2020 22:50:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Tkqv2f5g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728420AbgEIWt7 (ORCPT ); Sat, 9 May 2020 18:49:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726908AbgEIWt7 (ORCPT ); Sat, 9 May 2020 18:49:59 -0400 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48ADFC061A0C for ; Sat, 9 May 2020 15:49:59 -0700 (PDT) Received: by mail-vs1-xe41.google.com with SMTP id g2so3367375vsb.4 for ; Sat, 09 May 2020 15:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TXUBBXmljQ5wXNIAowkwYkd4kb/4nsVYm0GYUwUuYac=; b=Tkqv2f5gzC+XAAIPgdH4R2bngWQK+egYnu5AfQSyhmjrOFiaTRmfAv7lxgLnmQRtYh NBnfLaEJwQKjW3zaO8N1Ey2h0IUcGByzxK0QPSE9/2kqI0YP0aHCLIuvqeL3qlQkJmgq GdgmD/Eytja1TI6YPeB/tQ7b4pxyojrn+yLps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TXUBBXmljQ5wXNIAowkwYkd4kb/4nsVYm0GYUwUuYac=; b=c+zgqaM517Awel46NKO5a7LjboKPR+KfPvKaLL/CVnF5+O4E8BNzjQR8GL3eu28Fdy DcAW5lHZwxO88buf/mkxFlnhpvZvYXBZU4zaLQzMSu7eHTKSCnLNhcpAAMvqJ2tCBl8t F0K5ABITjK+0QfXTazBQmXQRnXnVOiWDhL1pJnSz9YqMDXT4sPdjnC8dDE8hfUdv6zv6 UFrzo4KWIvVyIyKbAnQefAzyhVdcelUFlrgpDb4oYOXfjuJ2PL0/zv2HPlGp5x/cUNb+ d5GMjHPiQtVvvGCAjqXDlaBU7gNZPKfsvl/htgsnOaDRCIx+qGZ3TJJckSAqfzSi4kma fMiw== X-Gm-Message-State: AGi0PuZ+qiP7Rf+iPFpOZj3LkoSZn4OFDN/9NCa9UDky9+0heJEPEBfw 59pROtxJjC53zd3U2heMjZrxNFjNDBU= X-Google-Smtp-Source: APiQypLbHgv1ixX+qTKGmp7XsSqN8OA8NHtq0R9wZfp8E3RUSyskepfnnNjtBX4e5h8V0tmXXXlp5w== X-Received: by 2002:a67:d81b:: with SMTP id e27mr7155253vsj.40.1589064598196; Sat, 09 May 2020 15:49:58 -0700 (PDT) Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com. [209.85.222.54]) by smtp.gmail.com with ESMTPSA id y143sm5341337vky.9.2020.05.09.15.49.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 15:49:57 -0700 (PDT) Received: by mail-ua1-f54.google.com with SMTP id 36so2047258uaf.9 for ; Sat, 09 May 2020 15:49:57 -0700 (PDT) X-Received: by 2002:ab0:45c7:: with SMTP id u65mr7022602uau.8.1589064596879; Sat, 09 May 2020 15:49:56 -0700 (PDT) MIME-Version: 1.0 References: <20200508155859.1.I4d29651c0837b4095fb4951253f44036a371732f@changeid> <20200509200021.GA30802@ravnborg.org> In-Reply-To: <20200509200021.GA30802@ravnborg.org> From: Doug Anderson Date: Sat, 9 May 2020 15:49:45 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61 To: Sam Ravnborg Cc: Thierry Reding , Rob Clark , linux-arm-msm , Bjorn Andersson , Daniel Vetter , David Airlie , dri-devel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Sat, May 9, 2020 at 1:00 PM Sam Ravnborg wrote: > > Hi Douglas > > On Fri, May 08, 2020 at 03:59:00PM -0700, Douglas Anderson wrote: > > The BOE NV133FHM-N61 is documented in the original commit to be a > > 13.3" panel, but the size listed in our struct doesn't match. > > Specifically: > > > > math.sqrt(30.0 * 30.0 + 18.7 * 18.7) / 2.54 ==> 13.92 > > > > Searching around on the Internet shows that the size that was in the > > structure was the "Outline Size", not the "Display Area". Let's fix > > it. > > > > Also the Internet says that this panel supports 262K colors. That's > > 6bpp, not 8bpp. > > > > Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61") > > Signed-off-by: Douglas Anderson > > Added to drm-misc-next as I did not think this had to be updated in > mainline right now. Let me know if you expect it to land in mainline > soonish. drm-misc-next is perfect, thanks! -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E8FFC54E49 for ; Sat, 9 May 2020 22:50:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5050A208DB for ; Sat, 9 May 2020 22:50:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Tkqv2f5g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5050A208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB36E89CF6; Sat, 9 May 2020 22:50:00 +0000 (UTC) Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9063189CF6 for ; Sat, 9 May 2020 22:49:59 +0000 (UTC) Received: by mail-vs1-xe44.google.com with SMTP id l25so3363799vso.6 for ; Sat, 09 May 2020 15:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TXUBBXmljQ5wXNIAowkwYkd4kb/4nsVYm0GYUwUuYac=; b=Tkqv2f5gzC+XAAIPgdH4R2bngWQK+egYnu5AfQSyhmjrOFiaTRmfAv7lxgLnmQRtYh NBnfLaEJwQKjW3zaO8N1Ey2h0IUcGByzxK0QPSE9/2kqI0YP0aHCLIuvqeL3qlQkJmgq GdgmD/Eytja1TI6YPeB/tQ7b4pxyojrn+yLps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TXUBBXmljQ5wXNIAowkwYkd4kb/4nsVYm0GYUwUuYac=; b=iCYkts6Z7WH0uuznqLaNeZs/RjvleJoLMms2X0yENbPbViQzQ/48CB3fVVN0i+GeqX zmu+JJA1cD2SWh0FTPRomQizN6x/3TuxAjk8JAWiqIrOfrWBPrGtGYSscuhcJlkDoLT8 pVF1I+j8y2mxn4cp1qqcsJ4gDCbJmOyZrjQowRGOjErfHYCUP+NQrw0rOq4sQA/1rfRW a80ffnnY0bsG4hOZR5B75GIHCDlFm5FJTbVGjWoQdmz4k06eNeLEk5WeJUduQ/f0RB+V qTv7tvG5J8qbdFf7Xm4JbOnITHF6OG/FD+/fBpUfuqX5Nw3cxqeHubZnJ0b/g6kmbAYy OhqA== X-Gm-Message-State: AGi0PuaNJKaSspwPtSz3n6tORrcZWu3ZFfoqXinntCZUFq7XSlLimB3s C+CrQmweCu0PMQzpcmfOgyus6VuQ7H0= X-Google-Smtp-Source: APiQypJAxsZ0MmjSPrtx6VWVOHVejOZKPgf0qso6+qDZt0RvM1LRC6ntqe4KtH3cB5gJC/a3b1EoQw== X-Received: by 2002:a05:6102:3cc:: with SMTP id n12mr6201684vsq.156.1589064598152; Sat, 09 May 2020 15:49:58 -0700 (PDT) Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com. [209.85.222.49]) by smtp.gmail.com with ESMTPSA id u25sm5247974vkn.22.2020.05.09.15.49.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 15:49:57 -0700 (PDT) Received: by mail-ua1-f49.google.com with SMTP id z16so2049967uae.11 for ; Sat, 09 May 2020 15:49:57 -0700 (PDT) X-Received: by 2002:ab0:45c7:: with SMTP id u65mr7022602uau.8.1589064596879; Sat, 09 May 2020 15:49:56 -0700 (PDT) MIME-Version: 1.0 References: <20200508155859.1.I4d29651c0837b4095fb4951253f44036a371732f@changeid> <20200509200021.GA30802@ravnborg.org> In-Reply-To: <20200509200021.GA30802@ravnborg.org> From: Doug Anderson Date: Sat, 9 May 2020 15:49:45 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61 To: Sam Ravnborg X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , David Airlie , linux-arm-msm , LKML , dri-devel , Bjorn Andersson , Thierry Reding Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Sat, May 9, 2020 at 1:00 PM Sam Ravnborg wrote: > > Hi Douglas > > On Fri, May 08, 2020 at 03:59:00PM -0700, Douglas Anderson wrote: > > The BOE NV133FHM-N61 is documented in the original commit to be a > > 13.3" panel, but the size listed in our struct doesn't match. > > Specifically: > > > > math.sqrt(30.0 * 30.0 + 18.7 * 18.7) / 2.54 ==> 13.92 > > > > Searching around on the Internet shows that the size that was in the > > structure was the "Outline Size", not the "Display Area". Let's fix > > it. > > > > Also the Internet says that this panel supports 262K colors. That's > > 6bpp, not 8bpp. > > > > Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61") > > Signed-off-by: Douglas Anderson > > Added to drm-misc-next as I did not think this had to be updated in > mainline right now. Let me know if you expect it to land in mainline > soonish. drm-misc-next is perfect, thanks! -Doug _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel