From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D9EC433E1 for ; Tue, 23 Mar 2021 21:09:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EBFC619A5 for ; Tue, 23 Mar 2021 21:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233422AbhCWVJC (ORCPT ); Tue, 23 Mar 2021 17:09:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233383AbhCWVIz (ORCPT ); Tue, 23 Mar 2021 17:08:55 -0400 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BB82C061574 for ; Tue, 23 Mar 2021 14:08:55 -0700 (PDT) Received: by mail-qv1-xf2b.google.com with SMTP id by2so11221323qvb.11 for ; Tue, 23 Mar 2021 14:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GQwheX+ZOdsLRvA7XPASIVaHFFt/8Y47I6o+aENus34=; b=FxoCgZ66CW4DEmPHCY36UziylrUzDCKhrdi+/rBZqANTFV3kACH/P/9Cm35U6ZrXt7 lebhYaqTec4eHBmwZucO69qCPAaky9irljkPvIZtE4z+NPF/8o/Ua2IsC7yP+cgyJysE ibZdoKOJCd3A1z5FR5scNPjOAOZ/gBAEqp50k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GQwheX+ZOdsLRvA7XPASIVaHFFt/8Y47I6o+aENus34=; b=fsPxL2q4zsLV9+cXCc+2Jand+6pdNEc0Z7M1ff1KM/5Pvx8PamK83YBq4tBMORt+k1 rNgaWnXuH0RhgqTQcEQqnoq7UAWzAso4UnwGhnE2bgDwJMX8QI6rOU0phVOKjqcyouGf QtJKRu/Fw1we22EmdaejXcDAwMWEY3lbbIgzBgssOX6Vjpc89S8Mij3XWRXwIIlY1Gqi e7yBsJk2b5WC7f54KG3xGYX7wPp30xrUmnXSmHRDL4VxfTUW+0YdgZvff72ptsXaqttF B5xOuI1+ZUbyjTRqFKeIKFHPBhH5QTXjTIrmHY9m4Q2vuItoNBCEBGXo6QERZYkPIWWw +VrQ== X-Gm-Message-State: AOAM531e9ECErC+xekwmYkHIp7esugNJQCsq5WBdChaViJSssstNeryL EEfYZiwL/F/xCCf7lkozBNO2ANa3TRCftA== X-Google-Smtp-Source: ABdhPJzo7qkE+5sp6/01SCHYBTJ1+oqlyUHXCM0pcInVF0UVaxxV+hqlsyDKWnPewlsBEF+nAWczQw== X-Received: by 2002:a0c:c488:: with SMTP id u8mr6586681qvi.47.1616533734377; Tue, 23 Mar 2021 14:08:54 -0700 (PDT) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id a138sm96121qkg.29.2021.03.23.14.08.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 14:08:53 -0700 (PDT) Received: by mail-yb1-f177.google.com with SMTP id m132so11827826ybf.2 for ; Tue, 23 Mar 2021 14:08:53 -0700 (PDT) X-Received: by 2002:a25:ab54:: with SMTP id u78mr270728ybi.276.1616533733297; Tue, 23 Mar 2021 14:08:53 -0700 (PDT) MIME-Version: 1.0 References: <20210322030128.2283-1-laurent.pinchart+renesas@ideasonboard.com> <20210322030128.2283-4-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <20210322030128.2283-4-laurent.pinchart+renesas@ideasonboard.com> From: Doug Anderson Date: Tue, 23 Mar 2021 14:08:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 03/11] drm/bridge: ti-sn65dsi86: Unregister AUX adapter in remove() To: Laurent Pinchart Cc: dri-devel , linux-renesas-soc@vger.kernel.org, Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Stephen Boyd Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > The AUX adapter registered in probe() need to be unregistered in > remove(). Do so. > > Fixes: b814ec6d4535 ("drm/bridge: ti-sn65dsi86: Implement AUX channel") > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index da78a12e58b5..c45420a50e73 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -1307,6 +1307,9 @@ static int ti_sn_bridge_remove(struct i2c_client *client) > return -EINVAL; > > kfree(pdata->edid); > + > + drm_dp_aux_unregister(&pdata->aux); > + > ti_sn_debugfs_remove(pdata); > > of_node_put(pdata->host_node); Good catch. One question, though. I know DRM sometimes has different conventions than the rest of the kernel, but I always look for the "remove" to be backwards of probe. That means that your code (and probably most of the remove function) should come _after_ the drm_bridge_remove(), right? ...since drm_bridge_add() was the last thing in probe then drm_bridge_remove() should be the first thing in remove? -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A59B8C433C1 for ; Tue, 23 Mar 2021 21:08:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41549600EF for ; Tue, 23 Mar 2021 21:08:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41549600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A76D06E140; Tue, 23 Mar 2021 21:08:55 +0000 (UTC) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1F6606E140 for ; Tue, 23 Mar 2021 21:08:55 +0000 (UTC) Received: by mail-qt1-x82a.google.com with SMTP id 94so16102901qtc.0 for ; Tue, 23 Mar 2021 14:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GQwheX+ZOdsLRvA7XPASIVaHFFt/8Y47I6o+aENus34=; b=FxoCgZ66CW4DEmPHCY36UziylrUzDCKhrdi+/rBZqANTFV3kACH/P/9Cm35U6ZrXt7 lebhYaqTec4eHBmwZucO69qCPAaky9irljkPvIZtE4z+NPF/8o/Ua2IsC7yP+cgyJysE ibZdoKOJCd3A1z5FR5scNPjOAOZ/gBAEqp50k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GQwheX+ZOdsLRvA7XPASIVaHFFt/8Y47I6o+aENus34=; b=ijBjuQoTRVynXAcFZWDj6UKRhIQOu0oMWk2qGg7XWq9iT/4fWFcHV1k7X5ar/VcOtN ock3DQX9dgjLC3D8uZQzZQZgxi43zKvCNC1JaXT8LX3i/y90LyQC/+MOtWJVGDvhmt5a pRLDziR0p322nUp8djObOV8zhvIDigzK+EfVm++XARyE5z8Ta1PI7tOprXs1LveH2HiD 0SI498F9yn0CiMnwAIGF68jztpv80VNYop45zGkNDuk5d01dMG55kVOoxY59GVKKykSM HOhBFuJH8+SSvLUAAEpbq/RE1lUxfEsdypmA82sXqSSdwFI87PfogRouWhHzYwCPUueb rHNA== X-Gm-Message-State: AOAM532x7LrEvZIXMDbEtOfexNVGm+HcOT9zIn3+NbT0mmzpKWAZA+cR dh93C+f6SvaL/yO7w0sUrpNPt/cpwHhs1g== X-Google-Smtp-Source: ABdhPJweGrGMtuaq40RYF5UK/qNu2YmvuWNu/P4zv7Vf6tMcbQ0xQtlvllLLt/GTxSYWKajuym4eGg== X-Received: by 2002:ac8:464c:: with SMTP id f12mr258536qto.232.1616533734128; Tue, 23 Mar 2021 14:08:54 -0700 (PDT) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id 17sm96968qky.7.2021.03.23.14.08.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 14:08:53 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id i9so11829303ybp.4 for ; Tue, 23 Mar 2021 14:08:53 -0700 (PDT) X-Received: by 2002:a25:ab54:: with SMTP id u78mr270728ybi.276.1616533733297; Tue, 23 Mar 2021 14:08:53 -0700 (PDT) MIME-Version: 1.0 References: <20210322030128.2283-1-laurent.pinchart+renesas@ideasonboard.com> <20210322030128.2283-4-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <20210322030128.2283-4-laurent.pinchart+renesas@ideasonboard.com> From: Doug Anderson Date: Tue, 23 Mar 2021 14:08:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 03/11] drm/bridge: ti-sn65dsi86: Unregister AUX adapter in remove() To: Laurent Pinchart X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jonas Karlman , Neil Armstrong , dri-devel , Stephen Boyd , linux-renesas-soc@vger.kernel.org, Andrzej Hajda Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > The AUX adapter registered in probe() need to be unregistered in > remove(). Do so. > > Fixes: b814ec6d4535 ("drm/bridge: ti-sn65dsi86: Implement AUX channel") > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index da78a12e58b5..c45420a50e73 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -1307,6 +1307,9 @@ static int ti_sn_bridge_remove(struct i2c_client *client) > return -EINVAL; > > kfree(pdata->edid); > + > + drm_dp_aux_unregister(&pdata->aux); > + > ti_sn_debugfs_remove(pdata); > > of_node_put(pdata->host_node); Good catch. One question, though. I know DRM sometimes has different conventions than the rest of the kernel, but I always look for the "remove" to be backwards of probe. That means that your code (and probably most of the remove function) should come _after_ the drm_bridge_remove(), right? ...since drm_bridge_add() was the last thing in probe then drm_bridge_remove() should be the first thing in remove? -Doug _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel