From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932858AbbFISTC (ORCPT ); Tue, 9 Jun 2015 14:19:02 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:35612 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbbFISSx (ORCPT ); Tue, 9 Jun 2015 14:18:53 -0400 MIME-Version: 1.0 In-Reply-To: <1433843400-24831-3-git-send-email-wxt@rock-chips.com> References: <1433843400-24831-1-git-send-email-wxt@rock-chips.com> <1433843400-24831-3-git-send-email-wxt@rock-chips.com> Date: Tue, 9 Jun 2015 11:13:19 -0700 X-Google-Sender-Auth: gE9tIuwflu3HSJj7cmVzz7OnnlU Message-ID: Subject: Re: [PATCH v6 2/3] ARM: rockchip: ensure CPU to enter WFI/WFE state From: Doug Anderson To: Caesar Wang Cc: Heiko Stuebner , Dmitry Torokhov , "open list:ARM/Rockchip SoC..." , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Caesar, On Tue, Jun 9, 2015 at 2:49 AM, Caesar Wang wrote: > The patch can ensure that v7_exit_coherency_flush() in rockchip_cpu_die() > executed in time. > The mdelay(1) has enough time to fix the problem of CPU offlining. > That's a workaround way in rockchip hotplug code, > At least, we haven't a better way to solve it. Who know, > that maybe fixed by chip (hardware) in the future. > > Signed-off-by: Caesar Wang > > --- > > Changes in v6: > - Fix the delay 1ms describing. > Series-changes: 5 > - Fix the patch decription. > - Add the changelog. > Series-changes: 2 > - As Kever points out, Fix the subject typo WFI/WFE. > > arch/arm/mach-rockchip/platsmp.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Douglas Anderson From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH v6 2/3] ARM: rockchip: ensure CPU to enter WFI/WFE state Date: Tue, 9 Jun 2015 11:13:19 -0700 Message-ID: References: <1433843400-24831-1-git-send-email-wxt@rock-chips.com> <1433843400-24831-3-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1433843400-24831-3-git-send-email-wxt@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org To: Caesar Wang Cc: Heiko Stuebner , Dmitry Torokhov , "open list:ARM/Rockchip SoC..." , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" List-Id: linux-rockchip.vger.kernel.org Caesar, On Tue, Jun 9, 2015 at 2:49 AM, Caesar Wang wrote: > The patch can ensure that v7_exit_coherency_flush() in rockchip_cpu_die() > executed in time. > The mdelay(1) has enough time to fix the problem of CPU offlining. > That's a workaround way in rockchip hotplug code, > At least, we haven't a better way to solve it. Who know, > that maybe fixed by chip (hardware) in the future. > > Signed-off-by: Caesar Wang > > --- > > Changes in v6: > - Fix the delay 1ms describing. > Series-changes: 5 > - Fix the patch decription. > - Add the changelog. > Series-changes: 2 > - As Kever points out, Fix the subject typo WFI/WFE. > > arch/arm/mach-rockchip/platsmp.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Douglas Anderson From mboxrd@z Thu Jan 1 00:00:00 1970 From: dianders@chromium.org (Doug Anderson) Date: Tue, 9 Jun 2015 11:13:19 -0700 Subject: [PATCH v6 2/3] ARM: rockchip: ensure CPU to enter WFI/WFE state In-Reply-To: <1433843400-24831-3-git-send-email-wxt@rock-chips.com> References: <1433843400-24831-1-git-send-email-wxt@rock-chips.com> <1433843400-24831-3-git-send-email-wxt@rock-chips.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Caesar, On Tue, Jun 9, 2015 at 2:49 AM, Caesar Wang wrote: > The patch can ensure that v7_exit_coherency_flush() in rockchip_cpu_die() > executed in time. > The mdelay(1) has enough time to fix the problem of CPU offlining. > That's a workaround way in rockchip hotplug code, > At least, we haven't a better way to solve it. Who know, > that maybe fixed by chip (hardware) in the future. > > Signed-off-by: Caesar Wang > > --- > > Changes in v6: > - Fix the delay 1ms describing. > Series-changes: 5 > - Fix the patch decription. > - Add the changelog. > Series-changes: 2 > - As Kever points out, Fix the subject typo WFI/WFE. > > arch/arm/mach-rockchip/platsmp.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Douglas Anderson