From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Date: Thu, 21 Mar 2013 10:51:23 -0700 Subject: [U-Boot] [PATCH 8/8] patman: Add Series-process-log tag to sort/uniq change logs In-Reply-To: <1363833781-14557-9-git-send-email-sjg@chromium.org> References: <1363833781-14557-1-git-send-email-sjg@chromium.org> <1363833781-14557-9-git-send-email-sjg@chromium.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Simon, On Wed, Mar 20, 2013 at 7:43 PM, Simon Glass wrote: > For some series with lots of changes it is annoying that duplicate change > log items are not caught. It is also helpful sometimes to sort the change > logs. > > Add a Series-process-log tag to enable this, which can be placed in a > commit to control this. > > The change to the Cc: line is to fix a checkpatch warning. > > Signed-off-by: Simon Glass > --- > tools/patman/README | 8 +++++++- > tools/patman/patchstream.py | 2 +- > tools/patman/series.py | 8 ++++++-- > 3 files changed, 14 insertions(+), 4 deletions(-) Not sure I'd find this terribly useful myself, but I don't see anything wrong with it. I think my change log items tend to be more than one line long for one... > + if not ('uniq' in process_it and text in out): optional: My brain had a hard time processing this. I did the logic transformation myself: if 'uniq' not in process_it or text not in out: Also: Do you really want the "process_it" to be so free-form? That seems like it might be asking for disaster. Why not specify that it's comma-separated and be done. -Doug