From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58A4FC433EF for ; Tue, 21 Sep 2021 22:20:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40B1761090 for ; Tue, 21 Sep 2021 22:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234596AbhIUWVd (ORCPT ); Tue, 21 Sep 2021 18:21:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232693AbhIUWVa (ORCPT ); Tue, 21 Sep 2021 18:21:30 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10EF8C061574 for ; Tue, 21 Sep 2021 15:20:02 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id 134so656399iou.12 for ; Tue, 21 Sep 2021 15:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HWLoAInOLCehVyUDdEFgyA0aq8c1810nqg999R8oxfU=; b=aj3QxekWfRi3uAdc5lpdDn6FoYAedJ8FsTjBDvBCDWRjEzt/JQ6p7imxAG/DApK+mF 2gagVt3X8luIoitRLXSKRYVwLgSznNVpaZyG8m/4FCGZweCBBZsIAUvT7PdIPZbU8wN1 mfAQEwrxhepXNPQuDT3ppCtjQk9jPR2TpYAss= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HWLoAInOLCehVyUDdEFgyA0aq8c1810nqg999R8oxfU=; b=p5Bec16lI2Fg0XthCe0v/uQfH3H/1aVOu01Uq4u3voW2LdJlUNKO4R6QXhPKmM/Dig s9G7GS+dczMwhy/VpUzT6ciUqr3n2+k599MYjtTfDL77i/MXjmK9wXvPLjWuufWStBhd vZ/jg6Pwe45+uxld8axRsOsgywcAW38x8wyc4yZ7vj6CBC40DTqFt15E482kaGa0wzTV pXJnaM4VTSZ/klO1NTpeVamCmoEeqUmWMgSZHGzCjnznR55wg547At54AjBW6N3BGqA7 MLCAke1tDCgQJ0YTzOebgSkkGk+iE5xAHOeFzC9RrYBZtT4Gz3RlJpdlpLZh8eGXYnES twrw== X-Gm-Message-State: AOAM533PRMsAmypi5lviDWLLZD+mlKOn4OJUequKTObBGaK12kJDmydH GX06xpxpuP+1zxPiYREsDMgpmJgTBRSE7g== X-Google-Smtp-Source: ABdhPJxp37XG6wQThaz/AIe3qdzZ7aHlMAj7bVdchW+0Ylfj1wca3DpK7GVrGLsUc2NYbeAlF8Qlag== X-Received: by 2002:a05:6602:3c5:: with SMTP id g5mr1945321iov.42.1632262801163; Tue, 21 Sep 2021 15:20:01 -0700 (PDT) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com. [209.85.166.169]) by smtp.gmail.com with ESMTPSA id d10sm107465ilu.54.2021.09.21.15.20.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 15:20:00 -0700 (PDT) Received: by mail-il1-f169.google.com with SMTP id w1so546603ilv.1 for ; Tue, 21 Sep 2021 15:20:00 -0700 (PDT) X-Received: by 2002:a05:6e02:1b0c:: with SMTP id i12mr20195314ilv.27.1632262799686; Tue, 21 Sep 2021 15:19:59 -0700 (PDT) MIME-Version: 1.0 References: <20210920225801.227211-1-robdclark@gmail.com> <20210920225801.227211-4-robdclark@gmail.com> In-Reply-To: <20210920225801.227211-4-robdclark@gmail.com> From: Doug Anderson Date: Tue, 21 Sep 2021 15:19:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support To: Rob Clark Cc: dri-devel , freedreno , Laurent Pinchart , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Sep 20, 2021 at 3:53 PM Rob Clark wrote: > > From: Rob Clark > > Slightly awkward to fish out the display_info when we aren't creating > own connector. But I don't see an obvious better way. > > v2: Remove error return with NO_CONNECTOR flag > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 39 ++++++++++++++++++++------- > 1 file changed, 29 insertions(+), 10 deletions(-) This seems fine to me: Reviewed-by: Douglas Anderson ...if you would like me to apply patch #2 / #3 to drm-misc-next then please yell. -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995BFC433F5 for ; Tue, 21 Sep 2021 22:20:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60D9B61090 for ; Tue, 21 Sep 2021 22:20:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 60D9B61090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C34536E85A; Tue, 21 Sep 2021 22:20:03 +0000 (UTC) Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by gabe.freedesktop.org (Postfix) with ESMTPS id B69306E85A for ; Tue, 21 Sep 2021 22:20:02 +0000 (UTC) Received: by mail-io1-xd29.google.com with SMTP id a15so773410iot.2 for ; Tue, 21 Sep 2021 15:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HWLoAInOLCehVyUDdEFgyA0aq8c1810nqg999R8oxfU=; b=aj3QxekWfRi3uAdc5lpdDn6FoYAedJ8FsTjBDvBCDWRjEzt/JQ6p7imxAG/DApK+mF 2gagVt3X8luIoitRLXSKRYVwLgSznNVpaZyG8m/4FCGZweCBBZsIAUvT7PdIPZbU8wN1 mfAQEwrxhepXNPQuDT3ppCtjQk9jPR2TpYAss= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HWLoAInOLCehVyUDdEFgyA0aq8c1810nqg999R8oxfU=; b=U5pt+lglWQS4dDi1XwoZ0Sb+RBZDgs8gGcL5hNoxds/rzgWqC7gLoSMbvfqtFnosvD x5/VFNoOn11iZxFLKRKmTSDn3P21idq1hoS4vfL/GNwM3YsowGL5RgRt3z0qviLX8vCY 6EraZxe/CanS1faBj1kxS9wLQWcrFZu1+bX1Il5w5HXyJxQoQXxUHhnwre0DfMVbcfrd Oj+C09rkNcAGlN8rBuM69Kysy+CZk0jiywkgVinbOqW8rpMBERuIrIfipBOhXmxNQnBH fV4NIF6OidxfHHOlsIOh6GTwGxFvqRoveDqOMtYWCANerRPVlGzSNhxG0qcYTPqJnceU 1Xpg== X-Gm-Message-State: AOAM530cDcpVya1w2yZxMW86FKzVgKoHj4Z46c8N95mQqAXLxrxnqmT1 Z5hUyyC9QWwXq5pJa84wExXiqmklMj9Anw== X-Google-Smtp-Source: ABdhPJyWMl30CpodcybLR8STdXZLcmcQ+3IPwmfIcuf1tWn7JIN/IBI02sxAfH19aGjqx1N0DhLpuw== X-Received: by 2002:a02:22cf:: with SMTP id o198mr2043371jao.37.1632262801872; Tue, 21 Sep 2021 15:20:01 -0700 (PDT) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com. [209.85.166.180]) by smtp.gmail.com with ESMTPSA id i14sm138440iog.47.2021.09.21.15.20.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 15:20:00 -0700 (PDT) Received: by mail-il1-f180.google.com with SMTP id x2so457595ila.11 for ; Tue, 21 Sep 2021 15:20:00 -0700 (PDT) X-Received: by 2002:a05:6e02:1b0c:: with SMTP id i12mr20195314ilv.27.1632262799686; Tue, 21 Sep 2021 15:19:59 -0700 (PDT) MIME-Version: 1.0 References: <20210920225801.227211-1-robdclark@gmail.com> <20210920225801.227211-4-robdclark@gmail.com> In-Reply-To: <20210920225801.227211-4-robdclark@gmail.com> From: Doug Anderson Date: Tue, 21 Sep 2021 15:19:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support To: Rob Clark Cc: dri-devel , freedreno , Laurent Pinchart , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Mon, Sep 20, 2021 at 3:53 PM Rob Clark wrote: > > From: Rob Clark > > Slightly awkward to fish out the display_info when we aren't creating > own connector. But I don't see an obvious better way. > > v2: Remove error return with NO_CONNECTOR flag > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 39 ++++++++++++++++++++------- > 1 file changed, 29 insertions(+), 10 deletions(-) This seems fine to me: Reviewed-by: Douglas Anderson ...if you would like me to apply patch #2 / #3 to drm-misc-next then please yell. -Doug