From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED35C43381 for ; Thu, 28 Mar 2019 23:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 323F020823 for ; Thu, 28 Mar 2019 23:57:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ga86VdDd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728627AbfC1X50 (ORCPT ); Thu, 28 Mar 2019 19:57:26 -0400 Received: from mail-vs1-f65.google.com ([209.85.217.65]:36172 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728500AbfC1X50 (ORCPT ); Thu, 28 Mar 2019 19:57:26 -0400 Received: by mail-vs1-f65.google.com with SMTP id n4so285250vsm.3 for ; Thu, 28 Mar 2019 16:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=J6I/v/YVpxo56EJoyi5w98mpxEiiogVWXHjkzoeLl1I=; b=Ga86VdDd6kWzK/FBE88ab6bo/fdaiYvHnzzqI+HiDCwHXSGdezxpJA41swbu2aV1bW 1/eOnp90VIezOOORIq/ox96YKRX6oANi0368wQOuV+RLtwAD884Q7YGxzNpVfyyEZ+61 nt9pER/XqQzqA6el/XQXTR7K1zyuJ+so/ySjE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=J6I/v/YVpxo56EJoyi5w98mpxEiiogVWXHjkzoeLl1I=; b=EMozaaZF6oevcWzOzRSg56RJc2bJCAXs/ptosIsYyqqaV84IqFBFxa9XProf2tK1iA 8c1THWtodQIPF3Z17qLyL4tf1eSJJvcKPqANg4e8Qio1Bn9Q148MS7El+tg/pZFCMDXJ K2sJJ/N5ycHjTB1bWlNlxWCGjNUG9CAxeqUlzqJnPfdwMkKNWrwZpnVvH9/IdFamc++l aklJQ4itbvLDcJc0r+CrBaPan7XA4/DdVJQXml9FLCdVLx7bxBnvAclVJ9Cbr7w9IMRr iJpHZQW8u+GTLc16NdZAAfur/lxChpbfqd0V8GCVXILzzI4qzkPe6j9KHgEPwCllnoBT CQwA== X-Gm-Message-State: APjAAAVqZF/zr1PoxRT4/OMb4BK5QKGSbCXY5M8ygK8hJQccb+iIOToi bx7liPxajsdSyxOdQEik29Tv9qd2ZUc= X-Google-Smtp-Source: APXvYqwJmYaJS9EZXWP06TItlKxRB2VlL6oJs/zeUsBynAODYcf4nPLrrnRKY1MBQeFl0su5FD71Lw== X-Received: by 2002:a67:f10e:: with SMTP id n14mr27179672vsk.110.1553817444749; Thu, 28 Mar 2019 16:57:24 -0700 (PDT) Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com. [209.85.222.54]) by smtp.gmail.com with ESMTPSA id j186sm77506vsd.21.2019.03.28.16.57.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 16:57:24 -0700 (PDT) Received: by mail-ua1-f54.google.com with SMTP id d4so97439uap.5 for ; Thu, 28 Mar 2019 16:57:24 -0700 (PDT) X-Received: by 2002:ab0:2692:: with SMTP id t18mr3058917uao.106.1553817025313; Thu, 28 Mar 2019 16:50:25 -0700 (PDT) MIME-Version: 1.0 References: <20190328171710.31949-1-dianders@chromium.org> <20190328171710.31949-2-dianders@chromium.org> In-Reply-To: From: Doug Anderson Date: Thu, 28 Mar 2019 16:50:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/7] dt-bindings: Add panel-timing subnode to simple-panel To: Ezequiel Garcia Cc: Thierry Reding , Heiko Stuebner , Sean Paul , "open list:ARM/Rockchip SoC..." , Laurent Pinchart , dri-devel , Boris Brezillon , =?UTF-8?Q?Enric_Balletb=C3=B2?= , Rob Herring , Matthias Kaehlcke , Eric Anholt , Jeffy Chen , =?UTF-8?Q?St=C3=A9phane_Marchesin?= , devicetree@vger.kernel.org, LKML , David Airlie , Mark Rutland , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Mar 28, 2019 at 1:27 PM Ezequiel Garcia wr= ote: > > On Thu, 2019-03-28 at 10:17 -0700, Douglas Anderson wrote: > > From: Sean Paul > > > > This patch adds a new subnode to simple-panel allowing us to override > > the typical timing expressed in the panel's display_timing. > > > > Changes in v2: > > - Split out the binding into a new patch (Rob) > > - display-timings is a new section (Rob) > > - Use the full display-timings subnode instead of picking the timing > > out (Rob/Thierry) > > Changes in v3: > > - Go back to using the timing subnode directly, but rename to > > panel-timing (Rob) > > Changes in v4: > > - Simplify desc. for when override should be used (Thierry/Laurent) > > - Removed Rob H review since it's been a year and wording changed > > > > Cc: Doug Anderson > > Cc: Eric Anholt > > Cc: Heiko Stuebner > > Cc: Jeffy Chen > > Cc: Rob Herring > > Cc: St=C3=A9phane Marchesin > > Cc: Thierry Reding > > Cc: devicetree@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-rockchip@lists.infradead.org > > Signed-off-by: Sean Paul > > Signed-off-by: Douglas Anderson > > --- > > > > .../bindings/display/panel/simple-panel.txt | 24 +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/panel/simple-pan= el.txt b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > > index b2b872c710f2..6157f86ddce4 100644 > > --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt > > +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > > @@ -15,6 +15,18 @@ Optional properties: > > (hot plug detect) signal, but the signal isn't hooked up so we shoul= d > > hardcode the max delay from the panel spec when powering up the pane= l. > > > > +panel-timing subnode > > +-------------------- > > + > > +This optional subnode is for devices which require a mode differing > > +from the panel's "typical" display timing. The panel timings provided > > +here will be ignored if they are found to be outside of allowable > > +ranges for the given panel. > > + > > Is it OK to put this comment about how the implementation > will behave when values are out of range, given this is just a binding > spec? > > Perhaps -if needed- this sentence can be rephrased to state that, > e.g. the OS may not be able to apply these values, if the controller > or device is unable to? I will defer to Rob H. on this one, but I'm happy to simply remove the last sentence. I was trying to add a more OS-agnostic version of the bullet points from V3 but agree that we could just remove this from the bindings completely. -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH v4 1/7] dt-bindings: Add panel-timing subnode to simple-panel Date: Thu, 28 Mar 2019 16:50:13 -0700 Message-ID: References: <20190328171710.31949-1-dianders@chromium.org> <20190328171710.31949-2-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ezequiel Garcia Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , Jeffy Chen , LKML , dri-devel , "open list:ARM/Rockchip SoC..." , Thierry Reding , Sean Paul , Laurent Pinchart , Boris Brezillon , =?UTF-8?Q?Enric_Balletb=C3=B2?= , Rob Herring , Matthias Kaehlcke , =?UTF-8?Q?St=C3=A9phane_Marchesin?= List-Id: devicetree@vger.kernel.org SGksCgoKT24gVGh1LCBNYXIgMjgsIDIwMTkgYXQgMToyNyBQTSBFemVxdWllbCBHYXJjaWEgPGV6 ZXF1aWVsQGNvbGxhYm9yYS5jb20+IHdyb3RlOgo+Cj4gT24gVGh1LCAyMDE5LTAzLTI4IGF0IDEw OjE3IC0wNzAwLCBEb3VnbGFzIEFuZGVyc29uIHdyb3RlOgo+ID4gRnJvbTogU2VhbiBQYXVsIDxz ZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gPgo+ID4gVGhpcyBwYXRjaCBhZGRzIGEgbmV3IHN1Ym5v ZGUgdG8gc2ltcGxlLXBhbmVsIGFsbG93aW5nIHVzIHRvIG92ZXJyaWRlCj4gPiB0aGUgdHlwaWNh bCB0aW1pbmcgZXhwcmVzc2VkIGluIHRoZSBwYW5lbCdzIGRpc3BsYXlfdGltaW5nLgo+ID4KPiA+ IENoYW5nZXMgaW4gdjI6Cj4gPiAgLSBTcGxpdCBvdXQgdGhlIGJpbmRpbmcgaW50byBhIG5ldyBw YXRjaCAoUm9iKQo+ID4gIC0gZGlzcGxheS10aW1pbmdzIGlzIGEgbmV3IHNlY3Rpb24gKFJvYikK PiA+ICAtIFVzZSB0aGUgZnVsbCBkaXNwbGF5LXRpbWluZ3Mgc3Vibm9kZSBpbnN0ZWFkIG9mIHBp Y2tpbmcgdGhlIHRpbWluZwo+ID4gICAgb3V0IChSb2IvVGhpZXJyeSkKPiA+IENoYW5nZXMgaW4g djM6Cj4gPiAgLSBHbyBiYWNrIHRvIHVzaW5nIHRoZSB0aW1pbmcgc3Vibm9kZSBkaXJlY3RseSwg YnV0IHJlbmFtZSB0bwo+ID4gICAgcGFuZWwtdGltaW5nIChSb2IpCj4gPiBDaGFuZ2VzIGluIHY0 Ogo+ID4gIC0gU2ltcGxpZnkgZGVzYy4gZm9yIHdoZW4gb3ZlcnJpZGUgc2hvdWxkIGJlIHVzZWQg KFRoaWVycnkvTGF1cmVudCkKPiA+ICAtIFJlbW92ZWQgUm9iIEggcmV2aWV3IHNpbmNlIGl0J3Mg YmVlbiBhIHllYXIgYW5kIHdvcmRpbmcgY2hhbmdlZAo+ID4KPiA+IENjOiBEb3VnIEFuZGVyc29u IDxkaWFuZGVyc0BjaHJvbWl1bS5vcmc+Cj4gPiBDYzogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0 Lm5ldD4KPiA+IENjOiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250ZWNoLmRlPgo+ID4gQ2M6IEpl ZmZ5IENoZW4gPGplZmZ5LmNoZW5Acm9jay1jaGlwcy5jb20+Cj4gPiBDYzogUm9iIEhlcnJpbmcg PHJvYmgrZHRAa2VybmVsLm9yZz4KPiA+IENjOiBTdMOpcGhhbmUgTWFyY2hlc2luIDxtYXJjaGV1 QGNocm9taXVtLm9yZz4KPiA+IENjOiBUaGllcnJ5IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21h aWwuY29tPgo+ID4gQ2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnCj4gPiBDYzogZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gQ2M6IGxpbnV4LXJvY2tjaGlwQGxpc3RzLmlu ZnJhZGVhZC5vcmcKPiA+IFNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21p dW0ub3JnPgo+ID4gU2lnbmVkLW9mZi1ieTogRG91Z2xhcyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hy b21pdW0ub3JnPgo+ID4gLS0tCj4gPgo+ID4gIC4uLi9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL3Np bXBsZS1wYW5lbC50eHQgICB8IDI0ICsrKysrKysrKysrKysrKysrKysKPiA+ICAxIGZpbGUgY2hh bmdlZCwgMjQgaW5zZXJ0aW9ucygrKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9zaW1wbGUtcGFuZWwudHh0IGIvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvc2ltcGxlLXBhbmVs LnR4dAo+ID4gaW5kZXggYjJiODcyYzcxMGYyLi42MTU3Zjg2ZGRjZTQgMTAwNjQ0Cj4gPiAtLS0g YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9zaW1wbGUt cGFuZWwudHh0Cj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlz cGxheS9wYW5lbC9zaW1wbGUtcGFuZWwudHh0Cj4gPiBAQCAtMTUsNiArMTUsMTggQEAgT3B0aW9u YWwgcHJvcGVydGllczoKPiA+ICAgIChob3QgcGx1ZyBkZXRlY3QpIHNpZ25hbCwgYnV0IHRoZSBz aWduYWwgaXNuJ3QgaG9va2VkIHVwIHNvIHdlIHNob3VsZAo+ID4gICAgaGFyZGNvZGUgdGhlIG1h eCBkZWxheSBmcm9tIHRoZSBwYW5lbCBzcGVjIHdoZW4gcG93ZXJpbmcgdXAgdGhlIHBhbmVsLgo+ ID4KPiA+ICtwYW5lbC10aW1pbmcgc3Vibm9kZQo+ID4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g PiArCj4gPiArVGhpcyBvcHRpb25hbCBzdWJub2RlIGlzIGZvciBkZXZpY2VzIHdoaWNoIHJlcXVp cmUgYSBtb2RlIGRpZmZlcmluZwo+ID4gK2Zyb20gdGhlIHBhbmVsJ3MgInR5cGljYWwiIGRpc3Bs YXkgdGltaW5nLiAgVGhlIHBhbmVsIHRpbWluZ3MgcHJvdmlkZWQKPiA+ICtoZXJlIHdpbGwgYmUg aWdub3JlZCBpZiB0aGV5IGFyZSBmb3VuZCB0byBiZSBvdXRzaWRlIG9mIGFsbG93YWJsZQo+ID4g K3JhbmdlcyBmb3IgdGhlIGdpdmVuIHBhbmVsLgo+ID4gKwo+Cj4gSXMgaXQgT0sgdG8gcHV0IHRo aXMgY29tbWVudCBhYm91dCBob3cgdGhlIGltcGxlbWVudGF0aW9uCj4gd2lsbCBiZWhhdmUgd2hl biB2YWx1ZXMgYXJlIG91dCBvZiByYW5nZSwgZ2l2ZW4gdGhpcyBpcyBqdXN0IGEgYmluZGluZwo+ IHNwZWM/Cj4KPiBQZXJoYXBzIC1pZiBuZWVkZWQtIHRoaXMgc2VudGVuY2UgY2FuIGJlIHJlcGhy YXNlZCB0byBzdGF0ZSB0aGF0LAo+IGUuZy4gdGhlIE9TIG1heSBub3QgYmUgYWJsZSB0byBhcHBs eSB0aGVzZSB2YWx1ZXMsIGlmIHRoZSBjb250cm9sbGVyCj4gb3IgZGV2aWNlIGlzIHVuYWJsZSB0 bz8KCkkgd2lsbCBkZWZlciB0byBSb2IgSC4gb24gdGhpcyBvbmUsIGJ1dCBJJ20gaGFwcHkgdG8g c2ltcGx5IHJlbW92ZSB0aGUKbGFzdCBzZW50ZW5jZS4gIEkgd2FzIHRyeWluZyB0byBhZGQgYSBt b3JlIE9TLWFnbm9zdGljIHZlcnNpb24gb2YgdGhlCmJ1bGxldCBwb2ludHMgZnJvbSBWMyBidXQg YWdyZWUgdGhhdCB3ZSBjb3VsZCBqdXN0IHJlbW92ZSB0aGlzIGZyb20KdGhlIGJpbmRpbmdzIGNv bXBsZXRlbHkuCgoKLURvdWcKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVs