From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes Date: Tue, 22 Jan 2019 15:46:13 -0800 Message-ID: References: <20190122055112.30943-1-bjorn.andersson@linaro.org> <20190122055112.30943-4-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190122055112.30943-4-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson Cc: Andy Gross , David Brown , Sibi Sankar , Rob Herring , Mark Rutland , linux-arm-msm , devicetree@vger.kernel.org, LKML List-Id: linux-arm-msm@vger.kernel.org Hi, On Mon, Jan 21, 2019 at 9:52 PM Bjorn Andersson wrote: > > Add the ADSP and CDSP nodes for PAS-based remoteproc, supporting booting > these cores on e.g. the MTP, and enable the same for the MTP. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v2: > - New patch > > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 8 ++++ > arch/arm64/boot/dts/qcom/sdm845.dtsi | 58 +++++++++++++++++++++++++ > 2 files changed, 66 insertions(+) It's a bit of a nit of mine that if it's not totally obvious what acronyms mean that they should be spelled out in places that use them. In this case I believe ADSP is the Audio DSP. Is CDSP the Camera DSP? ...or ? > + adsp_pas: remoteproc-adsp { > + compatible = "qcom,sdm845-adsp-pas"; > + > + interrupts-extended = <&intc GIC_SPI 162 IRQ_TYPE_EDGE_RISING>, > + <&adsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > + <&adsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, > + <&adsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, > + <&adsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "wdog", "fatal", "ready", > + "handover", "stop-ack"; > + > + clocks = <&xo_board>; > + clock-names = "xo"; I've found that nearly all the places that refer to xo_board are wrong and should actually point to '<&rpmhcc RPMH_CXO_CLK>'. Maybe yours should too? -Doug