From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA6C0C10F0E for ; Fri, 12 Apr 2019 17:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95B5E2086D for ; Fri, 12 Apr 2019 17:43:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="RA4BPOv4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbfDLRnk (ORCPT ); Fri, 12 Apr 2019 13:43:40 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:38759 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726685AbfDLRnk (ORCPT ); Fri, 12 Apr 2019 13:43:40 -0400 Received: by mail-vs1-f68.google.com with SMTP id s2so6024474vsi.5 for ; Fri, 12 Apr 2019 10:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qTF8aI711SL5LtKW706PoElvH0ZGgd9rd+YGSL6lSZc=; b=RA4BPOv4HWgLioUq7rhcga4bdtCB7F2RZ1tQUp1UfsIWlhx887PqePwoZ6WiLzN3zL 62ps0lZGD5jNq1pU6Wg5pz+9hOlgbkUbtwKuWN9MZ2Gk26jLWpUK+Y3xL+vJfJ7LNZLD hQT9c7vKn/MeiKO18XPkb7fKlxNjKeitAy0Tk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qTF8aI711SL5LtKW706PoElvH0ZGgd9rd+YGSL6lSZc=; b=A19QRbf1BdjWxa84jQsrYwOpQUtRP+TJ2ZtWCYrc4wCHhVxUUZnRWyg9b6h/rb8z9w 12MK2PdCmiiFY5recz2tvH4UbWnUtTxTAOmAqNWTmZRjkutLx83N8e8w1mYG+JJF4s1y Bpw+HLf1DrvhlQU19y0w7NJLuOj2P89ExNS1jMvTQW8qLf/Xy+oBceSwBdCwhcX40bIm +z0sc4eqb2meXM8oEuRsv7xZ+14w+P1wfmZV7wHENS18MauvJjkdJhDZ4YoYI5LMjBdK naVaEWDf0LSJDwHogbwneWTr6wNlfVLYj18HEhxFwSF6ZyTJOvH8TEGRWLnoi/sWSEdI WI2A== X-Gm-Message-State: APjAAAVk3Fvt0mhF7+rwrkuhWnBT+uzibtrvleHbY8NtiGUVE1qVGSE2 /T+zxm73djdd4khevWjAOE99qb4Tf8g= X-Google-Smtp-Source: APXvYqyd90PUlvmkxQCTEYRTZ6V9KiBqoqZLKhAYHDLlyryNLS2qggHs39ZcZPag6k/cFN35i1lzQg== X-Received: by 2002:a67:ea0a:: with SMTP id g10mr20412924vso.77.1555091019318; Fri, 12 Apr 2019 10:43:39 -0700 (PDT) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com. [209.85.217.41]) by smtp.gmail.com with ESMTPSA id l125sm13566980vsd.31.2019.04.12.10.43.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Apr 2019 10:43:37 -0700 (PDT) Received: by mail-vs1-f41.google.com with SMTP id j184so6004121vsd.11 for ; Fri, 12 Apr 2019 10:43:36 -0700 (PDT) X-Received: by 2002:a67:1603:: with SMTP id 3mr30526094vsw.13.1555091016446; Fri, 12 Apr 2019 10:43:36 -0700 (PDT) MIME-Version: 1.0 References: <20190402113753.10118-1-heiko@sntech.de> In-Reply-To: <20190402113753.10118-1-heiko@sntech.de> From: Doug Anderson Date: Fri, 12 Apr 2019 10:43:24 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] drm/rockchip: shutdown drm subsystem on shutdown To: Heiko Stuebner Cc: Sandy Huang , dri-devel , "open list:ARM/Rockchip SoC..." , Vicente Bergas , Jeffy Chen , Robin Murphy , Marc Zyngier , Brian Norris , Doug Anderson , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi, On Tue, Apr 2, 2019 at 4:38 AM Heiko Stuebner wrote: > > From: Vicente Bergas > > As explained by Robin Murphy: > > the IOMMU shutdown disables paging, so if the VOP is still > > scanning out then that will result in whatever IOVAs it was using now going > > straight out onto the bus as physical addresses. > > We had a more radical approach before in commit > 7f3ef5dedb14 ("drm/rockchip: Allow driver to be shutdown on reboot/kexec") > but that resulted in new warnings and oopses on shutdown on rk3399 > chromeos devices. > > So second try is resurrecting Vicentes shutdown change which should > achieve the same result but in a less drastic way. > > Fixes: 63238173b2fa ("Revert drm/rockchip: Allow driver to be shutdown on reboot/kexec") > Cc: Jeffy Chen > Cc: Robin Murphy > Cc: Marc Zyngier > Cc: Brian Norris > Cc: Doug Anderson > Cc: stable@vger.kernel.org > Suggested-by: JeffyChen > Suggested-by: Robin Murphy > Signed-off-by: Vicente Bergas > [adapted commit message to explain the history] > Signed-off-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 9 +++++++++ > 1 file changed, 9 insertions(+) I picked this back to the Chrome OS 4.19 kernel and tried it on rk3288-veyron-jerry. Rebooting caused no complaints (I confirmed this code was running by adding a printk). I plugged in to an HDMI monitor. Rebooting caused no complaints. I then let the display idle off (just in case that mattered). Again no complaints. Thus, in case it's helpful: Tested-by: Douglas Anderson