Re: [PATCH v11 04/10] drivers: qcom: rpmh: add RPMH helper functions

From: Doug Anderson <dianders@chromium.org>
To: Lina Iyer <ilina@codeaurora.org>
Cc: Raju P L S S S N <rplsssn@codeaurora.org>,
	Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	linux-arm-msm@vger.kernel.org,
	"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Evan Green <evgreen@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v11 04/10] drivers: qcom: rpmh: add RPMH helper functions
Date: Mon, 18 Jun 2018 11:33:31 -0700	[thread overview]
Message-ID: <CAD=FV=W_tKb2n2x9AY4T_17Q_KJcu9wsfFv4vio08W76t0d00A@mail.gmail.com> (raw)
In-Reply-To: <20180618163945.GE21724@codeaurora.org>

Lina,

On Mon, Jun 18, 2018 at 9:39 AM, Lina Iyer <ilina@codeaurora.org> wrote:
>> +/**
>>  * struct rsc_drv: the Direct Resource Voter (DRV) of the
>>  * Resource State Coordinator controller (RSC)
>>  *
>> @@ -52,6 +78,7 @@ struct tcs_group {
>>  * @tcs:        TCS groups
>>  * @tcs_in_use: s/w state of the TCS
>>  * @lock:       synchronize state of the controller
>> + * @ctrl:       controller to handle cases like batch requests
>
> This is not only for batch requests.
> This is handle to the DRV's client. @client might be a better name than
> @ctrlr.

The name "ctrlr" also matches the name of the structure.  Are you
suggesting also renaming "struct rpmh_ctrlr" to "struct rpmh_client",
or you think they should be different names?

I'm advocating that we should land this patch series to unblock
everything.  Hopefully you agree that's OK and if we want to change
the name of this we can do it in a future patch.  Let me know if you
disagree.  ...if others agree that the series should land and you
really want the name change, I'm happy to post up a version of the
series with the fix to help move things along...

-Doug