From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 616B1CCA47E for ; Thu, 16 Jun 2022 15:36:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377795AbiFPPgN (ORCPT ); Thu, 16 Jun 2022 11:36:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377944AbiFPPgL (ORCPT ); Thu, 16 Jun 2022 11:36:11 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADCEB31503 for ; Thu, 16 Jun 2022 08:36:10 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 25so2719712edw.8 for ; Thu, 16 Jun 2022 08:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5dVDuCM8VRK665zH/HV+gDuurZlzqRaw3AF4f+4QEQY=; b=YpSpNH3K+KjKkXCuVKrFBcVrP5SWlYv3RWSSUdRdHJUnj+BZbndMy/7IyaCo4ZQ5rb d5YerNu+HSuaHbXK9sCxIH2I4yswgUI5cbWPgvOV+jsqmpGVVOzFPK8wchjbBtnuyFNC yiHYfw8thWjslkqgb7sZ31mB5KIv7561wqhQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5dVDuCM8VRK665zH/HV+gDuurZlzqRaw3AF4f+4QEQY=; b=5wufDx/hIyHSHBULmnbvJ+hyIuq5pY8ioiIR9BoaUpAToY3of3C2D7GfPUhk9Tc4Yc 71L43xc0OtigI2R/Al4lZx5FIu7jcyBpjkvmfvk8tEBPda0MVmJ9dufu3uArieOfe4z3 /0qHuzZ+eCIbJAhWOgfD8w5qDW+7AZpfho4ifj/vXMjKmCpx6tf639lm05wRM5yBCA04 zh1NXLjSoxTUqGA0OZewtvA5dguEz1qKUsK43USD18KRTLgkpk6QbeapQR0CQqLcPgbR vsQKpQ6uuuCa2cDEDF56mgRIr/+NstdABeAiKDbn8/Rzml4ohfBR9pCUjD1VoIfkjIkN WfAw== X-Gm-Message-State: AJIora/NgKeY1KU3SPrrNWERsT5MRoKIcvxjiHSypZyG0xSiJxSnVyss CZoX+CF0bDTmLerdVD7VqlinvExcjLN6ew9y+Sg= X-Google-Smtp-Source: AGRyM1uM1LTVcFGYtGRm7kR2A6dIvAEz2EPGBJIzT1L9CmaLCs70j2IQ0RtSMJfQXgt7fdpgUWrkkA== X-Received: by 2002:a05:6402:6cc:b0:42d:bd2d:9f82 with SMTP id n12-20020a05640206cc00b0042dbd2d9f82mr7296234edy.59.1655393769143; Thu, 16 Jun 2022 08:36:09 -0700 (PDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id a16-20020aa7d750000000b0042bd6f745fasm1941782eds.92.2022.06.16.08.36.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 08:36:08 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id a15so2383123wrh.2 for ; Thu, 16 Jun 2022 08:36:06 -0700 (PDT) X-Received: by 2002:a5d:68d2:0:b0:210:31cc:64a6 with SMTP id p18-20020a5d68d2000000b0021031cc64a6mr5183133wrw.679.1655393766098; Thu, 16 Jun 2022 08:36:06 -0700 (PDT) MIME-Version: 1.0 References: <20220425210643.2420919-1-dianders@chromium.org> <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> In-Reply-To: <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> From: Doug Anderson Date: Thu, 16 Jun 2022 08:35:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy To: Vinod Koul Cc: Abhinav Kumar , linux-phy@lists.infradead.org, Stephen Boyd , dri-devel , freedreno , Kishon Vijay Abraham I , Sankeerth Billakanti , Krzysztof Kozlowski , linux-arm-msm , quic_kalyant , Kuogee Hsieh , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rob Herring , Dmitry Baryshkov , Rob Clark , Bjorn Andersson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson wrote: > > We're supposed to list the supplies in the dt bindings but there are > none in the eDP PHY bindings. > > Looking at the driver in Linux, I can see that there seem to be two > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > bindings. > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > immediately clear how to figure out how to fill in these supplies. The > only two eDP related supplies are simply described as "power for eDP > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > from comparing how a similar PHY is hooked up on other similar > Qualcomm boards, I'll make the educated guess that the 1.2V supply > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > that in the example here. > > Signed-off-by: Douglas Anderson > --- > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) Even though patch #1 in this series should be dropped, this patch (patch #2) is still valid. Vinod: I assume this would land in your tree along with the first two patches in Kuogee's series [1], which are related. Please let me know if you need me to re-send or anything. Thanks! [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BBA1C433EF for ; Thu, 16 Jun 2022 15:36:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 144A810E3E2; Thu, 16 Jun 2022 15:36:12 +0000 (UTC) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by gabe.freedesktop.org (Postfix) with ESMTPS id 271B810E2DA for ; Thu, 16 Jun 2022 15:36:11 +0000 (UTC) Received: by mail-ej1-x633.google.com with SMTP id u12so3480352eja.8 for ; Thu, 16 Jun 2022 08:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5dVDuCM8VRK665zH/HV+gDuurZlzqRaw3AF4f+4QEQY=; b=YpSpNH3K+KjKkXCuVKrFBcVrP5SWlYv3RWSSUdRdHJUnj+BZbndMy/7IyaCo4ZQ5rb d5YerNu+HSuaHbXK9sCxIH2I4yswgUI5cbWPgvOV+jsqmpGVVOzFPK8wchjbBtnuyFNC yiHYfw8thWjslkqgb7sZ31mB5KIv7561wqhQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5dVDuCM8VRK665zH/HV+gDuurZlzqRaw3AF4f+4QEQY=; b=zt3PkxAem/jpCXyObljCFZXlAMTErXqJAzMaKHbAdewuYriHHNI9xP92CesSb52osI QFksxXP5DZ7sg1MpWbZZdErCmLkz8wqju+RB4thCW5MfcksImGGvTIyRzDsZeg77UwWc rvX3NRVs8EURsSSSLYeoF90eW8nLPIrD7OK4wif64pO1BMGZuLQGYAhu/MSgJcldmRoq 9nkMDRpvb+jBBPEcJzWTb3UYM0NhMZt97MH74xz6KHJ16E/0o/ffL0M0pJAXjbhJTeXI 4rLqIth8D8vZOGmSXDgUx2KfbhEa832GLK6sI86c/o29d5CKt5yggbwq45liKBhEGi4O /uig== X-Gm-Message-State: AJIora8csyySK8Ls5Qn6WOoHKbo+T/iNFPhheFAEI62IJv44u4amiT9W fL+TKAgLpQM+nS+zgBe5ixcvOVnZaiJcTcXICOM= X-Google-Smtp-Source: AGRyM1sKSiXxm5CfY1lHYiHV+G0DtLraofZRfshCcuYCcZ1s9LPCddFKy71sXdHvwuHZJTjXRDw2Xg== X-Received: by 2002:a17:906:804a:b0:70c:1dac:9bb8 with SMTP id x10-20020a170906804a00b0070c1dac9bb8mr5024597ejw.92.1655393769281; Thu, 16 Jun 2022 08:36:09 -0700 (PDT) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com. [209.85.221.47]) by smtp.gmail.com with ESMTPSA id u14-20020aa7d88e000000b0042bc97322desm1968923edq.43.2022.06.16.08.36.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 08:36:07 -0700 (PDT) Received: by mail-wr1-f47.google.com with SMTP id g4so2352750wrh.11 for ; Thu, 16 Jun 2022 08:36:06 -0700 (PDT) X-Received: by 2002:a5d:68d2:0:b0:210:31cc:64a6 with SMTP id p18-20020a5d68d2000000b0021031cc64a6mr5183133wrw.679.1655393766098; Thu, 16 Jun 2022 08:36:06 -0700 (PDT) MIME-Version: 1.0 References: <20220425210643.2420919-1-dianders@chromium.org> <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> In-Reply-To: <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> From: Doug Anderson Date: Thu, 16 Jun 2022 08:35:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy To: Vinod Koul Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_kalyant , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sankeerth Billakanti , Rob Clark , linux-arm-msm , Kuogee Hsieh , Abhinav Kumar , dri-devel , Kishon Vijay Abraham I , Rob Herring , Andy Gross , Bjorn Andersson , Dmitry Baryshkov , Krzysztof Kozlowski , linux-phy@lists.infradead.org, Stephen Boyd , freedreno , LKML Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson wrote: > > We're supposed to list the supplies in the dt bindings but there are > none in the eDP PHY bindings. > > Looking at the driver in Linux, I can see that there seem to be two > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > bindings. > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > immediately clear how to figure out how to fill in these supplies. The > only two eDP related supplies are simply described as "power for eDP > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > from comparing how a similar PHY is hooked up on other similar > Qualcomm boards, I'll make the educated guess that the 1.2V supply > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > that in the example here. > > Signed-off-by: Douglas Anderson > --- > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) Even though patch #1 in this series should be dropped, this patch (patch #2) is still valid. Vinod: I assume this would land in your tree along with the first two patches in Kuogee's series [1], which are related. Please let me know if you need me to re-send or anything. Thanks! [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5B70C43334 for ; Thu, 16 Jun 2022 15:42:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QI5opokr0XqoH6cQC8bbR7CGrt+DnU8CpiHPdDyU+3M=; b=tyH6lwCkTpDNZv e93+j01eDtwrUFmuH5iyCcIJE9zAMqiX8NziWXGblDEzkZ5oIij2BJUM5s7rCWsLA3huvQf7zqBp9 ekQZaxCCxSDzgBCoAGFkLCJQFa0Jr1jwLhV8reIc1Mwtr5OtCk02rffnjKYEJkcKHbYh5cqM/NhIM X3mBlAeX64d8RgFdcLP9+m2lp6jB+Bw84QgwbKzMUe+id9BQGqplHluBCU5MKBcytO1I4xjPW91Kn b+0k02CZElzxo6SoGpLhuE4VbpRly7lmldLr0wpXD8E5mceDiSpxnMRxZEgTYrNlzGEeZVtPwUzfr P7zF/tPwdw+3lDFKH9+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1rds-003DfE-A6; Thu, 16 Jun 2022 15:42:44 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1rdp-003Dd8-4D for linux-phy@lists.infradead.org; Thu, 16 Jun 2022 15:42:42 +0000 Received: by mail-lf1-x12f.google.com with SMTP id c2so2854320lfk.0 for ; Thu, 16 Jun 2022 08:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5dVDuCM8VRK665zH/HV+gDuurZlzqRaw3AF4f+4QEQY=; b=YpSpNH3K+KjKkXCuVKrFBcVrP5SWlYv3RWSSUdRdHJUnj+BZbndMy/7IyaCo4ZQ5rb d5YerNu+HSuaHbXK9sCxIH2I4yswgUI5cbWPgvOV+jsqmpGVVOzFPK8wchjbBtnuyFNC yiHYfw8thWjslkqgb7sZ31mB5KIv7561wqhQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5dVDuCM8VRK665zH/HV+gDuurZlzqRaw3AF4f+4QEQY=; b=urgpK++xLAIKOtSc/eAxiNGFrjahI+YLNikbnh2agS0+qfVF2rBYtF1CCVeGzetzbo zFcgXmPZg5qRML3qvfVM7TzzkXlM+QbbBKP/ejlN9Hilv7evJek7KhEr6a0+tPqfPHvs nHyC9lqD3AWoWgJTf7Bue/TiM31efp2Dq+ugOxKlzmBIIl+a/iYRJOSap3IebfIhY1Uj qj0XnBUge7nZhQLIiFFuROBkoxbgTUEQM1fGWL+hlvam/em7OuLcfFy0kn2rj3j3Qspb vyVWo2ipEDR6UNAQHvtt5tFJm1RCFYYpmqEj+WjjSopyWbp26S1pkSK985BB/3lj7rsd e2Mw== X-Gm-Message-State: AJIora8CN85eEt41bdhCtDTFpSQDlQtTyht71iOmrEiBcQSIVPJjjWkX zcackXADZddEJUkEvExxR78kMv/I9ivyJM9iuX0= X-Google-Smtp-Source: AGRyM1vqYm/jEF+Nr2zSruBrfwW8pNFDBlTBS3fkI1Q6jt8QGU5iW8ypdPnNUbzOA3kS0nbbK5tUnQ== X-Received: by 2002:a05:6512:32c1:b0:479:33ba:4680 with SMTP id f1-20020a05651232c100b0047933ba4680mr3001914lfg.535.1655394156335; Thu, 16 Jun 2022 08:42:36 -0700 (PDT) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id q7-20020a19f207000000b0047861c163d0sm281638lfh.37.2022.06.16.08.42.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 08:42:36 -0700 (PDT) Received: by mail-lf1-f43.google.com with SMTP id i29so2830351lfp.3 for ; Thu, 16 Jun 2022 08:42:35 -0700 (PDT) X-Received: by 2002:a5d:68d2:0:b0:210:31cc:64a6 with SMTP id p18-20020a5d68d2000000b0021031cc64a6mr5183133wrw.679.1655393766098; Thu, 16 Jun 2022 08:36:06 -0700 (PDT) MIME-Version: 1.0 References: <20220425210643.2420919-1-dianders@chromium.org> <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> In-Reply-To: <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> From: Doug Anderson Date: Thu, 16 Jun 2022 08:35:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy To: Vinod Koul Cc: Abhinav Kumar , linux-phy@lists.infradead.org, Stephen Boyd , dri-devel , freedreno , Kishon Vijay Abraham I , Sankeerth Billakanti , Krzysztof Kozlowski , linux-arm-msm , quic_kalyant , Kuogee Hsieh , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rob Herring , Dmitry Baryshkov , Rob Clark , Bjorn Andersson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220616_084241_223092_ABD8E988 X-CRM114-Status: GOOD ( 17.59 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi, On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson wrote: > > We're supposed to list the supplies in the dt bindings but there are > none in the eDP PHY bindings. > > Looking at the driver in Linux, I can see that there seem to be two > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > bindings. > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > immediately clear how to figure out how to fill in these supplies. The > only two eDP related supplies are simply described as "power for eDP > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > from comparing how a similar PHY is hooked up on other similar > Qualcomm boards, I'll make the educated guess that the 1.2V supply > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > that in the example here. > > Signed-off-by: Douglas Anderson > --- > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) Even though patch #1 in this series should be dropped, this patch (patch #2) is still valid. Vinod: I assume this would land in your tree along with the first two patches in Kuogee's series [1], which are related. Please let me know if you need me to re-send or anything. Thanks! [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ -Doug -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy