From: Doug Anderson <dianders@chromium.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Sandeep Maheswaram <sanm@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Boyd <swboyd@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Manu Gautam <mgautam@codeaurora.org>,
YongQin Liu <yongqin.liu@linaro.org>
Subject: Re: [PATCH v5 3/9] phy: qcom-qusb2: Add generic QUSB2 V2 PHY support
Date: Thu, 2 Apr 2020 15:58:22 -0700 [thread overview]
Message-ID: <CAD=FV=Wd1Y-4RvS+jrwMmnZ7tZJdPnQOx8bpQ_QExgwkDNH0zg@mail.gmail.com> (raw)
In-Reply-To: <CANcMJZCr646jav3h14K0xV=ANMxXg=U20wvSB546qrLX3TECBg@mail.gmail.com>
Hi,
On Thu, Apr 2, 2020 at 2:39 PM John Stultz <john.stultz@linaro.org> wrote:
>
> On Mon, Mar 9, 2020 at 2:54 AM Sandeep Maheswaram <sanm@codeaurora.org> wrote:
> > @@ -774,8 +774,8 @@ static const struct of_device_id qusb2_phy_of_match_table[] = {
> > .compatible = "qcom,msm8998-qusb2-phy",
> > .data = &msm8998_phy_cfg,
> > }, {
> > - .compatible = "qcom,sdm845-qusb2-phy",
> > - .data = &sdm845_phy_cfg,
> > + .compatible = "qcom,qusb2-v2-phy",
> > + .data = &qusb2_v2_phy_cfg,
> > },
> > { },
> > };
>
> Just as a heads up, Yongqin (cc'ed) reported this patch (now upstream)
> seems to be causing trouble on the db845c.
>
> It seems like its removing support for the "qcom,sdm845-qusb2-phy"
> compatible string, which is documented:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml#n23
>
> and already in use:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845.dtsi#n2389
>
> Should this instead have been an addition of the "qcom,qusb2-v2-phy",
> line instead of replacing "qcom,sdm845-qusb2-phy"?
To avoid forking the discussion into two threads, I'll suggest that we
focus on keeping the discussion in reply to your newly proposed patch.
I've already replied there:
https://lore.kernel.org/r/CAD=FV=VGT75c4_ErQAJgNtcCd2Jzv0A2KpfEkS637GqOhamj9Q@mail.gmail.com
-Doug
next prev parent reply other threads:[~2020-04-02 22:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 9:53 [PATCH v5 0/9] Add QUSB2 PHY support for SC7180 Sandeep Maheswaram
2020-03-09 9:53 ` [PATCH v5 1/9] dt-bindings: phy: qcom,qusb2: Convert QUSB2 phy bindings to yaml Sandeep Maheswaram
2020-03-09 9:53 ` [PATCH v5 2/9] dt-bindings: phy: qcom,qusb2: Add compatibles for QUSB2 V2 phy and SC7180 Sandeep Maheswaram
2020-03-20 17:55 ` Rob Herring
2020-03-09 9:53 ` [PATCH v5 3/9] phy: qcom-qusb2: Add generic QUSB2 V2 PHY support Sandeep Maheswaram
2020-04-02 21:39 ` John Stultz
2020-04-02 22:37 ` [PATCH] phy: qcom-qusb2: Re add "qcom,sdm845-qusb2-phy" compat string John Stultz
2020-04-02 22:56 ` Doug Anderson
2020-04-02 23:08 ` John Stultz
2020-04-02 23:19 ` Doug Anderson
2020-04-02 23:54 ` John Stultz
2020-04-02 23:18 ` Bjorn Andersson
2020-04-02 23:01 ` Bjorn Andersson
2020-04-02 23:44 ` [PATCH v2] " John Stultz
2020-04-02 23:49 ` Doug Anderson
2020-04-08 2:56 ` Stephen Boyd
2020-04-02 22:58 ` Doug Anderson [this message]
2020-03-09 9:53 ` [PATCH v5 4/9] dt-bindings: phy: qcom-qusb2: Add support for overriding Phy tuning parameters Sandeep Maheswaram
2020-03-09 9:53 ` [PATCH v5 5/9] phy: qcom-qusb2: Add support for overriding tuning parameters in QUSB2 V2 PHY Sandeep Maheswaram
2020-03-09 9:53 ` [PATCH v5 6/9] phy: qcom-qusb2: Add new " Sandeep Maheswaram
2020-03-09 9:53 ` [PATCH v5 7/9] arm64: dts: qcom: sc7180: Add generic QUSB2 V2 Phy compatible Sandeep Maheswaram
2020-03-09 9:53 ` [PATCH v5 8/9] arm64: dts: qcom: sdm845: " Sandeep Maheswaram
2020-04-06 23:48 ` Doug Anderson
2020-03-09 9:53 ` [PATCH v5 9/9] arm64: dts: qcom: sc7180: Update QUSB2 V2 Phy params for SC7180 IDP device Sandeep Maheswaram
2020-03-09 19:29 ` [PATCH v5 0/9] Add QUSB2 PHY support for SC7180 Bjorn Andersson
2020-03-20 6:05 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Wd1Y-4RvS+jrwMmnZ7tZJdPnQOx8bpQ_QExgwkDNH0zg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sanm@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.