From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82D54C43334 for ; Mon, 11 Jul 2022 13:47:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229599AbiGKNri (ORCPT ); Mon, 11 Jul 2022 09:47:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbiGKNrg (ORCPT ); Mon, 11 Jul 2022 09:47:36 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15A2452E57 for ; Mon, 11 Jul 2022 06:47:35 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id l23so8908806ejr.5 for ; Mon, 11 Jul 2022 06:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DjwJ2lXT0i+HUz5O+JVv9nTb4O1sy57SFFPwASu6wgc=; b=Eedf74tXPQaZVVxLSk0EQ3VllXkjFE9SWr72ktJrdcVUbqy6T0l3fE6qbwf9wvqSHQ gUTCkL5Bmh6wzRR/+3N8twr8x6+OOgPG3qENPbelO8gKJDGlT792ykdOAdsLUNobbaiv ggC+DAwcCSibGE5VWiUeiiHXNvZ1V1fL8nhQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DjwJ2lXT0i+HUz5O+JVv9nTb4O1sy57SFFPwASu6wgc=; b=pIGALkG5ZZJ02MKKu8JJ10wb8YFcIxcxWdGQ4dMO/kKXgcldLzzapnA9R7ZVSiO0po uZjfuKT3gD7uVHb6bZ634WcsJStSuyPKNPXfZr2+FFkjh3CLD6i2MboiQ+7gYZbbXJ6C yc5UIwi28ASWHyU2w/cfts6D3aWTnoDfx4o8+/sgFYtpT/poZXf4fkdUXz95aZbC+m+x VZfDDyF0p3b3rP7ZM1FBYKO+7CPY4MO/G565+aoZeCgwBpdjlGFUOfKsb4MbBPoI55KN FhIXcdMGvExnhx77kcg5QVrgeCt+jLSpcok+A5RluYQCE10o4b4wj+Zb/+6GF5fmydPs y/cg== X-Gm-Message-State: AJIora/ri7xjQYKbW3I1JyMNckbV5ZB8BBFPqBM1fl4UrswzVsS11ZCU gj4lpzcM7J2yvRQ6GH7fp42r/Eg975R1VQ== X-Google-Smtp-Source: AGRyM1uF9nnTLdiI88Jm6suK/3/gBlwc++HFuSCvdVr7qInEeI+SQyAvx/DY0KnY3Z2SF8OxEnPwCQ== X-Received: by 2002:a17:907:6818:b0:72b:5bac:c3a3 with SMTP id qz24-20020a170907681800b0072b5bacc3a3mr3537900ejc.139.1657547253429; Mon, 11 Jul 2022 06:47:33 -0700 (PDT) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com. [209.85.128.48]) by smtp.gmail.com with ESMTPSA id p13-20020aa7d30d000000b0043575ae2051sm4298898edq.62.2022.07.11.06.47.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 06:47:32 -0700 (PDT) Received: by mail-wm1-f48.google.com with SMTP id v67-20020a1cac46000000b003a1888b9d36so5063740wme.0 for ; Mon, 11 Jul 2022 06:47:32 -0700 (PDT) X-Received: by 2002:a05:600c:511c:b0:3a2:d480:9390 with SMTP id o28-20020a05600c511c00b003a2d4809390mr15693873wms.93.1657547252097; Mon, 11 Jul 2022 06:47:32 -0700 (PDT) MIME-Version: 1.0 References: <20220511060521.465744-1-sumit.garg@linaro.org> In-Reply-To: From: Doug Anderson Date: Mon, 11 Jul 2022 06:47:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/2] arm64: Fix pending single-step debugging issues To: Sumit Garg Cc: Daniel Thompson , Will Deacon , Wei Li , Catalin Marinas , Mark Rutland , Masami Hiramatsu , Jason Wessel , Marc Zyngier , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jul 11, 2022 at 5:44 AM Sumit Garg wrote: > > > I'll also note that I _think_ I remember that with Wei's series that > > the gdb function "call" started working. I tried that here and it > > didn't seem so happy. To keep things simple, I created a dummy > > function in my kernel that looked like: > > > > void doug_test(void) > > { > > pr_info("testing, 1 2 3\n"); > > } > > > > I broke into the debugger by echoing "g" to /proc/sysrq-trigger and > > then tried "call doug_test()". I guess my printout actually printed > > but it wasn't so happy after that. Seems like it somehow ended up > > returning to a bogus address after the call which then caused a crash. > > > > I am able to reproduce this issue on my setup as well. But it doesn't > seem to be a regression caused by this patch-set over Wei's series. As > I could reproduce this issue with v1 [1] patch-set as well which was > just a forward port of pending patches from Wei's series to the latest > upstream. > > Maybe it's a different regression caused by other changes? BTW, do you > remember the kernel version you tested with Wei's series applied? Sorry, I don't remember! :( I can't even be 100% sure that I'm remembering correctly that I tested it back in the day, so it's possible that it simply never worked... -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3462EC43334 for ; Mon, 11 Jul 2022 13:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MgOqSlaMoUGKOLNzXCGGYLq8p0dZjG9Y3PMYMl5GNwA=; b=HRB1SgkHLN2HZV 3NPAJGSyNohOQUToWz6EfItCdmgBFj21WfPKPK+rtEtKgUOfN4IsAkG5Fdukss4aYNzotvsbDPP+z NKJRW1ssDjoc5MZe+CMOCAHMDoNUg6xWKYAjHopLwsruxwNXTMbcTcuWgCIICmqE1w6FGIuJUo/Gk lUu+myEvQ2bJSku9Cokd56kpqC6Yao163b/V6Qg0KBJYH8LVApLH6p3smbfXZUctHNPc1X44yhfGx hJQdQe4NcmRjsB1rFM/U/DvgmEzNf8sB9iDKS81daxRCXFMBGX7ZhVF85ZveeXjwUizCDY5M27mDm zk1zGdHK0FEYd1hlUxRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAtlE-0022ON-6f; Mon, 11 Jul 2022 13:47:40 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAtlA-0022MU-By for linux-arm-kernel@lists.infradead.org; Mon, 11 Jul 2022 13:47:37 +0000 Received: by mail-ej1-x634.google.com with SMTP id oy13so4044165ejb.1 for ; Mon, 11 Jul 2022 06:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DjwJ2lXT0i+HUz5O+JVv9nTb4O1sy57SFFPwASu6wgc=; b=Eedf74tXPQaZVVxLSk0EQ3VllXkjFE9SWr72ktJrdcVUbqy6T0l3fE6qbwf9wvqSHQ gUTCkL5Bmh6wzRR/+3N8twr8x6+OOgPG3qENPbelO8gKJDGlT792ykdOAdsLUNobbaiv ggC+DAwcCSibGE5VWiUeiiHXNvZ1V1fL8nhQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DjwJ2lXT0i+HUz5O+JVv9nTb4O1sy57SFFPwASu6wgc=; b=sMUzRrFl/UlUmRWzlEzgphlV/EHjYVjP76QGMdZrhEzfZjXJMSv2fPATTiJH8a0qCX GPK14pp8kQUDuZSHRUDYvKfdOvXzLCcA1YdRQBJpLyL55FfWlhxUOlBu16Picw2cYahG qT8xe8+eTp98xI64zkvC3ByErD5ZrWpG58ctsLwNweVWui6ofARCI/RsHR75eLr97JMu LFJlo0LHSPWSDjcZLwlpiqcS25b9oZ2oVNqmriTJFuuVzu81xSQ/IrOpmtDk/Vod1nAA sKkrSEgmEXPTFF39K/62Ujauz73Efr0Dq6d/KPUuE0HQM0O1dyEVppmuDn5MgTI75ET8 g+xw== X-Gm-Message-State: AJIora9J0GDJXGUfH2+jzLDcTFWht4ghAa0ZuC1PnN4ekJey3+fpxWS6 Xr094G+ZGEA1Zg8ULE01bumQr/wqwQelVg== X-Google-Smtp-Source: AGRyM1t+aOSQ7HpSyHvaXX+U11IR+Y9XP0LYjdXbgYvuK76zQSPr3RQ7j6x/55vrHOhT5jp0R3qrmw== X-Received: by 2002:a17:907:7637:b0:72b:3a3b:7d68 with SMTP id jy23-20020a170907763700b0072b3a3b7d68mr11864809ejc.566.1657547254039; Mon, 11 Jul 2022 06:47:34 -0700 (PDT) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com. [209.85.128.41]) by smtp.gmail.com with ESMTPSA id w13-20020aa7dccd000000b00435a62d35b5sm4359493edu.45.2022.07.11.06.47.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 06:47:32 -0700 (PDT) Received: by mail-wm1-f41.google.com with SMTP id c131-20020a1c3589000000b003a2cc290135so3506258wma.2 for ; Mon, 11 Jul 2022 06:47:32 -0700 (PDT) X-Received: by 2002:a05:600c:511c:b0:3a2:d480:9390 with SMTP id o28-20020a05600c511c00b003a2d4809390mr15693873wms.93.1657547252097; Mon, 11 Jul 2022 06:47:32 -0700 (PDT) MIME-Version: 1.0 References: <20220511060521.465744-1-sumit.garg@linaro.org> In-Reply-To: From: Doug Anderson Date: Mon, 11 Jul 2022 06:47:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/2] arm64: Fix pending single-step debugging issues To: Sumit Garg Cc: Daniel Thompson , Will Deacon , Wei Li , Catalin Marinas , Mark Rutland , Masami Hiramatsu , Jason Wessel , Marc Zyngier , Linux ARM , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_064736_453951_BD86CBAD X-CRM114-Status: GOOD ( 21.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Jul 11, 2022 at 5:44 AM Sumit Garg wrote: > > > I'll also note that I _think_ I remember that with Wei's series that > > the gdb function "call" started working. I tried that here and it > > didn't seem so happy. To keep things simple, I created a dummy > > function in my kernel that looked like: > > > > void doug_test(void) > > { > > pr_info("testing, 1 2 3\n"); > > } > > > > I broke into the debugger by echoing "g" to /proc/sysrq-trigger and > > then tried "call doug_test()". I guess my printout actually printed > > but it wasn't so happy after that. Seems like it somehow ended up > > returning to a bogus address after the call which then caused a crash. > > > > I am able to reproduce this issue on my setup as well. But it doesn't > seem to be a regression caused by this patch-set over Wei's series. As > I could reproduce this issue with v1 [1] patch-set as well which was > just a forward port of pending patches from Wei's series to the latest > upstream. > > Maybe it's a different regression caused by other changes? BTW, do you > remember the kernel version you tested with Wei's series applied? Sorry, I don't remember! :( I can't even be 100% sure that I'm remembering correctly that I tested it back in the day, so it's possible that it simply never worked... -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel