From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752644AbcDZUyD (ORCPT ); Tue, 26 Apr 2016 16:54:03 -0400 Received: from mail-yw0-f175.google.com ([209.85.161.175]:33134 "EHLO mail-yw0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbcDZUx7 convert rfc822-to-8bit (ORCPT ); Tue, 26 Apr 2016 16:53:59 -0400 MIME-Version: 1.0 In-Reply-To: <9945516.Q6LYCrkl5z@diego> References: <1461638206-20473-1-git-send-email-jay.xu@rock-chips.com> <1461638206-20473-5-git-send-email-jay.xu@rock-chips.com> <9945516.Q6LYCrkl5z@diego> Date: Tue, 26 Apr 2016 13:53:58 -0700 X-Google-Sender-Auth: gOqtRJkUerHe7nD4KqmPec-BQXY Message-ID: Subject: Re: [PATCH 4/4] ARM64: dts: rockchip: add dts file for RK3399 evaluation board From: Doug Anderson To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Jianqun Xu , lintao , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Tao Huang , David Riley , Julius Werner , smbarber@chromium.org, "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Apr 26, 2016 at 5:37 AM, Heiko Stübner wrote: >> + model = "Rockchip RK3399 Evaluation Board"; >> + compatible = "rockchip,rk3399-evb", "rockchip,rk3399", >> + "google,rk3399evb-rev2", google,rk3399evb-rev1", >> + "google,rk3399evb-rev0" ; > > can you check against which compatibles that coreboot really matches? > > As we said that the evb changed between rev1 and rev2, I would expect the > compatible to be something like > > compatible = "rockchip,rk3399-evb", "google,rk3399evb-rev2", > "rockchip,rk3399"; > > leaving out the rev1 and rev0 What Heiko suggests seems reasonable to me. It all depends on what your bootloader is doing and what you guys want to do. Chrome OS designs that I've worked on have had board strappings that you can read a board ID from and that's how the BIOS (like coreboot) will figure out which board ID it is running on. I'm not aware of such strappings on rk3399-evb. Do they exist? Of course, even without strappings it's possible to get the bootloader to work sanely. You can either define the revision number at build time or you can store the revision number somewhere non-volatile. -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH 4/4] ARM64: dts: rockchip: add dts file for RK3399 evaluation board Date: Tue, 26 Apr 2016 13:53:58 -0700 Message-ID: References: <1461638206-20473-1-git-send-email-jay.xu@rock-chips.com> <1461638206-20473-5-git-send-email-jay.xu@rock-chips.com> <9945516.Q6LYCrkl5z@diego> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <9945516.Q6LYCrkl5z@diego> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Jianqun Xu , lintao , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Tao Huang , David Riley , Julius Werner , smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi, On Tue, Apr 26, 2016 at 5:37 AM, Heiko St=C3=BCbner w= rote: >> + model =3D "Rockchip RK3399 Evaluation Board"; >> + compatible =3D "rockchip,rk3399-evb", "rockchip,rk3399", >> + "google,rk3399evb-rev2", google,rk3399evb-rev1", >> + "google,rk3399evb-rev0" ; > > can you check against which compatibles that coreboot really matches? > > As we said that the evb changed between rev1 and rev2, I would expect= the > compatible to be something like > > compatible =3D "rockchip,rk3399-evb", "google,rk3399evb-rev2= ", > "rockchip,rk3399"; > > leaving out the rev1 and rev0 What Heiko suggests seems reasonable to me. It all depends on what your bootloader is doing and what you guys want to do. Chrome OS designs that I've worked on have had board strappings that you can read a board ID from and that's how the BIOS (like coreboot) will figure out which board ID it is running on. I'm not aware of such strappings on rk3399-evb. Do they exist? Of course, even without strappings it's possible to get the bootloader to work sanely. You can either define the revision number at build time or you can store the revision number somewhere non-volatile. -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: dianders@chromium.org (Doug Anderson) Date: Tue, 26 Apr 2016 13:53:58 -0700 Subject: [PATCH 4/4] ARM64: dts: rockchip: add dts file for RK3399 evaluation board In-Reply-To: <9945516.Q6LYCrkl5z@diego> References: <1461638206-20473-1-git-send-email-jay.xu@rock-chips.com> <1461638206-20473-5-git-send-email-jay.xu@rock-chips.com> <9945516.Q6LYCrkl5z@diego> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Tue, Apr 26, 2016 at 5:37 AM, Heiko St?bner wrote: >> + model = "Rockchip RK3399 Evaluation Board"; >> + compatible = "rockchip,rk3399-evb", "rockchip,rk3399", >> + "google,rk3399evb-rev2", google,rk3399evb-rev1", >> + "google,rk3399evb-rev0" ; > > can you check against which compatibles that coreboot really matches? > > As we said that the evb changed between rev1 and rev2, I would expect the > compatible to be something like > > compatible = "rockchip,rk3399-evb", "google,rk3399evb-rev2", > "rockchip,rk3399"; > > leaving out the rev1 and rev0 What Heiko suggests seems reasonable to me. It all depends on what your bootloader is doing and what you guys want to do. Chrome OS designs that I've worked on have had board strappings that you can read a board ID from and that's how the BIOS (like coreboot) will figure out which board ID it is running on. I'm not aware of such strappings on rk3399-evb. Do they exist? Of course, even without strappings it's possible to get the bootloader to work sanely. You can either define the revision number at build time or you can store the revision number somewhere non-volatile. -Doug