From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9FD5C433F5 for ; Fri, 20 May 2022 20:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238447AbiETUoM (ORCPT ); Fri, 20 May 2022 16:44:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231217AbiETUoM (ORCPT ); Fri, 20 May 2022 16:44:12 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED508193233 for ; Fri, 20 May 2022 13:44:10 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id h11so11028491eda.8 for ; Fri, 20 May 2022 13:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=68piDRPYyGX+8Kyo8j5dYWvQ7UCAfg+Z9z+ncUpXzkQ=; b=WqueUB0FZvMjwwyFM8/byn7J6ZpW/YsB9QLgdQ7hEeyQqYVVrkG9Nm6JD6fsroOa2M LuqnL+H8DYouLJz2gZ2DsRfXHkguHA8ELhHPw6uFPpaH0Y60qvs/+LInAQB55axMZoNi pAdXfEb6HPMFU/NEVNunlCyMLcdmHFWl6m/E0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=68piDRPYyGX+8Kyo8j5dYWvQ7UCAfg+Z9z+ncUpXzkQ=; b=Q1og88LaV68IDVkeiB7dsiC5i5aTAvMAV0YhN6qYXnDpvkMXUxmocpIKaQMzkwOejo ii/ezI5Mtnb5jLJff0d4wyNkBUmldxilNrsobG42suPFjbi4cjr81J0hbF+0hMdrfBZA b7+VmyM91gMAIFDV6B1JVMUuheCLzaP/V0a41V9S0o/XTwg0SRqqcXWUdxXyDbvv7gkf aT/5NL7w7aE7QsVj3ByCGMxmJQv6QYMsYgFp/bmnl8z+1XY+8FAgLPEpqFpjdMRApn30 eDZy96PMvXKMaZCiWoCeOmR9TCdnmJPdPUy3ut71vBKBCMc/z6FwII7eOfuqfhmR3hYr OoBw== X-Gm-Message-State: AOAM533YuTTG3TjRlANzkiHuCAUBXYAWbkyEVbYqj3/bxciuESTmv4vH Psb4zU63qMJ8YK3AjZlUCFuxcHBd1v+PKepQJlQ= X-Google-Smtp-Source: ABdhPJzAmpbm8/DnpYZJJ+nrG5+2jGHR/+VAE7rKAd4JtZCWeF4HSCXEHVJWh3YB+CF9QFdhhkdT/A== X-Received: by 2002:a05:6402:11c7:b0:428:5fdc:80c5 with SMTP id j7-20020a05640211c700b004285fdc80c5mr12841879edw.332.1653079449197; Fri, 20 May 2022 13:44:09 -0700 (PDT) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com. [209.85.221.52]) by smtp.gmail.com with ESMTPSA id w6-20020a170907270600b006f3ef214dedsm3460454ejk.83.2022.05.20.13.44.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 13:44:08 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id k30so12958911wrd.5 for ; Fri, 20 May 2022 13:44:07 -0700 (PDT) X-Received: by 2002:a05:6000:2c1:b0:20c:5e37:3ed1 with SMTP id o1-20020a05600002c100b0020c5e373ed1mr9682745wry.342.1653079447381; Fri, 20 May 2022 13:44:07 -0700 (PDT) MIME-Version: 1.0 References: <20220520161004.1141554-1-judyhsiao@chromium.org> <20220520161004.1141554-2-judyhsiao@chromium.org> In-Reply-To: <20220520161004.1141554-2-judyhsiao@chromium.org> From: Doug Anderson Date: Fri, 20 May 2022 13:43:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 To: Judy Hsiao Cc: Andy Gross , Bjorn Andersson , Rob Herring , Srini Kandagatla , Matthias Kaehlcke , Jimmy Cheng-Yi Chiang , Judy Hsiao , Tzung-Bi Shih , Stephen Boyd , Linux ARM , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Fri, May 20, 2022 at 9:10 AM Judy Hsiao wrote: > > 1. Add drive strength property for mi2s1 on sc7280 based platforms. > 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk. > > Signed-off-by: Judy Hsiao > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index 9cb1bc8ed6b5..6d8744e130b0 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -612,6 +612,20 @@ &dp_hot_plug_det { > bias-disable; > }; > > +&mi2s1_data0 { > + drive-strength = <6>; > + bias-disable; > +}; > + > +&mi2s1_sclk { > + drive-strength = <6>; > + bias-disable; > +}; > + > +&mi2s1_ws { > + drive-strength = <6>; > +}; I'm actually curious why this line has a drive-strength but _no_ bias setting. I guess I should figure out what the heck "ws" is. Ah, I guess it is word select. Since this is an output I'd expect to see "bias-disable" here too. -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77739C433EF for ; Fri, 20 May 2022 20:45:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MYGGLIQ0d4Lqnak5J5JoFn7Ru9niaaIbBJ+YsPy4fto=; b=X1ZW9Waj01qWq1 CXAbY/sJGQ3IImiSikP238XMP9gVxqZFtxsjlbCBasl0Kpqd+kj4LXsHDLtoG941JU4bBqMeX+v9W 8dXjqM5dgfPeOd6euRSfZWDLXU/6vDLLpE+P0AF14h+4KOe0d0IUPQ4kqCT+z+UfaS8YSHQi/NcQt uXXi39jFqyrLkap/XN/PG+6j2J9RVdyTkD1b6pQEX6ZChKdzVmgyuEyM0kOp3MpaBO8BE/c2ivJ+/ 9JRPs6YfONfcvaCTwBEcOGP9chlEynBtWDwqLdv5ayUAdvPdROLN5xoJIILq1BV/DGXsw+zfYz1TA F1ZqJd3IsFYatXEXi52g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns9Tp-00ETv8-R8; Fri, 20 May 2022 20:44:13 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns9Tm-00ETue-Qw for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 20:44:12 +0000 Received: by mail-ej1-x62f.google.com with SMTP id f21so3994880ejh.11 for ; Fri, 20 May 2022 13:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=68piDRPYyGX+8Kyo8j5dYWvQ7UCAfg+Z9z+ncUpXzkQ=; b=WqueUB0FZvMjwwyFM8/byn7J6ZpW/YsB9QLgdQ7hEeyQqYVVrkG9Nm6JD6fsroOa2M LuqnL+H8DYouLJz2gZ2DsRfXHkguHA8ELhHPw6uFPpaH0Y60qvs/+LInAQB55axMZoNi pAdXfEb6HPMFU/NEVNunlCyMLcdmHFWl6m/E0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=68piDRPYyGX+8Kyo8j5dYWvQ7UCAfg+Z9z+ncUpXzkQ=; b=tDkzmFVQVKhGbO4xceSEWSDjVkHjeSBy4Ol0zqGlmgTzpmOvHJhOqHiUM8+QN3S1yF Cc6LH13IBwmpeVqxYhZDiRkeTsSsJFLa72ujJ2QDdKO1Ht8ExPz7Gp9ZQU+4S33r7ZtT fI+LqAPlkao0zQEdxcyYNFxdrWkT1u36Q+SzaBjvmgyt1ukFMSy0mqUK8UKoIGrkw0QT JMtJEp7Mz5Ij7fDjCv3sGfGwttOA/FbnF/RMYqBg6lcaE/h4d+n31nCIVMZxzQmckBH8 O3wkg/iZXc0WuzNxtiCkgG41C5iVRGCRNHSZk9RO8bBYXSHl2KQ0OXy2hhHGFRHbNVOu X4Bw== X-Gm-Message-State: AOAM531p5KIpEsV9D1AWWbYSUOOV0bkt66H/SNwBcgP3H92e61XNkBhG BLq8FxfOEgZ67cCGqxV5+fsmJRfC05WTSwmonfw= X-Google-Smtp-Source: ABdhPJzprlNV9wh9eJu97inHVim287/N5PRZIAHH6+lD6EYNO7DFuEvpn2dmd6qd6qFWfqrtXVBAcQ== X-Received: by 2002:a17:907:2d23:b0:6fe:8aef:b533 with SMTP id gs35-20020a1709072d2300b006fe8aefb533mr10618004ejc.650.1653079448703; Fri, 20 May 2022 13:44:08 -0700 (PDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id z7-20020a05640235c700b0042b0fcfe966sm1987690edc.37.2022.05.20.13.44.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 13:44:08 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id j25so12939191wrc.9 for ; Fri, 20 May 2022 13:44:08 -0700 (PDT) X-Received: by 2002:a05:6000:2c1:b0:20c:5e37:3ed1 with SMTP id o1-20020a05600002c100b0020c5e373ed1mr9682745wry.342.1653079447381; Fri, 20 May 2022 13:44:07 -0700 (PDT) MIME-Version: 1.0 References: <20220520161004.1141554-1-judyhsiao@chromium.org> <20220520161004.1141554-2-judyhsiao@chromium.org> In-Reply-To: <20220520161004.1141554-2-judyhsiao@chromium.org> From: Doug Anderson Date: Fri, 20 May 2022 13:43:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 To: Judy Hsiao Cc: Andy Gross , Bjorn Andersson , Rob Herring , Srini Kandagatla , Matthias Kaehlcke , Jimmy Cheng-Yi Chiang , Judy Hsiao , Tzung-Bi Shih , Stephen Boyd , Linux ARM , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_134410_932339_C202F111 X-CRM114-Status: GOOD ( 16.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, May 20, 2022 at 9:10 AM Judy Hsiao wrote: > > 1. Add drive strength property for mi2s1 on sc7280 based platforms. > 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk. > > Signed-off-by: Judy Hsiao > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index 9cb1bc8ed6b5..6d8744e130b0 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -612,6 +612,20 @@ &dp_hot_plug_det { > bias-disable; > }; > > +&mi2s1_data0 { > + drive-strength = <6>; > + bias-disable; > +}; > + > +&mi2s1_sclk { > + drive-strength = <6>; > + bias-disable; > +}; > + > +&mi2s1_ws { > + drive-strength = <6>; > +}; I'm actually curious why this line has a drive-strength but _no_ bias setting. I guess I should figure out what the heck "ws" is. Ah, I guess it is word select. Since this is an output I'd expect to see "bias-disable" here too. -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel