From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753856AbcD1V2l (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Apr 2016 17:28:41 -0400
Received: from mail-yw0-f178.google.com ([209.85.161.178]:33348 "EHLO
	mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753828AbcD1V2k (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Apr 2016 17:28:40 -0400
MIME-Version: 1.0
In-Reply-To: <572212AE.5060904@rock-chips.com>
References: <1458147438-62387-3-git-send-email-david.wu@rock-chips.com>
	<1461074137-23899-1-git-send-email-david.wu@rock-chips.com>
	<CAD=FV=U7Vsnh8RZjZ=an0Sfb+soS=+v1icoH=kL1huCR_9TTgA@mail.gmail.com>
	<572212AE.5060904@rock-chips.com>
Date: Thu, 28 Apr 2016 14:28:34 -0700
X-Google-Sender-Auth: mL8ZEzhnkU3b0OOFbYdBalD904Q
Message-ID: <CAD=FV=WxoZArMyhAPEmhG4FVHqhd-snMt59_Hk=BVsP2hZBxpw@mail.gmail.com>
Subject: Re: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc
From: Doug Anderson <dianders@chromium.org>
To: "David.Wu" <david.wu@rock-chips.com>
Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
        Wolfram Sang <wsa@the-dreams.de>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Tao Huang <huangtao@rock-chips.com>, Lin Huang <hl@rock-chips.com>,
        Jianqun Xu <xjq@rock-chips.com>, Chris <zyw@rock-chips.com>,
        Eddie Cai <cf@rock-chips.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Wu <wdc@rock-chips.com>, Brian Norris <briannorris@google.com>,
        David Riley <davidriley@google.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Thu, Apr 28, 2016 at 6:39 AM, David.Wu <david.wu@rock-chips.com> wrote:
> +enum rk3x_i2c_bus_speed {
> +       I2C_FS_SPD,
> +       I2C_HS_SPD
> +};
> +
> +struct rk3x_i2c;
>
> Why do you need this forward definition?  Seems like it's not
> necessary.  Remove?
>
>
> I think we need a Master_Code state to seperate from other state.

I meant remove the line above the contains just:

  struct rk3x_i2c;

...I don't believe it's needed.  You only need a forward declaration
like that if you refer to the structure before it's defined.


-Doug

From mboxrd@z Thu Jan  1 00:00:00 1970
From: dianders@chromium.org (Doug Anderson)
Date: Thu, 28 Apr 2016 14:28:34 -0700
Subject: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc
In-Reply-To: <572212AE.5060904@rock-chips.com>
References: <1458147438-62387-3-git-send-email-david.wu@rock-chips.com>
 <1461074137-23899-1-git-send-email-david.wu@rock-chips.com>
 <CAD=FV=U7Vsnh8RZjZ=an0Sfb+soS=+v1icoH=kL1huCR_9TTgA@mail.gmail.com>
 <572212AE.5060904@rock-chips.com>
Message-ID: <CAD=FV=WxoZArMyhAPEmhG4FVHqhd-snMt59_Hk=BVsP2hZBxpw@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi,

On Thu, Apr 28, 2016 at 6:39 AM, David.Wu <david.wu@rock-chips.com> wrote:
> +enum rk3x_i2c_bus_speed {
> +       I2C_FS_SPD,
> +       I2C_HS_SPD
> +};
> +
> +struct rk3x_i2c;
>
> Why do you need this forward definition?  Seems like it's not
> necessary.  Remove?
>
>
> I think we need a Master_Code state to seperate from other state.

I meant remove the line above the contains just:

  struct rk3x_i2c;

...I don't believe it's needed.  You only need a forward declaration
like that if you refer to the structure before it's defined.


-Doug