From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBABEC433EF for ; Thu, 31 Mar 2022 23:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237196AbiCaXbG (ORCPT ); Thu, 31 Mar 2022 19:31:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbiCaXbF (ORCPT ); Thu, 31 Mar 2022 19:31:05 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 986C514DFE4 for ; Thu, 31 Mar 2022 16:29:17 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id m3so1806399lfj.11 for ; Thu, 31 Mar 2022 16:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i0Y8uJxAPTn+lPcbjKZMDigfiYGLfvVvyFJ8YmiOb0U=; b=ZTUl4ukv0e2NXaBF5xnMO9o+oFVlY2n2XoA0kUxOx6skIG9dTSaA7oECXPy4k5G/qR MtnM41dTUEMY98MWV1Q7y85uveZ3vNyBVCBdKuiNa70cypt1qBwokiaB5piPWsRGwfMf lQ3VnxZKPPbfZxfyG6Kj11Hei7OeO9IuoWwMA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i0Y8uJxAPTn+lPcbjKZMDigfiYGLfvVvyFJ8YmiOb0U=; b=KZcW+DJMm1QWthgnzsnBsqBCOLI5dSxQ6XUPgPZ1sos7kE2Kn8eIY9BEQikV32Iptm vMtNyG/Shv3xSlE82XtWro5wyRgHqYsx42JtJBC5x7qaEfW+TZIHfU5Psf/kdXY5odRv OZsYFfQkiG2wd5wEo6GVyM5ZnsZC1Is87w0v14sxZwSw7nHpk706Y3WBs+w0qS+SMJxe MD2PUmFzgDCZcaQgr3ETm44SCRzO7rvAB9CuR8V2gqREO5nzMIvrUNopi6lA+cYLodiO Da7nQtC/bLP0KuvttEaWCWdL4rzArX2lxV9kKAJ03OfwTA93i/iZbzU7eB0T2X+HlS9E tkbw== X-Gm-Message-State: AOAM530ZvM/voBz5U1/6JTyWFY/9G6Q1N5aeLxgkqrP3aYqm9eiUeb9d oKzUoC25YX8p2tWKDvKucxUzP+nFvlBzkBFP5Zg= X-Google-Smtp-Source: ABdhPJwkmV+pFN0tdvWG44i+6WBbNJMIhW1APFm7yIGr28EqCNlQMWIqXjsA9+TE1u31QHiy4dXPGA== X-Received: by 2002:a05:6512:1153:b0:44a:3b47:4f88 with SMTP id m19-20020a056512115300b0044a3b474f88mr11808460lfg.447.1648769355561; Thu, 31 Mar 2022 16:29:15 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id x23-20020a19e017000000b0044a4820f882sm70444lfg.84.2022.03.31.16.29.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 16:29:15 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id v12so1784112ljd.3 for ; Thu, 31 Mar 2022 16:29:15 -0700 (PDT) X-Received: by 2002:a5d:4491:0:b0:203:f63a:e89b with SMTP id j17-20020a5d4491000000b00203f63ae89bmr5615220wrq.342.1648768934136; Thu, 31 Mar 2022 16:22:14 -0700 (PDT) MIME-Version: 1.0 References: <1648656179-10347-1-git-send-email-quic_sbillaka@quicinc.com> <1648656179-10347-2-git-send-email-quic_sbillaka@quicinc.com> In-Reply-To: <1648656179-10347-2-git-send-email-quic_sbillaka@quicinc.com> From: Doug Anderson Date: Thu, 31 Mar 2022 16:22:00 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus To: Sankeerth Billakanti Cc: dri-devel , linux-arm-msm , freedreno , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Clark , Sean Paul , Stephen Boyd , quic_kalyant , "Abhinav Kumar (QUIC)" , "Kuogee Hsieh (QUIC)" , Bjorn Andersson , Sean Paul , David Airlie , Daniel Vetter , Dmitry Baryshkov , quic_vproddut , quic_aravindh@quicinc.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti wrote: > > @@ -1547,6 +1593,10 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev, > > dp_display->encoder = encoder; > > + ret = dp_display_get_next_bridge(dp_display); > + if (ret) > + return ret; It feels weird to me that this is in a function called "modeset_init", though I certainly don't know the structure of the MSM display code well enough to fully comment. My expectation would have been that devm_of_dp_aux_populate_ep_devices() would have been called from your probe routine and then you would have returned -EPROBE_DEFER from your probe if you were unable to find the panel afterwards. Huh, but I guess you _are_ getting called (indirectly) from dpu_kms_hw_init() and I can't imagine AUX transfers working before that function is called, so maybe I should just accept that it's complicated and let those who understand this driver better confirm that it's OK. ;-) > @@ -140,5 +140,6 @@ struct dp_parser { > * can be parsed using this module. > */ > struct dp_parser *dp_parser_get(struct platform_device *pdev); > +int dp_parser_find_next_bridge(struct dp_parser *parser); Everything else in this file is described w/ kerneldoc. Shouldn't your function also have a kerneldoc comment? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE667C433F5 for ; Thu, 31 Mar 2022 23:22:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 69D4D10E268; Thu, 31 Mar 2022 23:22:19 +0000 (UTC) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7359210E07C for ; Thu, 31 Mar 2022 23:22:18 +0000 (UTC) Received: by mail-ed1-x52b.google.com with SMTP id b24so1003938edu.10 for ; Thu, 31 Mar 2022 16:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i0Y8uJxAPTn+lPcbjKZMDigfiYGLfvVvyFJ8YmiOb0U=; b=ZTUl4ukv0e2NXaBF5xnMO9o+oFVlY2n2XoA0kUxOx6skIG9dTSaA7oECXPy4k5G/qR MtnM41dTUEMY98MWV1Q7y85uveZ3vNyBVCBdKuiNa70cypt1qBwokiaB5piPWsRGwfMf lQ3VnxZKPPbfZxfyG6Kj11Hei7OeO9IuoWwMA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i0Y8uJxAPTn+lPcbjKZMDigfiYGLfvVvyFJ8YmiOb0U=; b=H+ZvDRzFH44FrSssFmjWjsKzJTfPJjRQvBEy9upXv6c306XnHNz+gyKDMam/stNWNc s8mmVDwz2gbgs5e+8WI9pixNC0aitY4GFLyLGuBomEgUtCPAvlrxJMWEtXUwGjDy7ylt nN+pxC4lQAjs76dzutLRjOI4Uyky0fAsww/rT8FbjKjM9RvGSe90F65xW8d1Y5asVLXJ 48Wwx4+jvbe/M0CkLvyrG4LrSslhXpg7SjS2EcAJVSjP/oyDzjlQcuUKTWRl2u7tGB6w +3moTOxIkxj+Lqdt2MZo/LVPtWFIOsXZ3O4q9B5SG5fqzv0syRoKPLiBLL817TG0Qaqo KIAA== X-Gm-Message-State: AOAM530wy5ipZSIe50jd/+1dW0ZoA4aNDrOFCyZN9lpyhvoB3Apdni1X A1d9GfNreALMl4uF52gvkP+V82YoB7N54uUw X-Google-Smtp-Source: ABdhPJyyCKtpzI2aUyMcyjkHIr5/Nx3Q4JZtRTjoDt2RNO1cYvFVI+T2idPr5RS1jfiuYpTCzC4FMA== X-Received: by 2002:a05:6402:5201:b0:419:4c82:8f11 with SMTP id s1-20020a056402520100b004194c828f11mr18294587edd.133.1648768936730; Thu, 31 Mar 2022 16:22:16 -0700 (PDT) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com. [209.85.221.46]) by smtp.gmail.com with ESMTPSA id ky5-20020a170907778500b006d1b2dd8d4csm319354ejc.99.2022.03.31.16.22.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 16:22:14 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id c7so1906304wrd.0 for ; Thu, 31 Mar 2022 16:22:14 -0700 (PDT) X-Received: by 2002:a5d:4491:0:b0:203:f63a:e89b with SMTP id j17-20020a5d4491000000b00203f63ae89bmr5615220wrq.342.1648768934136; Thu, 31 Mar 2022 16:22:14 -0700 (PDT) MIME-Version: 1.0 References: <1648656179-10347-1-git-send-email-quic_sbillaka@quicinc.com> <1648656179-10347-2-git-send-email-quic_sbillaka@quicinc.com> In-Reply-To: <1648656179-10347-2-git-send-email-quic_sbillaka@quicinc.com> From: Doug Anderson Date: Thu, 31 Mar 2022 16:22:00 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus To: Sankeerth Billakanti Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_kalyant , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Bjorn Andersson , "Abhinav Kumar \(QUIC\)" , quic_vproddut , David Airlie , linux-arm-msm , LKML , dri-devel , Stephen Boyd , Sean Paul , Sean Paul , Dmitry Baryshkov , quic_aravindh@quicinc.com, "Kuogee Hsieh \(QUIC\)" , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti wrote: > > @@ -1547,6 +1593,10 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev, > > dp_display->encoder = encoder; > > + ret = dp_display_get_next_bridge(dp_display); > + if (ret) > + return ret; It feels weird to me that this is in a function called "modeset_init", though I certainly don't know the structure of the MSM display code well enough to fully comment. My expectation would have been that devm_of_dp_aux_populate_ep_devices() would have been called from your probe routine and then you would have returned -EPROBE_DEFER from your probe if you were unable to find the panel afterwards. Huh, but I guess you _are_ getting called (indirectly) from dpu_kms_hw_init() and I can't imagine AUX transfers working before that function is called, so maybe I should just accept that it's complicated and let those who understand this driver better confirm that it's OK. ;-) > @@ -140,5 +140,6 @@ struct dp_parser { > * can be parsed using this module. > */ > struct dp_parser *dp_parser_get(struct platform_device *pdev); > +int dp_parser_find_next_bridge(struct dp_parser *parser); Everything else in this file is described w/ kerneldoc. Shouldn't your function also have a kerneldoc comment?