From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BBBC433FE for ; Fri, 20 May 2022 19:58:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353363AbiETT6I (ORCPT ); Fri, 20 May 2022 15:58:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353360AbiETT6H (ORCPT ); Fri, 20 May 2022 15:58:07 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0151119C39F for ; Fri, 20 May 2022 12:58:07 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id fd25so12078321edb.3 for ; Fri, 20 May 2022 12:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=91hRve8uPKHyD7cyqNThpoM05puNaYd3DvR3HzXYuko=; b=lpqvBoM6Gr/2Au3IjwUDRf3AW+vRv/AgjUKjUMpr2Tw/h+UWoftPNUSJ2yRY2vUkKR yJTMS6AqC12+s4S/tRChmy7WAqYdVjWFuZnKS4oknUkTe1hU6PWku2CFzVRkEtgOLWeo /48NID9BaVY3CXLyUDP/zbnXK78bYQY8hNCEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=91hRve8uPKHyD7cyqNThpoM05puNaYd3DvR3HzXYuko=; b=PVNr/YPkegVe3waNttgmjkwuJ7eA2Dx7WybkRAM6ic4bADaNpC/nlJpJK9l1MNGNwo y2fRtvDb0/1bT1Jzjm+u1SDi/NdlW8OsZbBuiDLSPBYB62XHaGFKSje4q2oLiOrQQgJL fzk5SfS13JE0oI0tidvyLwkr1DVjQyofdpFR7y6HWI5JwOfXo/Kholy8VusU5H3rvk15 dMev9mLFtaP7ocK83oSxdJiLuMuO7xg7ruTAQz7gSWsmDG0U6Ub8xmN4loQXq2XRZHBe u/LGTwo0wSku94ySL/EoKdLsehoQ00HPvohlwwj1GJQuJYhq7QkFzX+bnJLXPIyNO6Bj L7Iw== X-Gm-Message-State: AOAM5331oDDLoIIgTUUDs43eonpZF1bobg3EvmP2N0InpIGvl6PcsC4q TTgmRB48UwJdCppahoZOZ3cDFnGTZL0JO/FzDpg= X-Google-Smtp-Source: ABdhPJzZzmyDiRV1xCZ4B7qLZLT1A9RZkI7itb809xJqZRnGNTtORCXszNQimf59QboHtWHv4ppI5g== X-Received: by 2002:a05:6402:90c:b0:415:d340:4ae2 with SMTP id g12-20020a056402090c00b00415d3404ae2mr12656784edz.331.1653076685051; Fri, 20 May 2022 12:58:05 -0700 (PDT) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com. [209.85.128.52]) by smtp.gmail.com with ESMTPSA id u15-20020a170906068f00b006febc86b8besm42902ejb.117.2022.05.20.12.58.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 12:58:04 -0700 (PDT) Received: by mail-wm1-f52.google.com with SMTP id k126so5072123wme.2 for ; Fri, 20 May 2022 12:58:03 -0700 (PDT) X-Received: by 2002:a05:600c:acf:b0:397:345f:fe10 with SMTP id c15-20020a05600c0acf00b00397345ffe10mr6514763wmr.15.1653076683048; Fri, 20 May 2022 12:58:03 -0700 (PDT) MIME-Version: 1.0 References: <20220520124834.1.I7c51c6255bb53086a82c5b3f4fafffcc5ccbc4ae@changeid> In-Reply-To: <20220520124834.1.I7c51c6255bb53086a82c5b3f4fafffcc5ccbc4ae@changeid> From: Doug Anderson Date: Fri, 20 May 2022 12:57:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Enable keyboard backlight for villager To: Matthias Kaehlcke Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Fri, May 20, 2022 at 12:48 PM Matthias Kaehlcke wrote: > > Villager has a backlit keyboard, enable support for the backlight. > > Signed-off-by: Matthias Kaehlcke > --- > > arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 8 ++++++++ > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts > index d3d6ffad4eff..b6a6a1454883 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts > @@ -58,6 +58,10 @@ &ap_sar_sensor1 { > status = "okay"; > }; > > +&keyboard_backlight { > + status = "okay"; > +}; Instead of doing this, can you just get rid of the status = "disabled" in herobrine.dtsi? I don't think there's any benefit to having two levels of "disabled" in the herobrine device tree.