From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BC1C3F68F for ; Tue, 11 Feb 2020 16:42:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08EDF24649 for ; Tue, 11 Feb 2020 16:42:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WqyC94s0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727818AbgBKQmR (ORCPT ); Tue, 11 Feb 2020 11:42:17 -0500 Received: from mail-vs1-f65.google.com ([209.85.217.65]:39211 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729382AbgBKQmR (ORCPT ); Tue, 11 Feb 2020 11:42:17 -0500 Received: by mail-vs1-f65.google.com with SMTP id p14so6712819vsq.6 for ; Tue, 11 Feb 2020 08:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KHkfZzNh1B4XmJZnXfgIQNWZsT5whG1kE8qQBYWXMgc=; b=WqyC94s0CD5d0ZPRr4dlQ93j+b50OoCaoHuxaKOKZ9lGE/26eG7Zpz10axDbzf5cxb agJY2MIEOmDQnmVeVxsWhCyJlffhvrtK79hVkzi4usTyPTyl3c9gdHucQAN6P9UAgoYx nArWP2wSBEJ1rS5b1O2lHsPS6x/yo/iTXctxezgmJsdLoyJlqvpWzge5pVPLcoU06f8E G6oLEE7mUeGdksmjfGbnMX+hoNNlbG4oxSYRlzwIb/R52rtvOPBSDc2MY48vpEV+dG97 55ylTus7812YtsujzGDOnd4LmnifnC4HV86nRK0NaOuphuOpMPKW+5WOtR80XRx0/onh 4xJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KHkfZzNh1B4XmJZnXfgIQNWZsT5whG1kE8qQBYWXMgc=; b=Zlu9GK2zQbKm/1zAqN9pC9FvlUh36iDFuA2LWxQOa+RnBLkegeuaCl3AvEebA2dcs3 P92fH7tfs5r0hdT1j9A1oo+sNclNrIpNMATyuhxmPX00yUdg2SZvdEDk0bl6JHpxWPOU oiGdsADxwyxUhw+Ynip9S9Rd4P4Sx+t3a9XPQTB/z9XvccAl78OflWHjmiiPrXe1rSNj bpoQUvkEJyqiV3Z4+D/6K7+Tp0wkrXEGBnquUWQ2dq01rairpcWEUhQrXMelXgs3zMMC +g6z5nl7ATBvKqkrD5WRKukNQI0QsnLW25ZVsPZOaQOyL3AnkX0ne+OSxuLs3fJFhIvY Q4PA== X-Gm-Message-State: APjAAAXNOOsUJk7wZcUB2sBBw5lSNIpe2wWc05iGoXx2Ek5AyYEgIPV2 CxMbtS9ILvTiftloXMYwdOv+HnCOQgNJIhBNNICimQ== X-Google-Smtp-Source: APXvYqxqMq+ejXxPsl9/xIf55OXMeWrD7wxRfObKKoy3oMAN0UARPc8I0EQfK/M1BGYcb9ZuENsUbz+LrH8gmb00USk= X-Received: by 2002:a67:fa1a:: with SMTP id i26mr9638813vsq.169.1581439335360; Tue, 11 Feb 2020 08:42:15 -0800 (PST) MIME-Version: 1.0 References: <1581434955-11087-1-git-send-email-vbadigan@codeaurora.org> In-Reply-To: <1581434955-11087-1-git-send-email-vbadigan@codeaurora.org> From: Doug Anderson Date: Tue, 11 Feb 2020 08:42:01 -0800 Message-ID: Subject: Re: [PATCH V1] dt-bindings: mmc: sdhci-msm: Add CQE reg map To: Veerabhadrarao Badiganti Cc: Ulf Hansson , Adrian Hunter , Asutosh Das , Sahitya Tummala , Sayali Lokhande , cang@codeaurora.org, Ram Prakash Gupta , Linux MMC List , LKML , linux-arm-msm , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Tue, Feb 11, 2020 at 7:29 AM Veerabhadrarao Badiganti wrote: > > CQE feature has been enabled on sdhci-msm. Add CQE reg map > that needs to be supplied for supporting CQE feature. > > Change-Id: I788c4bd5b7cbca16bc1030a410cc5550ed7204e1 > Signed-off-by: Veerabhadrarao Badiganti > --- > Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > index 7ee639b..eaa0998 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > @@ -27,6 +27,11 @@ Required properties: > - reg: Base address and length of the register in the following order: > - Host controller register map (required) > - SD Core register map (required for msm-v4 and below) > + - CQE register map (Optional, needed only for eMMC and msm-v4.2 above) I did a quick search and it appears that SD cards implementing 6.0 of the spec can also use CQE. Is that correct? If so, maybe remove the part about "eMMC"? Maybe also change "needed" to "useful" to make it clear that this entry isn't actually required for all msm-v4.2 controllers? > +- reg-names: When CQE register map is supplied, below reg-names are required > + - "hc_mem" for Host controller register map > + - "core_mem" for SD cpre regoster map s/regoster/register > + - "cqhci_mem" for CQE register map I'm at least slightly confused. You say that reg-names are there only if CQE register map is supplied. ...and that requires 4.2 and above. ...but "core_mem" is only there on 4.0 and below. So there should never be a "core_mem" entry? Trying to specify that sanely in free-form text seems like it's gonna be hard and not worth it. You should probably transition to yaml first? I will also note that Rob isn't a huge fan of "reg-names". In a different conversation I think you mentioned you had a reason for having it. I guess just be prepared to defend yourself against Rob if you feel strongly about keeping reg-names. -Doug