From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C06D9C43460 for ; Mon, 3 May 2021 17:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96E966117A for ; Mon, 3 May 2021 17:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232514AbhECRIw (ORCPT ); Mon, 3 May 2021 13:08:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236700AbhECRHX (ORCPT ); Mon, 3 May 2021 13:07:23 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 357C7C06174A for ; Mon, 3 May 2021 09:55:35 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id 197so5422812qkl.12 for ; Mon, 03 May 2021 09:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WTaPZJJAb+agZFdITzeXOjZnWTBVRqn0ZvSBSvsqyj8=; b=KPPMi8esPiixHTvAdzjM1N0qW/guYzs1KzH9fDZI4345Xh0a+0njo5pRHf/sVYbNfp PabktArLEDIdcVFhAkDgyadtRbNJDn4dafcTG2RtZl+LsjdNdxrriJeg5Ss619IEeUSn rzhLOppLZScRfHHm9uhyiGH4PoNuoziso7orE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WTaPZJJAb+agZFdITzeXOjZnWTBVRqn0ZvSBSvsqyj8=; b=XONVf6zvPCaQzd3JrTpahMoUhJ+MBDvcvgTgCR+9gWtplpN4G758+K+7eO8yGJplWt kS+NwkzXMBAi8E+7hK/kF0DWFk09O1X0qbPMYqF4JARPpFtxaCLoZ8dPckvPR5VyN802 EWbXxJBavJdPsOLIhOmFfQwrJD0WoqPcdeNn2MWQFTiYxyXHW+t/HIO6wIvzo7Pk5np7 p1C77OOjGRIVyoYWUz4G5xmDiJ+PqZ3cf9gJ/Z21rIJvofyEUk3o2EydXa7UwTLMqTjv S74KtA9y3lNWhmEu6GKaD37bQrvF89FDk3nsu+wfFHz/Y63lEdrp6stj9z8UhktP5JGj mdog== X-Gm-Message-State: AOAM531ch6Mh9jIhM0mxYYBjSqt0uL5OakRhb7z8q9n6o+VS7fN86Hb9 YaY3qoerjdKOLJiJJDeno2hATv1JQH2R6A== X-Google-Smtp-Source: ABdhPJzbi3O3DXp0NYHepdLJI8f9Fa4HPYouEAUMLJDgoEW9TTE/CcO28XiV4/WVWQSihRYS8n7PlQ== X-Received: by 2002:a37:e94:: with SMTP id 142mr20096680qko.49.1620060934195; Mon, 03 May 2021 09:55:34 -0700 (PDT) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id n18sm285741qtv.70.2021.05.03.09.55.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 May 2021 09:55:33 -0700 (PDT) Received: by mail-yb1-f182.google.com with SMTP id t94so8413780ybi.3 for ; Mon, 03 May 2021 09:55:33 -0700 (PDT) X-Received: by 2002:a25:d9ce:: with SMTP id q197mr15755336ybg.276.1620060932851; Mon, 03 May 2021 09:55:32 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.9.I3e68fa38c4ccbdbdf145cad2b01e83a1e5eac302@changeid> In-Reply-To: From: Doug Anderson Date: Mon, 3 May 2021 09:55:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 09/20] drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers To: Linus Walleij Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , MSM , Rob Clark , Stanislav Lisovskiy , Stephen Boyd , Steev Klimaszewski , Maarten Lankhorst , linux-i2c , Bjorn Andersson , "open list:DRM PANEL DRIVERS" , Daniel Vetter , David Airlie , Robert Foss , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Sat, May 1, 2021 at 4:59 AM Linus Walleij wrote: > > On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson wrote: > > > Let's use the newly minted aux bus to break up the driver into sub > > drivers. We're not doing a full breakup here: all the code is still in > > the same file and remains largely untouched. The big goal here of > > using sub-drivers is to allow part of our code to finish probing even > > if some other code needs to defer. This can solve some chicken-and-egg > > problems. Specifically: > > - In commit 48834e6084f1 ("drm/panel-simple: Support hpd-gpios for > > delaying prepare()") we had to add a bit of a hack to simpel-panel > > to support HPD showing up late. We can get rid of that hack now > > since the GPIO part of our driver can finish probing early. > > - We have a desire to expose our DDC bus to simple-panel (and perhaps > > to a backlight driver?). That will end up with the same > > chicken-and-egg problem. A future patch to move this to a sub-driver > > will fix it. > > - If/when we support the PWM functionality present in the bridge chip > > for a backlight we'll end up with another chicken-and-egg > > problem. If we allow the PWM to be a sub-driver too then it solves > > this problem. > > > > Signed-off-by: Douglas Anderson > > --- > > > > Changes in v5: > > - Fix module compile problems (Bjorn + kbuild bot) > > - Remove useless MODULE_DEVICE_TABLE (Bjorn). > > This is generally a good idea. I have no idea when to use > auxbus or MFD It was a bit hard for me to figure out too. I think historically this could have been implemented by MFD but I believe that the point of introducing the AUX bus was that MFD wasn't a great fit for things like this. It's talked about a bit in "Documentation/driver-api/auxiliary_bus.rst". For me the important thing here is that we think of the bridge chip as one device, not a collection of IP blocks glued together in one package. As some evidence, the DT bindings don't have sub-nodes for this. There's a single DT node that says that this one device is the bridge, is a GPIO controller, and can provide a PWM. > but I trust that you researched that so: > Acked-by: Linus Walleij Thanks! I'll land it then to whittle the patch stack down to just the controversial EDID one. -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EE37C433B4 for ; Mon, 3 May 2021 16:55:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 459CC61364 for ; Mon, 3 May 2021 16:55:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 459CC61364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 98EDF6E123; Mon, 3 May 2021 16:55:36 +0000 (UTC) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2BFB6E123 for ; Mon, 3 May 2021 16:55:35 +0000 (UTC) Received: by mail-qk1-x732.google.com with SMTP id o27so5711986qkj.9 for ; Mon, 03 May 2021 09:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WTaPZJJAb+agZFdITzeXOjZnWTBVRqn0ZvSBSvsqyj8=; b=KPPMi8esPiixHTvAdzjM1N0qW/guYzs1KzH9fDZI4345Xh0a+0njo5pRHf/sVYbNfp PabktArLEDIdcVFhAkDgyadtRbNJDn4dafcTG2RtZl+LsjdNdxrriJeg5Ss619IEeUSn rzhLOppLZScRfHHm9uhyiGH4PoNuoziso7orE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WTaPZJJAb+agZFdITzeXOjZnWTBVRqn0ZvSBSvsqyj8=; b=LotmzHa2amfyXzRYqw1JeB2MlyN9inbYjbfUU4LOe7CshWmlEqvjCsuvoze+B25gSz ByVyO5OkV0a1N3AJCHC8f7POYi5eVmI1t1dHVnULDmc7Zxi8cr5P7/d7ysjSo8JQY6/k 6KJ9gRE263wS5V74G8f2kC4AsNzf/yjdsFG6tpkoBcFF/Sb+GBkwTWcSU3rW/+3NCHDJ g7B62TgqBRI+JDIB/CzH3Dnxm6L2IbqfC0lhEjEmAm/mvmadrGqtuqA4yxI9GGgr22DU st0bpGUw7yy/WsiWjSRdirsi1d2hd20jiWD9Alnk/vlggUmD1XyVLfnkoTmMGORm9hZk KoNw== X-Gm-Message-State: AOAM530x48Sc3tBhHGSWJsBvoNcA+dG+r175ZqoXFXzNA+rdUyaJMlVs XPlYKwA80zA6pENdAc1kF649mNsWH9s7sg== X-Google-Smtp-Source: ABdhPJyfKTW7tdtXvry260R7e79/Xfwrk3ShjES2t4S6NcnzyyFemWCdoi6OOTUo1lqWF5wrc0td/A== X-Received: by 2002:a05:620a:13c3:: with SMTP id g3mr18754585qkl.429.1620060934284; Mon, 03 May 2021 09:55:34 -0700 (PDT) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id p5sm3364169qki.20.2021.05.03.09.55.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 May 2021 09:55:33 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id y2so8369951ybq.13 for ; Mon, 03 May 2021 09:55:33 -0700 (PDT) X-Received: by 2002:a25:d9ce:: with SMTP id q197mr15755336ybg.276.1620060932851; Mon, 03 May 2021 09:55:32 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.9.I3e68fa38c4ccbdbdf145cad2b01e83a1e5eac302@changeid> In-Reply-To: From: Doug Anderson Date: Mon, 3 May 2021 09:55:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 09/20] drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers To: Linus Walleij X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Stanislav Lisovskiy , Jernej Skrabec , Jonas Karlman , David Airlie , MSM , "open list:DRM PANEL DRIVERS" , Neil Armstrong , linux-kernel , Steev Klimaszewski , Stephen Boyd , Wolfram Sang , Andrzej Hajda , Laurent Pinchart , Bjorn Andersson , Sam Ravnborg , Robert Foss , linux-i2c Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Sat, May 1, 2021 at 4:59 AM Linus Walleij wrote: > > On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson wrote: > > > Let's use the newly minted aux bus to break up the driver into sub > > drivers. We're not doing a full breakup here: all the code is still in > > the same file and remains largely untouched. The big goal here of > > using sub-drivers is to allow part of our code to finish probing even > > if some other code needs to defer. This can solve some chicken-and-egg > > problems. Specifically: > > - In commit 48834e6084f1 ("drm/panel-simple: Support hpd-gpios for > > delaying prepare()") we had to add a bit of a hack to simpel-panel > > to support HPD showing up late. We can get rid of that hack now > > since the GPIO part of our driver can finish probing early. > > - We have a desire to expose our DDC bus to simple-panel (and perhaps > > to a backlight driver?). That will end up with the same > > chicken-and-egg problem. A future patch to move this to a sub-driver > > will fix it. > > - If/when we support the PWM functionality present in the bridge chip > > for a backlight we'll end up with another chicken-and-egg > > problem. If we allow the PWM to be a sub-driver too then it solves > > this problem. > > > > Signed-off-by: Douglas Anderson > > --- > > > > Changes in v5: > > - Fix module compile problems (Bjorn + kbuild bot) > > - Remove useless MODULE_DEVICE_TABLE (Bjorn). > > This is generally a good idea. I have no idea when to use > auxbus or MFD It was a bit hard for me to figure out too. I think historically this could have been implemented by MFD but I believe that the point of introducing the AUX bus was that MFD wasn't a great fit for things like this. It's talked about a bit in "Documentation/driver-api/auxiliary_bus.rst". For me the important thing here is that we think of the bridge chip as one device, not a collection of IP blocks glued together in one package. As some evidence, the DT bindings don't have sub-nodes for this. There's a single DT node that says that this one device is the bridge, is a GPIO controller, and can provide a PWM. > but I trust that you researched that so: > Acked-by: Linus Walleij Thanks! I'll land it then to whittle the patch stack down to just the controversial EDID one. -Doug _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel