From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [RESEND PATCH 3/7] mfd: cros_ec: stop calling ->cmd_xfer() directly Date: Wed, 20 Aug 2014 15:33:47 -0700 Message-ID: References: <1408536812-7836-1-git-send-email-javier.martinez@collabora.co.uk> <1408536812-7836-4-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1408536812-7836-4-git-send-email-javier.martinez@collabora.co.uk> Sender: linux-input-owner@vger.kernel.org To: Javier Martinez Canillas Cc: Lee Jones , Wolfram Sang , Dmitry Torokhov , Simon Glass , Bill Richardson , Andrew Bresticker , Derek Basehore , Todd Broch , Olof Johansson , =?UTF-8?Q?Andreas_F=C3=A4rber?= , "linux-i2c@vger.kernel.org" , "linux-input@vger.kernel.org" , linux-samsung-soc List-Id: linux-i2c@vger.kernel.org Javier, On Wed, Aug 20, 2014 at 5:13 AM, Javier Martinez Canillas wrote: > From: Andrew Bresticker > > Instead of having users of the ChromeOS EC call the interface-specific > cmd_xfer() callback directly, introduce a central cros_ec_cmd_xfer() > to use instead. This will allow us to put all the locking and retry > logic in one place instead of duplicating it across the different > drivers. > > Signed-off-by: Andrew Bresticker > Reviewed-by: Simon Glass > Signed-off-by: Javier Martinez Canillas > --- > drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +- > drivers/input/keyboard/cros_ec_keyb.c | 2 +- > drivers/mfd/cros_ec.c | 7 +++++++ > include/linux/mfd/cros_ec.h | 24 ++++++++++++++++++------ > 4 files changed, 27 insertions(+), 8 deletions(-) Reviewed-by: Doug Anderson