From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4BBC433EF for ; Thu, 13 Jan 2022 01:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230123AbiAMBD3 (ORCPT ); Wed, 12 Jan 2022 20:03:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230051AbiAMBDN (ORCPT ); Wed, 12 Jan 2022 20:03:13 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1232CC061748 for ; Wed, 12 Jan 2022 17:03:13 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id v1so6210981ioj.10 for ; Wed, 12 Jan 2022 17:03:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wHg2A2NJ6UT4MzZgddCFAkaAuebXYA54j3jymBNq3bQ=; b=hcY89bjSYMmSQ24yWz7MQ7PxwnpW0ag4Pu7D8vG1bspNAMS8x5xk77MMVuyzXzjgQ7 zc9volWa9dRnhpQXAi6KyCVRkTN/ZvG6Jw3sBxygDfXk+/v7sMEh+TWy4rlScY+N1HAx w+Sno9TOw+GhiMMRW+N2LF7I7vPEhkkYHrY4w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wHg2A2NJ6UT4MzZgddCFAkaAuebXYA54j3jymBNq3bQ=; b=xGrKejwWzzJojuWmNTyHoiZ+oqd/OrQmkchAl27SLzH4/6tApcTBL5GQ4/3x57wCQW E5gQx0Qar4o0tU6Z8qKHWe1Elf81x/GqrsC5DdGc1SHEe3P+zSsNv5o8Maw/0BfwJpbK Jni9lryUXy5JwcFYDMm5vJqexlnB2tZPcZCfqnQUKJI4GX7nFuLPFWayX2gCTVg/wrwu n+sPat6qK3RTO+AwRBtnSz1ERAoxnPHxhTp6jGCiwjsSh5cxfTZVKCaMoCfp8ZsIHU78 XjfwhQgeQxCLfDHyDOT2trBjk23XuGie3Inwz+wIE4VNEv6U6UiLazJO11bcD/IgsW5E 5CTA== X-Gm-Message-State: AOAM5317mIe4YX/nyuhHxwstrK8YYA9plEYEepAvKtwZkcDYnKucUFrU yOdlYXnam+rMOROkabAMf8hCQqQdjmeT5g== X-Google-Smtp-Source: ABdhPJyq2CVqWqKfqLyZ7cu0OkJBThdBgAkaQk0ozFWMFgINFtIp5VpoevLi7YVGEQJvP0YLkXMpPg== X-Received: by 2002:a02:7017:: with SMTP id f23mr1041546jac.272.1642035792323; Wed, 12 Jan 2022 17:03:12 -0800 (PST) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com. [209.85.166.182]) by smtp.gmail.com with ESMTPSA id r9sm797322ilh.80.2022.01.12.17.03.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 17:03:11 -0800 (PST) Received: by mail-il1-f182.google.com with SMTP id x15so4136794ilc.5 for ; Wed, 12 Jan 2022 17:03:11 -0800 (PST) X-Received: by 2002:a05:6e02:2187:: with SMTP id j7mr1201909ila.120.1642035791335; Wed, 12 Jan 2022 17:03:11 -0800 (PST) MIME-Version: 1.0 References: <20220112191048.837236-1-mka@chromium.org> <20220112111028.v19.4.I7a3a7d9d2126c34079b1cab87aa0b2ec3030f9b7@changeid> In-Reply-To: <20220112111028.v19.4.I7a3a7d9d2126c34079b1cab87aa0b2ec3030f9b7@changeid> From: Doug Anderson Date: Wed, 12 Jan 2022 17:03:00 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v19 4/5] usb: core: hcd: Create platform devices for onboard hubs in probe() To: Matthias Kaehlcke Cc: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi , Bastien Nocera , Krzysztof Kozlowski , Peter Chen , Ravi Chandra Sadineni , Linux USB List , Roger Quadros , Michal Simek , LKML , Stephen Boyd , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Kishon Vijay Abraham I , Li Jun , Peter Chen , Sasha Levin , Thinh Nguyen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jan 12, 2022 at 11:11 AM Matthias Kaehlcke wrote: > > Call onboard_hub_create/destroy_pdevs() from usb_add/remove_hcd() > for primary HCDs to create/destroy platform devices for onboard > USB hubs that may be connected to the root hub of the controller. > These functions are a NOP unless CONFIG_USB_ONBOARD_HUB=y/m. > > Also add a field to struct usb_hcd to keep track of the onboard hub > platform devices that are owned by the HCD. > > Signed-off-by: Matthias Kaehlcke > --- > > Changes in v19: > - none > > Changes in v18: > - none > > Changes in v17: > - create the platform devices in the generic HCD code instead of > the xhci_platform driver > - updated subject and commit message to reflect the above change > - dropped initialization of platform device list, which is now > done in onboard_hub_create_pdevs() > > Changes in v16: > - none > > Changes in v15: > - none > > Changes in v14: > - none > > Changes in v13: > - added comment for 'depends on USB_ONBOARD_HUB || !USB_ONBOARD_HUB' > construct > > Changes in v12: > - none > > Changes in v11: > - use onboard_hub_create/destroy_pdevs() to support multiple onboard > hubs that are connected to the same root hub > - moved field/list to keep track of platform devices from struct > usb_hcd to struct xhci_hcd > - updated commit message > > Changes in v10: > - none > > Changes in v9: > - added dependency on USB_ONBOARD_HUB (or !!USB_ONBOARD_HUB) to > USB_XHCI_PLATFORM > > Changes in v8: > - none > > Changes in v7: > - none > > Changes in v6: > - none > > Changes in v5: > - patch added to the series > > drivers/usb/core/hcd.c | 6 ++++++ > include/linux/usb/hcd.h | 1 + > 2 files changed, 7 insertions(+) No changes since v17 which I gave my tag for [1], but happy to give it again: Reviewed-by: Douglas Anderson [1] https://lore.kernel.org/r/CAD=FV=VcAdSWWVykGrw2r5BFMe4Esotb+ieggczcrY2TH-4VSA@mail.gmail.com/