From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50072C433EF for ; Fri, 22 Jul 2022 16:48:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235850AbiGVQsa (ORCPT ); Fri, 22 Jul 2022 12:48:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbiGVQs2 (ORCPT ); Fri, 22 Jul 2022 12:48:28 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D36993C2D for ; Fri, 22 Jul 2022 09:48:27 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id mf4so9567124ejc.3 for ; Fri, 22 Jul 2022 09:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fisLtN+BT8yvjNjBHC8GEVzMGlmsArMjpv7WMGpL1uk=; b=hGsxQRAaQ1NlnX6V2KJC5urP5Fisa69TIHv/c7JEryUv+CY0+Rbb4BMqZEfVB+u2nS IyUkAm5nmu3nGwemICYDJOBjhpJH/OR3iXElWoEVTyoWXZrfGtsZXmbYJiZ+TwDLDeTU +9DLqHj3bSOuUMesZoZg8cWXUSEWtmt+B6YWw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fisLtN+BT8yvjNjBHC8GEVzMGlmsArMjpv7WMGpL1uk=; b=yfdgv6BtpWAmiLNUrDRiiUfdjbd6AF2mYBu/CyoGoOd5Q+d2/ahSXj14abfIbAE1r/ mYTuTDhLg4hW82NPSSTCOixQNslk6agcePd8c0/0KnoyGpL/Qs8OAgbNeVI3d501X9NK dERDWes1uHGCrviFnzBqyevSyOqnyfz1l7kyNPN4YLzANmkJm9po4pWUBB2t6uJjpji3 sk/CANtT3P+Hei9IOgCO60/VA4Bg9pFkaJTOLEuilMNP4iv1dgCorBsQhhqTpO3mPY08 kXF1+MGqVaIsqlg1h991Xe3R5AT+9sxAb7DRJkX4z1+zpaKRmF2VybhChgsMJe5XT0Cn Hp+w== X-Gm-Message-State: AJIora9SuaREzfrKxwtMzjdC9Ek4kCqSX23WIb8wyMMguJN5NJXCpwGn IgHQyMdsorqBlkIf2YcJAvNTuv48VkU1hwmd X-Google-Smtp-Source: AGRyM1vPE3ej7inhhMFRCn+FO0X2/mHVmompoQ4yudJF7Ad0ipdZJUCww3YOEILRyoeFAFt6ayJGJA== X-Received: by 2002:a17:906:84f0:b0:72b:72b6:c7b2 with SMTP id zp16-20020a17090684f000b0072b72b6c7b2mr600817ejb.642.1658508505551; Fri, 22 Jul 2022 09:48:25 -0700 (PDT) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com. [209.85.221.47]) by smtp.gmail.com with ESMTPSA id gr19-20020a170906e2d300b0072b592ee073sm2212782ejb.147.2022.07.22.09.48.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:48:22 -0700 (PDT) Received: by mail-wr1-f47.google.com with SMTP id h8so7282161wrw.1 for ; Fri, 22 Jul 2022 09:48:21 -0700 (PDT) X-Received: by 2002:adf:f90d:0:b0:20c:de32:4d35 with SMTP id b13-20020adff90d000000b0020cde324d35mr508625wrr.583.1658508501016; Fri, 22 Jul 2022 09:48:21 -0700 (PDT) MIME-Version: 1.0 References: <20220721152314.RFC.1.Ie333b3e4aff6e4a5b58c4aa805e030e561be8773@changeid> <269f2610-425b-f296-dcfc-89bdc2e1d587@quicinc.com> In-Reply-To: <269f2610-425b-f296-dcfc-89bdc2e1d587@quicinc.com> From: Doug Anderson Date: Fri, 22 Jul 2022 09:48:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH] drm/edid: Make 144 Hz not preferred on Sharp LQ140M1JW46 To: Abhinav Kumar Cc: dri-devel , Rob Clark , freedreno , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , LKML , Sankeerth Billakanti Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Jul 22, 2022 at 9:37 AM Abhinav Kumar wrote: > > + sankeerth > > Hi Doug > > On 7/21/2022 3:23 PM, Douglas Anderson wrote: > > The Sharp LQ140M1JW46 panel is on the Qualcomm sc7280 CRD reference > > board. This panel supports 144 Hz and 60 Hz. In the EDID, the 144 Hz > > mode is listed first and thus is marked preferred. The EDID decode I > > ran says: > > > > First detailed timing includes the native pixel format and preferred > > refresh rate. > > > > ... > > > > Detailed Timing Descriptors: > > DTD 1: 1920x1080 143.981 Hz 16:9 166.587 kHz 346.500 MHz > > Hfront 48 Hsync 32 Hback 80 Hpol N > > Vfront 3 Vsync 5 Vback 69 Vpol N > > DTD 2: 1920x1080 59.990 Hz 16:9 69.409 kHz 144.370 MHz > > Hfront 48 Hsync 32 Hback 80 Hpol N > > Vfront 3 Vsync 5 Vback 69 Vpol N > > > > I'm proposing here that the above is actually a bug and that the 60 Hz > > mode really should be considered preferred by Linux. > > > > The argument here is that this is a laptop panel and on a laptop we > > know power will always be a concern. Presumably even if someone using > > this panel wanted to use 144 Hz for some use cases they would only do > > so dynamically and would still want the default to be 60 Hz. > > > > Let's change the default to 60 Hz using a standard quirk. > > > > Signed-off-by: Douglas Anderson > > Yes, we were aware that 144Hz was getting picked. We found that while > debugging the screen corruption issue. > > Well, yes power would be less with 60Hz but so will be the performance. What performance specifically will be less with 60 Hz? In general the sc7280 CPU is a bit memory-bandwidth constrained and the LCD refresh from memory is a non-trivial part of that. Reducing to 60 Hz will relieve some of the memory bandwidth pressure and will actually allow tasks on the CPU to run _faster_. I guess the downside is that some animations might be a little less smooth... > The test teams have been validating with 144Hz so far so we are checking > internally with the team whether its OKAY to goto 60Hz now since that > kind of invalidates the testing they have been doing. You're worried that the panel itself won't work well at 60 Hz, or something else about the system won't? The whole system in general needs to work well with 60 Hz displays and I expect them to be much more common than 144 Hz displays. Quite honestly if switching to 60 Hz uncovers a problem that would be a huge benefit of landing this patch because it would mean we'd find it now rather than down the road when someone hooks up a different panel. -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0000DC43334 for ; Fri, 22 Jul 2022 16:48:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2FBB994A83; Fri, 22 Jul 2022 16:48:31 +0000 (UTC) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35F889497C for ; Fri, 22 Jul 2022 16:48:30 +0000 (UTC) Received: by mail-ed1-x536.google.com with SMTP id g1so6511349edb.12 for ; Fri, 22 Jul 2022 09:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fisLtN+BT8yvjNjBHC8GEVzMGlmsArMjpv7WMGpL1uk=; b=hGsxQRAaQ1NlnX6V2KJC5urP5Fisa69TIHv/c7JEryUv+CY0+Rbb4BMqZEfVB+u2nS IyUkAm5nmu3nGwemICYDJOBjhpJH/OR3iXElWoEVTyoWXZrfGtsZXmbYJiZ+TwDLDeTU +9DLqHj3bSOuUMesZoZg8cWXUSEWtmt+B6YWw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fisLtN+BT8yvjNjBHC8GEVzMGlmsArMjpv7WMGpL1uk=; b=yj9f6LGtT4rErnGbfg3rdUHw9rdYXC/M7V2iC/2JkFvbNlbm/kNNteuFje75hQucbW m/h85zfnLl7mw++vK2xM3h+QvO373TqeBCiie1Jqbtl2Kdn785j89ynKH+Y4ZExKKUa5 F148bjxSfCTcbGL6ULF19LkMoG53x+MRv6DIRG64mNCvWe3TA1G5/Ts0L8J4u5GMcbHs ubioIxQNgOSQa53PEXwq/qUwlEr65KaNI9dPfcyBHxyz3LflWShTNjxlQ6G0/2jHQ5vL 2YETzFzwjYZUbUnA6bTxeqpBegaeW2jkmgjAPYtJV8bb3n8r9rtD0rhlw3A2EjKPfACl wLOQ== X-Gm-Message-State: AJIora9Lt9ed32mP7qyM66/ruArl92/cCshPgJZrrbetH3p2jw92lv5d +Ebl0M4TwX7+OoSbPNRP6QNkJHgZi4umOc4n X-Google-Smtp-Source: AGRyM1voEbLUAQ3IykUk8+xiZdAFWZvvtWT5nwn89GnmZZy2awyw4zDTVlG7ZUK0gOUPABN/Mczj2Q== X-Received: by 2002:a05:6402:4c3:b0:43a:f612:179d with SMTP id n3-20020a05640204c300b0043af612179dmr758805edw.422.1658508508447; Fri, 22 Jul 2022 09:48:28 -0700 (PDT) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com. [209.85.221.52]) by smtp.gmail.com with ESMTPSA id bk8-20020a170906b0c800b0072b8222c7f7sm2241118ejb.33.2022.07.22.09.48.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:48:22 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id l15so3224851wro.11 for ; Fri, 22 Jul 2022 09:48:21 -0700 (PDT) X-Received: by 2002:adf:f90d:0:b0:20c:de32:4d35 with SMTP id b13-20020adff90d000000b0020cde324d35mr508625wrr.583.1658508501016; Fri, 22 Jul 2022 09:48:21 -0700 (PDT) MIME-Version: 1.0 References: <20220721152314.RFC.1.Ie333b3e4aff6e4a5b58c4aa805e030e561be8773@changeid> <269f2610-425b-f296-dcfc-89bdc2e1d587@quicinc.com> In-Reply-To: <269f2610-425b-f296-dcfc-89bdc2e1d587@quicinc.com> From: Doug Anderson Date: Fri, 22 Jul 2022 09:48:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH] drm/edid: Make 144 Hz not preferred on Sharp LQ140M1JW46 To: Abhinav Kumar Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sankeerth Billakanti , Thomas Zimmermann , David Airlie , LKML , dri-devel , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Fri, Jul 22, 2022 at 9:37 AM Abhinav Kumar wrote: > > + sankeerth > > Hi Doug > > On 7/21/2022 3:23 PM, Douglas Anderson wrote: > > The Sharp LQ140M1JW46 panel is on the Qualcomm sc7280 CRD reference > > board. This panel supports 144 Hz and 60 Hz. In the EDID, the 144 Hz > > mode is listed first and thus is marked preferred. The EDID decode I > > ran says: > > > > First detailed timing includes the native pixel format and preferred > > refresh rate. > > > > ... > > > > Detailed Timing Descriptors: > > DTD 1: 1920x1080 143.981 Hz 16:9 166.587 kHz 346.500 MHz > > Hfront 48 Hsync 32 Hback 80 Hpol N > > Vfront 3 Vsync 5 Vback 69 Vpol N > > DTD 2: 1920x1080 59.990 Hz 16:9 69.409 kHz 144.370 MHz > > Hfront 48 Hsync 32 Hback 80 Hpol N > > Vfront 3 Vsync 5 Vback 69 Vpol N > > > > I'm proposing here that the above is actually a bug and that the 60 Hz > > mode really should be considered preferred by Linux. > > > > The argument here is that this is a laptop panel and on a laptop we > > know power will always be a concern. Presumably even if someone using > > this panel wanted to use 144 Hz for some use cases they would only do > > so dynamically and would still want the default to be 60 Hz. > > > > Let's change the default to 60 Hz using a standard quirk. > > > > Signed-off-by: Douglas Anderson > > Yes, we were aware that 144Hz was getting picked. We found that while > debugging the screen corruption issue. > > Well, yes power would be less with 60Hz but so will be the performance. What performance specifically will be less with 60 Hz? In general the sc7280 CPU is a bit memory-bandwidth constrained and the LCD refresh from memory is a non-trivial part of that. Reducing to 60 Hz will relieve some of the memory bandwidth pressure and will actually allow tasks on the CPU to run _faster_. I guess the downside is that some animations might be a little less smooth... > The test teams have been validating with 144Hz so far so we are checking > internally with the team whether its OKAY to goto 60Hz now since that > kind of invalidates the testing they have been doing. You're worried that the panel itself won't work well at 60 Hz, or something else about the system won't? The whole system in general needs to work well with 60 Hz displays and I expect them to be much more common than 144 Hz displays. Quite honestly if switching to 60 Hz uncovers a problem that would be a huge benefit of landing this patch because it would mean we'd find it now rather than down the road when someone hooks up a different panel. -Doug