From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10612C77B7F for ; Fri, 5 May 2023 16:37:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232830AbjEEQhx (ORCPT ); Fri, 5 May 2023 12:37:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232137AbjEEQhw (ORCPT ); Fri, 5 May 2023 12:37:52 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80AE1160B4 for ; Fri, 5 May 2023 09:37:51 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id d75a77b69052e-3ef35d44612so20175221cf.1 for ; Fri, 05 May 2023 09:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683304670; x=1685896670; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+yj1n8SZYpHx6GcDEfBZNc+Nz+lwlz9tugCt27cvkK8=; b=CMsm/LqGEAj+s7CIDExkm9nhwDFeJQDa+Oeq9fVS2Bmq3gS2DMH4rbkFfJstSWSWVJ sE6rFmodbvgtKNrRH1DIZUJNoyIpRSrlkmD5UQQ1e0/L6pdn3226k8bNu4IsYNMmUJHT StGBLiDqJmtf8Cr0AU5QJCiTcVq+LrUiMT5JE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683304670; x=1685896670; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+yj1n8SZYpHx6GcDEfBZNc+Nz+lwlz9tugCt27cvkK8=; b=HLliOPKpizjMxO4xt/ywHmXmyEzP36TablDS5ImOBHgC5NbClggtMjm4BClxiam3gz Kt5oGORI6oc47bGPVqBE1VUcSBx2JV1iWFKzQT3Lvc11UeHXDgNklWeoDjENEnrXFH4T zwqjJb4Hdtj6k/jtk7/MaNXAte9nttyvvlAqcggOpT11QzcD0vHj4mFqKJYYo395t8E4 sR+J8jaAS2QRSdWW5P5k4IRjEEGB/jdhRrrcWW0q3SOvFnlvsRcU7i6EIQqxVkXNoaCE /sLT3bMt9PWGUGBueLtcmxy345JCR9WPw7b/oY8CAPCUXNvrBujKy+esaqvh5BVSsp+s u0dQ== X-Gm-Message-State: AC+VfDyHnsYA4elN8hOjzZWMSkyF5FyOTuP2MEObPA2bpLuKZ2a5LP0f eq4XsIgHNTPOkfUN/VxsmbiBBExaa7bbfXQLnVM= X-Google-Smtp-Source: ACHHUZ4bEHedbkqQjhy57z/+2nUPmA5asW5g6XL7rY2bYz16chXbzFohbUmQXn+vycd1LlbYm9oFwg== X-Received: by 2002:a05:622a:138d:b0:3f0:a3ae:7e69 with SMTP id o13-20020a05622a138d00b003f0a3ae7e69mr3451797qtk.18.1683304670246; Fri, 05 May 2023 09:37:50 -0700 (PDT) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com. [209.85.160.177]) by smtp.gmail.com with ESMTPSA id bx13-20020a05622a090d00b003e8160cf93asm729440qtb.80.2023.05.05.09.37.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 09:37:49 -0700 (PDT) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-3ef34c49cb9so1091991cf.1 for ; Fri, 05 May 2023 09:37:49 -0700 (PDT) X-Received: by 2002:a05:622a:206:b0:3db:1c01:9d95 with SMTP id b6-20020a05622a020600b003db1c019d95mr335755qtx.4.1683304668543; Fri, 05 May 2023 09:37:48 -0700 (PDT) MIME-Version: 1.0 References: <20230504221349.1535669-1-dianders@chromium.org> <20230504151100.v4.5.I4e47cbfa1bb2ebbcdb5ca16817aa2887f15dc82c@changeid> In-Reply-To: From: Doug Anderson Date: Fri, 5 May 2023 09:37:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 05/17] watchdog/hardlockup: Rename touch_nmi_watchdog() to touch_hardlockup_watchdog() To: Nicholas Piggin Cc: Petr Mladek , Andrew Morton , Sumit Garg , Mark Rutland , Matthias Kaehlcke , Stephane Eranian , Stephen Boyd , ricardo.neri@intel.com, Tzung-Bi Shih , Lecopzer Chen , kgdb-bugreport@lists.sourceforge.net, Masayoshi Mizuma , Guenter Roeck , Pingfan Liu , Andi Kleen , Ian Rogers , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, ito-yuichi@fujitsu.com, Randy Dunlap , Chen-Yu Tsai , christophe.leroy@csgroup.eu, davem@davemloft.net, sparclinux@vger.kernel.org, mpe@ellerman.id.au, Will Deacon , ravi.v.shankar@intel.com, linuxppc-dev@lists.ozlabs.org, Marc Zyngier , Catalin Marinas , Daniel Thompson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Hi, On Thu, May 4, 2023 at 7:51=E2=80=AFPM Nicholas Piggin = wrote: > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > In preparation for the buddy hardlockup detector, rename > > touch_nmi_watchdog() to touch_hardlockup_watchdog() to make it clear > > that it will touch whatever hardlockup detector is configured. We'll > > add a #define for the old name (touch_nmi_watchdog) so that we don't > > have to touch every piece of code referring to the old name. > > Is this really helpful? Now it's got two names Could just leave it. > If you insist then it'd be better just to rename everything in one > go at the end of a merge window IMO. Conflicts would be trivial. I'm not picky here. I changed the name since Petr requested names to be changed for any code I was touching [1] and so I threw this out as a proposal. I agree that having two names can be confusing, but in this case it didn't feel too terrible to me. I'd love to hear Petr's opinion on this name change. I'm happy with: a) This patch as it is. b) Dropping this patch (or perhaps just changing it to add comments). c) Changing this patch to rename all 70 uses of the old name. Assuming this will go through Andrew Morton's tree, I'd be interested in whether he's OK w/ this. d) Dropping this patch from this series but putting it on the backburner to try to do later (so that the rename can happen at a time when it's least disruptive). > > Ideally this change would also rename the arch_touch_nmi_watchdog(), > > but that is harder since arch_touch_nmi_watchdog() is exported with > > EXPORT_SYMBOL() and thus is ABI. Add a comment next to the call to > > hopefully alleviate some of the confusion here. > > We don't keep ABI fixed upstream. I'm happy to be corrected, but my understanding was that kernel devs made an effort not to mess with things exported via "EXPORT_SYMBOL", but things exported via "EXPORT_SYMBOL_GPL" were fair game. I guess maybe my patch calling it "ABI" is a stronger statement than that, though. Doing a little more research, nobody wants to say that things exported with "EXPORT_SYMBOL" are ABI, they just want to say that we make an effort to have them be more stable. So certainly I should adjust my patch series not to call it ABI, but I'm still on the fence about whether I should rename this or not. I'd love to hear other opinions. This rename actually would be a lot easier than the touch_nmi_watchdog() one since the code referencing the name "arch_touch_nmi_watchdog" isn't spread so broadly through the kernel. [1] https://lore.kernel.org/r/ZFErmshcrcikrSU1@alley -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83204C77B7C for ; Fri, 5 May 2023 16:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N/Sc5u7yz4e57ZMki55xNSrZTwPxsm8aC7KGdXFOdrU=; b=vqevklzr0b/m2Z saKc68bIfKAyt2UNTFRf9h+8oUWYj39pZdvIdMc5hSRPeW02lIK9ep3N4UToSLJs1GU9HSX4LLR1U AM54qKiVdjoVZ7ezHiyXB6SJ/LV6OfZpfngYQuTRt9LDpEiqdwmN/1LHy5xDnBLhNyu4GzkPc+R5w dMBxqjEWO+OUuPovbAJzLk4F3DUlt/+L5sov5CaRpH7WF7bZR3p3QZ3AjkuG1jLFZZgCL8FdHG9C/ K2M52b1/YcJ/NVcMD8BYZkya+QnrWiELVxlmNnu3SAfv9rKQ0+hmYHzdiMh1HNWUYmCTWzhf8QDDr 87k9Hs1ZMpC41eZHdwSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puyRR-00BK86-05; Fri, 05 May 2023 16:37:57 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puyRN-00BK7P-36 for linux-arm-kernel@lists.infradead.org; Fri, 05 May 2023 16:37:55 +0000 Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-7537c70e468so177836685a.0 for ; Fri, 05 May 2023 09:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683304670; x=1685896670; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+yj1n8SZYpHx6GcDEfBZNc+Nz+lwlz9tugCt27cvkK8=; b=CMsm/LqGEAj+s7CIDExkm9nhwDFeJQDa+Oeq9fVS2Bmq3gS2DMH4rbkFfJstSWSWVJ sE6rFmodbvgtKNrRH1DIZUJNoyIpRSrlkmD5UQQ1e0/L6pdn3226k8bNu4IsYNMmUJHT StGBLiDqJmtf8Cr0AU5QJCiTcVq+LrUiMT5JE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683304670; x=1685896670; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+yj1n8SZYpHx6GcDEfBZNc+Nz+lwlz9tugCt27cvkK8=; b=EW0nI0N+nzzbS8ThBTMrd4+NSa5Pdr4u3ZA2FsjcEqCesj7vtjY0hVkcGAjHy3XpBp QS3GPDsRrgiu9wajSeyoOxD+XsZa4HNo6vDjV40eDnLYmi6lFda9oHMEYllgI3oA4rVG aHm4eDnpW4TdCLKUti7F1XSQwLwsEmK7Gdu9ogh2fIq/AvzotI+0OtN1VE9JABVfATF4 9bITtpKJv0fRp3pmw0Ln7ivOZBBoNeyyBC13MTyYcSThhmH+uUKqks3Ss3s4Ny96xKQT W7NkUFuE9RVj9p8QDXd6BlB3oi+XB8ss8LZx6qyQ406byXDyFJFrJjFjIFotkv6sL5zO zajg== X-Gm-Message-State: AC+VfDxtCmHWRzW8C3AnNfeHdTnt4eDLVIVIkP0Zm9EIqMUgTK2/0Nll wdn1lEyJZVZ0Wfvfmsc7hqFe72cuABxV0ZBqI3Q= X-Google-Smtp-Source: ACHHUZ59FJnrIKIKyFirhW7csFQTtc+zlA9S8MrgSXCPNvOXbdNsazMKg1opBGzMYHf6l0DvwWbhSQ== X-Received: by 2002:ad4:5f8e:0:b0:5e3:c84a:9422 with SMTP id jp14-20020ad45f8e000000b005e3c84a9422mr3701362qvb.2.1683304670404; Fri, 05 May 2023 09:37:50 -0700 (PDT) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com. [209.85.160.177]) by smtp.gmail.com with ESMTPSA id n18-20020ae9c312000000b0074e003c55f0sm686866qkg.102.2023.05.05.09.37.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 09:37:49 -0700 (PDT) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-3f0a2f8216fso1093881cf.0 for ; Fri, 05 May 2023 09:37:49 -0700 (PDT) X-Received: by 2002:a05:622a:206:b0:3db:1c01:9d95 with SMTP id b6-20020a05622a020600b003db1c019d95mr335755qtx.4.1683304668543; Fri, 05 May 2023 09:37:48 -0700 (PDT) MIME-Version: 1.0 References: <20230504221349.1535669-1-dianders@chromium.org> <20230504151100.v4.5.I4e47cbfa1bb2ebbcdb5ca16817aa2887f15dc82c@changeid> In-Reply-To: From: Doug Anderson Date: Fri, 5 May 2023 09:37:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 05/17] watchdog/hardlockup: Rename touch_nmi_watchdog() to touch_hardlockup_watchdog() To: Nicholas Piggin Cc: Petr Mladek , Andrew Morton , Sumit Garg , Mark Rutland , Matthias Kaehlcke , Stephane Eranian , Stephen Boyd , ricardo.neri@intel.com, Tzung-Bi Shih , Lecopzer Chen , kgdb-bugreport@lists.sourceforge.net, Masayoshi Mizuma , Guenter Roeck , Pingfan Liu , Andi Kleen , Ian Rogers , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, ito-yuichi@fujitsu.com, Randy Dunlap , Chen-Yu Tsai , christophe.leroy@csgroup.eu, davem@davemloft.net, sparclinux@vger.kernel.org, mpe@ellerman.id.au, Will Deacon , ravi.v.shankar@intel.com, linuxppc-dev@lists.ozlabs.org, Marc Zyngier , Catalin Marinas , Daniel Thompson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230505_093754_001613_B8E364ED X-CRM114-Status: GOOD ( 30.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBUaHUsIE1heSA0LCAyMDIzIGF0IDc6NTHigK9QTSBOaWNob2xhcyBQaWdnaW4gPG5w aWdnaW5AZ21haWwuY29tPiB3cm90ZToKPgo+IE9uIEZyaSBNYXkgNSwgMjAyMyBhdCA4OjEzIEFN IEFFU1QsIERvdWdsYXMgQW5kZXJzb24gd3JvdGU6Cj4gPiBJbiBwcmVwYXJhdGlvbiBmb3IgdGhl IGJ1ZGR5IGhhcmRsb2NrdXAgZGV0ZWN0b3IsIHJlbmFtZQo+ID4gdG91Y2hfbm1pX3dhdGNoZG9n KCkgdG8gdG91Y2hfaGFyZGxvY2t1cF93YXRjaGRvZygpIHRvIG1ha2UgaXQgY2xlYXIKPiA+IHRo YXQgaXQgd2lsbCB0b3VjaCB3aGF0ZXZlciBoYXJkbG9ja3VwIGRldGVjdG9yIGlzIGNvbmZpZ3Vy ZWQuIFdlJ2xsCj4gPiBhZGQgYSAjZGVmaW5lIGZvciB0aGUgb2xkIG5hbWUgKHRvdWNoX25taV93 YXRjaGRvZykgc28gdGhhdCB3ZSBkb24ndAo+ID4gaGF2ZSB0byB0b3VjaCBldmVyeSBwaWVjZSBv ZiBjb2RlIHJlZmVycmluZyB0byB0aGUgb2xkIG5hbWUuCj4KPiBJcyB0aGlzIHJlYWxseSBoZWxw ZnVsPyBOb3cgaXQncyBnb3QgdHdvIG5hbWVzIENvdWxkIGp1c3QgbGVhdmUgaXQuCj4gSWYgeW91 IGluc2lzdCB0aGVuIGl0J2QgYmUgYmV0dGVyIGp1c3QgdG8gcmVuYW1lIGV2ZXJ5dGhpbmcgaW4g b25lCj4gZ28gYXQgdGhlIGVuZCBvZiBhIG1lcmdlIHdpbmRvdyBJTU8uIENvbmZsaWN0cyB3b3Vs ZCBiZSB0cml2aWFsLgoKSSdtIG5vdCBwaWNreSBoZXJlLiBJIGNoYW5nZWQgdGhlIG5hbWUgc2lu Y2UgUGV0ciByZXF1ZXN0ZWQgbmFtZXMgdG8KYmUgY2hhbmdlZCBmb3IgYW55IGNvZGUgSSB3YXMg dG91Y2hpbmcgWzFdIGFuZCBzbyBJIHRocmV3IHRoaXMgb3V0IGFzCmEgcHJvcG9zYWwuIEkgYWdy ZWUgdGhhdCBoYXZpbmcgdHdvIG5hbWVzIGNhbiBiZSBjb25mdXNpbmcsIGJ1dCBpbgp0aGlzIGNh c2UgaXQgZGlkbid0IGZlZWwgdG9vIHRlcnJpYmxlIHRvIG1lLgoKSSdkIGxvdmUgdG8gaGVhciBQ ZXRyJ3Mgb3BpbmlvbiBvbiB0aGlzIG5hbWUgY2hhbmdlLiBJJ20gaGFwcHkgd2l0aDoKCmEpIFRo aXMgcGF0Y2ggYXMgaXQgaXMuCgpiKSBEcm9wcGluZyB0aGlzIHBhdGNoIChvciBwZXJoYXBzIGp1 c3QgY2hhbmdpbmcgaXQgdG8gYWRkIGNvbW1lbnRzKS4KCmMpIENoYW5naW5nIHRoaXMgcGF0Y2gg dG8gcmVuYW1lIGFsbCA3MCB1c2VzIG9mIHRoZSBvbGQgbmFtZS4gQXNzdW1pbmcKdGhpcyB3aWxs IGdvIHRocm91Z2ggQW5kcmV3IE1vcnRvbidzIHRyZWUsIEknZCBiZSBpbnRlcmVzdGVkIGluCndo ZXRoZXIgaGUncyBPSyB3LyB0aGlzLgoKZCkgRHJvcHBpbmcgdGhpcyBwYXRjaCBmcm9tIHRoaXMg c2VyaWVzIGJ1dCBwdXR0aW5nIGl0IG9uIHRoZQpiYWNrYnVybmVyIHRvIHRyeSB0byBkbyBsYXRl ciAoc28gdGhhdCB0aGUgcmVuYW1lIGNhbiBoYXBwZW4gYXQgYSB0aW1lCndoZW4gaXQncyBsZWFz dCBkaXNydXB0aXZlKS4KCgo+ID4gSWRlYWxseSB0aGlzIGNoYW5nZSB3b3VsZCBhbHNvIHJlbmFt ZSB0aGUgYXJjaF90b3VjaF9ubWlfd2F0Y2hkb2coKSwKPiA+IGJ1dCB0aGF0IGlzIGhhcmRlciBz aW5jZSBhcmNoX3RvdWNoX25taV93YXRjaGRvZygpIGlzIGV4cG9ydGVkIHdpdGgKPiA+IEVYUE9S VF9TWU1CT0woKSBhbmQgdGh1cyBpcyBBQkkuIEFkZCBhIGNvbW1lbnQgbmV4dCB0byB0aGUgY2Fs bCB0bwo+ID4gaG9wZWZ1bGx5IGFsbGV2aWF0ZSBzb21lIG9mIHRoZSBjb25mdXNpb24gaGVyZS4K Pgo+IFdlIGRvbid0IGtlZXAgQUJJIGZpeGVkIHVwc3RyZWFtLgoKSSdtIGhhcHB5IHRvIGJlIGNv cnJlY3RlZCwgYnV0IG15IHVuZGVyc3RhbmRpbmcgd2FzIHRoYXQga2VybmVsIGRldnMKbWFkZSBh biBlZmZvcnQgbm90IHRvIG1lc3Mgd2l0aCB0aGluZ3MgZXhwb3J0ZWQgdmlhICJFWFBPUlRfU1lN Qk9MIiwKYnV0IHRoaW5ncyBleHBvcnRlZCB2aWEgIkVYUE9SVF9TWU1CT0xfR1BMIiB3ZXJlIGZh aXIgZ2FtZS4KCkkgZ3Vlc3MgbWF5YmUgbXkgcGF0Y2ggY2FsbGluZyBpdCAiQUJJIiBpcyBhIHN0 cm9uZ2VyIHN0YXRlbWVudCB0aGFuCnRoYXQsIHRob3VnaC4gRG9pbmcgYSBsaXR0bGUgbW9yZSBy ZXNlYXJjaCwgbm9ib2R5IHdhbnRzIHRvIHNheSB0aGF0CnRoaW5ncyBleHBvcnRlZCB3aXRoICJF WFBPUlRfU1lNQk9MIiBhcmUgQUJJLCB0aGV5IGp1c3Qgd2FudCB0byBzYXkKdGhhdCB3ZSBtYWtl IGFuIGVmZm9ydCB0byBoYXZlIHRoZW0gYmUgbW9yZSBzdGFibGUuCgpTbyBjZXJ0YWlubHkgSSBz aG91bGQgYWRqdXN0IG15IHBhdGNoIHNlcmllcyBub3QgdG8gY2FsbCBpdCBBQkksIGJ1dApJJ20g c3RpbGwgb24gdGhlIGZlbmNlIGFib3V0IHdoZXRoZXIgSSBzaG91bGQgcmVuYW1lIHRoaXMgb3Ig bm90LiBJJ2QKbG92ZSB0byBoZWFyIG90aGVyIG9waW5pb25zLiBUaGlzIHJlbmFtZSBhY3R1YWxs eSB3b3VsZCBiZSBhIGxvdAplYXNpZXIgdGhhbiB0aGUgdG91Y2hfbm1pX3dhdGNoZG9nKCkgb25l IHNpbmNlIHRoZSBjb2RlIHJlZmVyZW5jaW5nCnRoZSBuYW1lICJhcmNoX3RvdWNoX25taV93YXRj aGRvZyIgaXNuJ3Qgc3ByZWFkIHNvIGJyb2FkbHkgdGhyb3VnaCB0aGUKa2VybmVsLgoKWzFdIGh0 dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvWkZFcm1zaGNyY2lrclNVMUBhbGxleQoKLURvdWcKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F02EC77B75 for ; Fri, 5 May 2023 16:39:10 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QCbx84Nhlz3fHZ for ; Sat, 6 May 2023 02:39:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=ZOpEQsos; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=chromium.org (client-ip=2607:f8b0:4864:20::12c; helo=mail-il1-x12c.google.com; envelope-from=dianders@chromium.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=ZOpEQsos; dkim-atps=neutral Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QCbw86rxHz3bTJ for ; Sat, 6 May 2023 02:38:16 +1000 (AEST) Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-333eb36e453so1082935ab.3 for ; Fri, 05 May 2023 09:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683304692; x=1685896692; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+yj1n8SZYpHx6GcDEfBZNc+Nz+lwlz9tugCt27cvkK8=; b=ZOpEQsosTbUmst8Ienf3nWALr0I43tuU6QG5nC9malggLvjl9COYLJOwf+H0XsKvTn l5ggtBESitzNF1+b1OZCsXuHMIB0MST6OOsXxIX0FaXAxgTqaf48l9nLSmwaLV5vDoqG GJdteCFXtZG4TrybH3jjPxNFm2oVJtQqUj2Xc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683304692; x=1685896692; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+yj1n8SZYpHx6GcDEfBZNc+Nz+lwlz9tugCt27cvkK8=; b=g/SQ0NvafqGSHPDPJ0zEvip1f1eDV6N0lgnpTH2Gwpa6dQBCuJgqxa8lSu0aJ38Hjt 9QqJzJvVh7sJck05coH7rInWQiZmzKGkR+bRKqAwxS0vUjblEO3wx8JsFLjKHOrLlrO2 vD+go1y70tRzRKOygUcOvlo7hEnQwpvhyLR1YlVfu9C6k1ynCk5OfB8gE0EG54Cc+aCr OkZN4SI9uIvCm25Bn4k6aNZPbTXlRJeQiw+I0B5cj/72B/BvYV/fmMiKUNYb/jxnssu/ EPjueryNq3suWeSnDk7N4UuAetJqpQuqYBPoqu/upVEJkfslBPFKvjYFyPIfHLKm3UOv fY0g== X-Gm-Message-State: AC+VfDx7ae1njcJ85QNkTrohPvNGkKm3yUK1MVcQ44qqaz2nuGInrPGZ UDXVvcywzS6eNsOjEF/9bt29Mv/gHFnXs1xvPmI= X-Google-Smtp-Source: ACHHUZ7w8yWC7yqpTX4QQzd/MQmXoB6vaVJE4jN4mi6OxyPRPbsp71wbFyhbdmQDsfrbtuaTzyw5fg== X-Received: by 2002:a05:6e02:54b:b0:322:f878:abcc with SMTP id i11-20020a056e02054b00b00322f878abccmr1242754ils.24.1683304691953; Fri, 05 May 2023 09:38:11 -0700 (PDT) Received: from mail-il1-f170.google.com (mail-il1-f170.google.com. [209.85.166.170]) by smtp.gmail.com with ESMTPSA id o9-20020a92dac9000000b0031595ea003asm539378ilq.85.2023.05.05.09.38.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 09:38:11 -0700 (PDT) Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-330ec047d3bso798875ab.0 for ; Fri, 05 May 2023 09:38:09 -0700 (PDT) X-Received: by 2002:a05:622a:206:b0:3db:1c01:9d95 with SMTP id b6-20020a05622a020600b003db1c019d95mr335755qtx.4.1683304668543; Fri, 05 May 2023 09:37:48 -0700 (PDT) MIME-Version: 1.0 References: <20230504221349.1535669-1-dianders@chromium.org> <20230504151100.v4.5.I4e47cbfa1bb2ebbcdb5ca16817aa2887f15dc82c@changeid> In-Reply-To: From: Doug Anderson Date: Fri, 5 May 2023 09:37:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 05/17] watchdog/hardlockup: Rename touch_nmi_watchdog() to touch_hardlockup_watchdog() To: Nicholas Piggin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ian Rogers , Randy Dunlap , Lecopzer Chen , ravi.v.shankar@intel.com, kgdb-bugreport@lists.sourceforge.net, ricardo.neri@intel.com, Stephane Eranian , sparclinux@vger.kernel.org, Guenter Roeck , Will Deacon , Daniel Thompson , Andi Kleen , Chen-Yu Tsai , Matthias Kaehlcke , Catalin Marinas , Masayoshi Mizuma , Petr Mladek , Tzung-Bi Shih , Stephen Boyd , Pingfan Liu , linux-arm-kernel@lists.infradead.org, Sumit Garg , ito-yuichi@fujitsu.com, linux-perf-users@vger.kernel.org, Marc Zyngier , Andrew Morton , linuxppc-dev@lists.ozlabs.org, davem@da vemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi, On Thu, May 4, 2023 at 7:51=E2=80=AFPM Nicholas Piggin = wrote: > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > In preparation for the buddy hardlockup detector, rename > > touch_nmi_watchdog() to touch_hardlockup_watchdog() to make it clear > > that it will touch whatever hardlockup detector is configured. We'll > > add a #define for the old name (touch_nmi_watchdog) so that we don't > > have to touch every piece of code referring to the old name. > > Is this really helpful? Now it's got two names Could just leave it. > If you insist then it'd be better just to rename everything in one > go at the end of a merge window IMO. Conflicts would be trivial. I'm not picky here. I changed the name since Petr requested names to be changed for any code I was touching [1] and so I threw this out as a proposal. I agree that having two names can be confusing, but in this case it didn't feel too terrible to me. I'd love to hear Petr's opinion on this name change. I'm happy with: a) This patch as it is. b) Dropping this patch (or perhaps just changing it to add comments). c) Changing this patch to rename all 70 uses of the old name. Assuming this will go through Andrew Morton's tree, I'd be interested in whether he's OK w/ this. d) Dropping this patch from this series but putting it on the backburner to try to do later (so that the rename can happen at a time when it's least disruptive). > > Ideally this change would also rename the arch_touch_nmi_watchdog(), > > but that is harder since arch_touch_nmi_watchdog() is exported with > > EXPORT_SYMBOL() and thus is ABI. Add a comment next to the call to > > hopefully alleviate some of the confusion here. > > We don't keep ABI fixed upstream. I'm happy to be corrected, but my understanding was that kernel devs made an effort not to mess with things exported via "EXPORT_SYMBOL", but things exported via "EXPORT_SYMBOL_GPL" were fair game. I guess maybe my patch calling it "ABI" is a stronger statement than that, though. Doing a little more research, nobody wants to say that things exported with "EXPORT_SYMBOL" are ABI, they just want to say that we make an effort to have them be more stable. So certainly I should adjust my patch series not to call it ABI, but I'm still on the fence about whether I should rename this or not. I'd love to hear other opinions. This rename actually would be a lot easier than the touch_nmi_watchdog() one since the code referencing the name "arch_touch_nmi_watchdog" isn't spread so broadly through the kernel. [1] https://lore.kernel.org/r/ZFErmshcrcikrSU1@alley -Doug