From mboxrd@z Thu Jan  1 00:00:00 1970
From: Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH 7/7] regulator: core: Remove loop disabling supplies in regulator_force_disable()
Date: Mon, 19 Nov 2018 18:05:46 -0800
Message-ID: <CAD=FV=XYJuvRCVRWqP5cn-AmJ8t6sGmG3Yazj3WSu9=7kYODWA@mail.gmail.com>
References: <20181120002654.1891-1-dianders@chromium.org> <20181120002654.1891-7-dianders@chromium.org>
 <3c226e1e-f707-c005-8c46-c0445f60a9a8@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <3c226e1e-f707-c005-8c46-c0445f60a9a8@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: digetx@gmail.com
Cc: Mark Brown <broonie@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Evan Green <evgreen@chromium.org>, Stephen Boyd <swboyd@chromium.org>, ryandcase@chromium.org, David Collins <collinsd@codeaurora.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, LKML <linux-kernel@vger.kernel.org>
List-Id: linux-arm-msm@vger.kernel.org

Hi,

On Mon, Nov 19, 2018 at 4:58 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> On 20.11.2018 3:26, Douglas Anderson wrote:
> > In regulator_force_disable() there was a strange loop that looked like:
> >
> >   while (rdev->open_count--)
> >     regulator_disable(rdev->supply);
> >
> > I'm not totally sure what the goal was for this loop, but it seems
> > wrong to me.  If anything I think maybe we should have been looping
> > over our use_count, but even that might be a little strange.  For now
> > let's just remove the code and we can add something back in if someone
> > can explain what's expected.
> >
> > Fixes: f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")
>
> Seems this "fixes" tag is incorrect, isn't it? The "ww_mutex" patch didn't touch this code.

Yes, I think you're right.  Originally I added it because I thought
that the "ww_mutex" patch should have touched this too, but I'm wrong.
I'll remove the "Fixes" tag if/when I send out v2.

-Doug