From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CBEDC433E6 for ; Mon, 15 Mar 2021 16:33:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F2C064E42 for ; Mon, 15 Mar 2021 16:33:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231406AbhCOQcg (ORCPT ); Mon, 15 Mar 2021 12:32:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233594AbhCOQcU (ORCPT ); Mon, 15 Mar 2021 12:32:20 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68FA7C06174A for ; Mon, 15 Mar 2021 09:32:20 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id m186so15619809qke.12 for ; Mon, 15 Mar 2021 09:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wSDzwZbj+0vxP+554qTTvCPOo7GPQQW7PtVpXOR2Y4U=; b=FetC9ltqIaCLxNdmHDvRxJjzUI0PCf2tEgp5CE05LdSaKPJugguqprjMjPNDorS7Gb SMLZ21YfS9W6mDAWMTTmgSmZ77K3Zye10u9DPDepX8cyaGCvgn6eKh0T/1kTF/hfNKa4 Sr91+vICNArqJrjCOFRVjUJYHpV1ZBwUCpmG8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wSDzwZbj+0vxP+554qTTvCPOo7GPQQW7PtVpXOR2Y4U=; b=jl6HE4SsKyRNn98lFl2l1dwIt+4q86C//FJ7EA5eMaAIwVkoxsfBwHJjLqA4JHaZkV snHUPMxuXQIoySnYyh8yYRlkmuFcAHYOh4BhqKn4m43NB8vXna0GOD/WwQm0pYtFGQRY dYWlQQ4Z5jzR2fgLpwfL8teisGWN5ZrVAs/B+XZhYvv9NIg5pFkbCgKzYe0dmUlCIdro GIQ0QhhtKaNW13dVnoceyN95en6eRxpZYDg4xz+oj8x+Ixk1iX0k0mBaLpZGu8LuNRNS ERSyzHnI3APjMT9FIS0DxPTc1FljPJ3q0j0LmYRcpq2a26UjnhyWFAN8SAR9w41Mdcz8 Sd5A== X-Gm-Message-State: AOAM533piz6RINSgx9Xvz0bDXVkF003myjg+eVPVeofqIKZsBOGrNFFz 8acyu3TIeFBSGYOEv+XYT8FTpN15+8wkyg== X-Google-Smtp-Source: ABdhPJw1kWRxOVDpbzQD6CsUGiEcrcj72sBvUhNM7nCgkbTFJQn27TL9WedawepOR45il3S6uoBInA== X-Received: by 2002:ae9:ef89:: with SMTP id d131mr25494339qkg.214.1615825938397; Mon, 15 Mar 2021 09:32:18 -0700 (PDT) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com. [209.85.219.169]) by smtp.gmail.com with ESMTPSA id m16sm12717025qkm.100.2021.03.15.09.32.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Mar 2021 09:32:17 -0700 (PDT) Received: by mail-yb1-f169.google.com with SMTP id l8so33790223ybe.12 for ; Mon, 15 Mar 2021 09:32:17 -0700 (PDT) X-Received: by 2002:a05:6902:70a:: with SMTP id k10mr669116ybt.257.1615825936810; Mon, 15 Mar 2021 09:32:16 -0700 (PDT) MIME-Version: 1.0 References: <20210304155144.1.Ic9c04f960190faad5290738b2a35d73661862735@changeid> <20210304155144.2.Id492ddb6e2cdd05eb94474b93654b04b270c9bbe@changeid> In-Reply-To: From: Doug Anderson Date: Mon, 15 Mar 2021 09:31:41 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: Move code in prep for EDID read fix To: Laurent Pinchart Cc: Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Stephen Boyd , linux-arm-msm@vger.kernel.org, robdclark@chromium.org, Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Sat, Mar 13, 2021 at 1:13 PM Laurent Pinchart wrote: > > Hi Douglas, > > Thank you for the patch. > > On Thu, Mar 04, 2021 at 03:52:00PM -0800, Douglas Anderson wrote: > > This patch is _only_ code motion to prepare for the patch > > ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if > > refclk") and make it easier to understand. > > s/make/makes/ I was never an expert at grammar, but I think either "make" or "makes" are fine. Simple version with parenthesis: Mine: This patch is to (prepare for the patch ) and (make it easier to understand). Yours: This patch is (to prepare for the patch ) and (makes it easier to understand). I suppose also valid would be: This patch is (to prepare for the patch ) and (to make it easier to understand). In any case if/when I spin this patch I'm fine changing it to your version just because (as I understand) it's equally valid and maybe looks slightly better? > > Signed-off-by: Douglas Anderson > > Reviewed-by: Laurent Pinchart Thanks for the reviews! -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E04EC433DB for ; Mon, 15 Mar 2021 16:32:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FF5064F2A for ; Mon, 15 Mar 2021 16:32:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FF5064F2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E1FC89842; Mon, 15 Mar 2021 16:32:22 +0000 (UTC) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by gabe.freedesktop.org (Postfix) with ESMTPS id E39C7897AC for ; Mon, 15 Mar 2021 16:32:20 +0000 (UTC) Received: by mail-qv1-xf2e.google.com with SMTP id by2so8059181qvb.11 for ; Mon, 15 Mar 2021 09:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wSDzwZbj+0vxP+554qTTvCPOo7GPQQW7PtVpXOR2Y4U=; b=FetC9ltqIaCLxNdmHDvRxJjzUI0PCf2tEgp5CE05LdSaKPJugguqprjMjPNDorS7Gb SMLZ21YfS9W6mDAWMTTmgSmZ77K3Zye10u9DPDepX8cyaGCvgn6eKh0T/1kTF/hfNKa4 Sr91+vICNArqJrjCOFRVjUJYHpV1ZBwUCpmG8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wSDzwZbj+0vxP+554qTTvCPOo7GPQQW7PtVpXOR2Y4U=; b=WfG5qh5VcbstlHnBZ4JolTo2U8ikGgOUG0+COskCbR3dwoMRLk9m7JLM9UUoJc2EGk /YoZ7mNSCZUCE3BsSdnXGk3161emw+4roZz+iBOHEybN9/kAHhHWyp+8wOZAOZIy3jh3 0tYW15ewjJirJ84Mthu8S1+IXG2xNmIj3h143sY+8fUvVWeuh33XKaJckegadxIDigay s8gdCLfbrN4ECKmkVvfCFyZgBBfb9cl2ORHOvZgD1tf88xZpH0ltM1yxgrCtQAZinRXW 5WWOjwha/FckQsLWMEAMMcrt0E2XUUMr4/BgncJo0cvMPAWdSeT9X/ifEdgI5oPAzREp Prow== X-Gm-Message-State: AOAM532j6BK2xfw4WT5lsetdZDC2hDc+SQmyADpnXBgrq/VS2zyakbUF dSLzBziLL6dZLVzVolXcPMr3eTvvz1NitA== X-Google-Smtp-Source: ABdhPJw9vxrqIwOJBmkAXabNe4E8LvnJYm5RYhk/cbrwLjLArOenKd6HNffnnzb2k+x3TjJgMC7k8g== X-Received: by 2002:a0c:c248:: with SMTP id w8mr11579028qvh.58.1615825938354; Mon, 15 Mar 2021 09:32:18 -0700 (PDT) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com. [209.85.219.171]) by smtp.gmail.com with ESMTPSA id m21sm12635322qka.28.2021.03.15.09.32.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Mar 2021 09:32:17 -0700 (PDT) Received: by mail-yb1-f171.google.com with SMTP id m9so33847168ybk.8 for ; Mon, 15 Mar 2021 09:32:17 -0700 (PDT) X-Received: by 2002:a05:6902:70a:: with SMTP id k10mr669116ybt.257.1615825936810; Mon, 15 Mar 2021 09:32:16 -0700 (PDT) MIME-Version: 1.0 References: <20210304155144.1.Ic9c04f960190faad5290738b2a35d73661862735@changeid> <20210304155144.2.Id492ddb6e2cdd05eb94474b93654b04b270c9bbe@changeid> In-Reply-To: From: Doug Anderson Date: Mon, 15 Mar 2021 09:31:41 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: Move code in prep for EDID read fix To: Laurent Pinchart X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , Jonas Karlman , David Airlie , linux-arm-msm@vger.kernel.org, Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , Andrzej Hajda , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Sat, Mar 13, 2021 at 1:13 PM Laurent Pinchart wrote: > > Hi Douglas, > > Thank you for the patch. > > On Thu, Mar 04, 2021 at 03:52:00PM -0800, Douglas Anderson wrote: > > This patch is _only_ code motion to prepare for the patch > > ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if > > refclk") and make it easier to understand. > > s/make/makes/ I was never an expert at grammar, but I think either "make" or "makes" are fine. Simple version with parenthesis: Mine: This patch is to (prepare for the patch ) and (make it easier to understand). Yours: This patch is (to prepare for the patch ) and (makes it easier to understand). I suppose also valid would be: This patch is (to prepare for the patch ) and (to make it easier to understand). In any case if/when I spin this patch I'm fine changing it to your version just because (as I understand) it's equally valid and maybe looks slightly better? > > Signed-off-by: Douglas Anderson > > Reviewed-by: Laurent Pinchart Thanks for the reviews! -Doug _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel