From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62BE8C433EF for ; Thu, 31 Mar 2022 23:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243056AbiCaXYz (ORCPT ); Thu, 31 Mar 2022 19:24:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243061AbiCaXYy (ORCPT ); Thu, 31 Mar 2022 19:24:54 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F59D24E24A for ; Thu, 31 Mar 2022 16:23:03 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id dr20so2371100ejc.6 for ; Thu, 31 Mar 2022 16:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VA4OmUlBn+h032QaRrbwfz0ENP/lgrthHNuo2cDc9zs=; b=nYjHIf8uflbZHObYpxif9B5oD9Wtb4t5AI1eCWohJX41q9UAn/abH6xMu9omxNFwsr 7qUSDGsPXh0wIhNznI1YcZUJupDndJZzHhIHEE8hHppvHxSa6v170I7xv/CDtTfwhCpF kzEWwkEZCviEfCOEDQ+sa6YJGh6+XAWttUpDc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VA4OmUlBn+h032QaRrbwfz0ENP/lgrthHNuo2cDc9zs=; b=HAW6XKV/tKG910z6TYd1oaLgSNyh0I0dAsdZNVSRnmX2ydEH8IsUzntKD+/mRN9QqJ Apnqi6uTQZee9pQFxCyUuSrE06mvcjMQHXyyOAXbfaRwnA+v+1erEcShL5NB3cuWh3t4 Lx1Ymc603ueee8BcOKsOBfcpW8l4xl2XfW63KylZLUk9fs7jPucxtxbfRaHLKOh42/mV DwNuafErVrkcOwooFV0qHGgCdPAx2BSZTchfp/lhTAEvnQS20ZlSUc3jrWGhWqEqBEbZ dH/LTXe4fojrzOporYXayiF3XmO11O38fHpc8fMNLyirjuHpZpDfzjz/5N9rH8n/yym4 213Q== X-Gm-Message-State: AOAM530ng0YRXA8Zm0Tp3vqpKkWuYV2+Y0p8GkhIazwXbqQ0lLKnorrc GmkBazeVQpXwER8P4taxM7gaKIGj4B3MvGh7 X-Google-Smtp-Source: ABdhPJwRGGieAYvJFkkiUlF39ystpd/wlj5dc8mjEg7dlml5R2rHYCjE/risGhXfWSem9MwAmVvjDA== X-Received: by 2002:a17:906:3283:b0:6ce:78f9:fafd with SMTP id 3-20020a170906328300b006ce78f9fafdmr7195634ejw.534.1648768981799; Thu, 31 Mar 2022 16:23:01 -0700 (PDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id l4-20020aa7c304000000b004192b7825a2sm380431edq.12.2022.03.31.16.22.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 16:22:59 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id c7so1907800wrd.0 for ; Thu, 31 Mar 2022 16:22:58 -0700 (PDT) X-Received: by 2002:adf:fc47:0:b0:203:dda1:4311 with SMTP id e7-20020adffc47000000b00203dda14311mr5685367wrs.301.1648768978217; Thu, 31 Mar 2022 16:22:58 -0700 (PDT) MIME-Version: 1.0 References: <1648656179-10347-1-git-send-email-quic_sbillaka@quicinc.com> <1648656179-10347-4-git-send-email-quic_sbillaka@quicinc.com> In-Reply-To: <1648656179-10347-4-git-send-email-quic_sbillaka@quicinc.com> From: Doug Anderson Date: Thu, 31 Mar 2022 16:22:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 3/8] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP To: Sankeerth Billakanti Cc: dri-devel , linux-arm-msm , freedreno , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Clark , Sean Paul , Stephen Boyd , quic_kalyant , "Abhinav Kumar (QUIC)" , "Kuogee Hsieh (QUIC)" , Bjorn Andersson , Sean Paul , David Airlie , Daniel Vetter , Dmitry Baryshkov , quic_vproddut , quic_aravindh@quicinc.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti wrote: > > @@ -1374,6 +1382,12 @@ static int dp_pm_resume(struct device *dev) > dp_catalog_ctrl_hpd_config(dp->catalog); > > > + if (dp->dp_display.connector_type == DRM_MODE_CONNECTOR_DisplayPort) > + dp_catalog_hpd_config_intr(dp->catalog, > + DP_DP_HPD_PLUG_INT_MASK | > + DP_DP_HPD_UNPLUG_INT_MASK, > + true); > + nit: why are there two blank lines above? > @@ -1639,6 +1653,9 @@ void dp_bridge_enable(struct drm_bridge *drm_bridge) > return; > } > > + if (dp->connector_type == DRM_MODE_CONNECTOR_eDP) > + dp_hpd_plug_handle(dp_display, 0); > + Should you add a "pre_enable" and do it there? That would make it more symmetric with the fact that you have the countertpart in "post_disable". Overall: I'm probably not familiar enough with this code to give it a full review. I'm hoping that Dmitry knows it well enough... ;-) -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AB7DC433F5 for ; Thu, 31 Mar 2022 23:29:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E59EE10E31C; Thu, 31 Mar 2022 23:29:14 +0000 (UTC) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 760D510E31C for ; Thu, 31 Mar 2022 23:29:13 +0000 (UTC) Received: by mail-lf1-x12f.google.com with SMTP id p10so1797710lfa.12 for ; Thu, 31 Mar 2022 16:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VA4OmUlBn+h032QaRrbwfz0ENP/lgrthHNuo2cDc9zs=; b=nYjHIf8uflbZHObYpxif9B5oD9Wtb4t5AI1eCWohJX41q9UAn/abH6xMu9omxNFwsr 7qUSDGsPXh0wIhNznI1YcZUJupDndJZzHhIHEE8hHppvHxSa6v170I7xv/CDtTfwhCpF kzEWwkEZCviEfCOEDQ+sa6YJGh6+XAWttUpDc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VA4OmUlBn+h032QaRrbwfz0ENP/lgrthHNuo2cDc9zs=; b=ukZGd9ly64g7cmuev7to+FsZDEwNRFD4ZPcW3k9fhzEGXBlFio7aId3Sk4flP+IPWb cNxNGgJXzeLd5B8QDcwkkfQ5TA8gF9sk7iC5JODt+adW15J2Qz1Dj1YiWttK8sYakDDC vwZzH1zSmU9/p4+tajX8sotlH/Soiiq3St2TH9ZNoCgqUXICCMegNUj2xcZUUUDIczFK 2eTjARsCzxAU8HOndXFsQfka/KvvzWJZWcmctuq6uM9ZRroMryavIGskpLy0wu3f58PN WisvKLQH65/WaAL065W6jy7afd1N8eRNbfxQOZaX1ac8KJFtxOm7opBwstUDdg6hKPYU WA9w== X-Gm-Message-State: AOAM532fWARhwX4LJSppnAPvrsSlya/Hsq8KTb5I8BkAEvvPMcA3yzsL Hdbe2ZXL9jC5SlTWjjZhjxzTcpUNiw437nCC5GU= X-Google-Smtp-Source: ABdhPJwm8mm5eygVT0rqlVebQRZ2FVvA9yzTbkmslzk+L29R7YdX1AmKSPhXqJc39DOGxje3Ym6Oww== X-Received: by 2002:a05:6512:230a:b0:44a:7699:a2a with SMTP id o10-20020a056512230a00b0044a76990a2amr12063413lfu.277.1648769351274; Thu, 31 Mar 2022 16:29:11 -0700 (PDT) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id x11-20020a19e00b000000b004488bf4137esm69011lfg.245.2022.03.31.16.29.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 16:29:10 -0700 (PDT) Received: by mail-lj1-f181.google.com with SMTP id bn33so1766978ljb.6 for ; Thu, 31 Mar 2022 16:29:10 -0700 (PDT) X-Received: by 2002:adf:fc47:0:b0:203:dda1:4311 with SMTP id e7-20020adffc47000000b00203dda14311mr5685367wrs.301.1648768978217; Thu, 31 Mar 2022 16:22:58 -0700 (PDT) MIME-Version: 1.0 References: <1648656179-10347-1-git-send-email-quic_sbillaka@quicinc.com> <1648656179-10347-4-git-send-email-quic_sbillaka@quicinc.com> In-Reply-To: <1648656179-10347-4-git-send-email-quic_sbillaka@quicinc.com> From: Doug Anderson Date: Thu, 31 Mar 2022 16:22:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 3/8] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP To: Sankeerth Billakanti Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_kalyant , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Bjorn Andersson , "Abhinav Kumar \(QUIC\)" , quic_vproddut , David Airlie , linux-arm-msm , LKML , dri-devel , Stephen Boyd , Sean Paul , Sean Paul , Dmitry Baryshkov , quic_aravindh@quicinc.com, "Kuogee Hsieh \(QUIC\)" , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti wrote: > > @@ -1374,6 +1382,12 @@ static int dp_pm_resume(struct device *dev) > dp_catalog_ctrl_hpd_config(dp->catalog); > > > + if (dp->dp_display.connector_type == DRM_MODE_CONNECTOR_DisplayPort) > + dp_catalog_hpd_config_intr(dp->catalog, > + DP_DP_HPD_PLUG_INT_MASK | > + DP_DP_HPD_UNPLUG_INT_MASK, > + true); > + nit: why are there two blank lines above? > @@ -1639,6 +1653,9 @@ void dp_bridge_enable(struct drm_bridge *drm_bridge) > return; > } > > + if (dp->connector_type == DRM_MODE_CONNECTOR_eDP) > + dp_hpd_plug_handle(dp_display, 0); > + Should you add a "pre_enable" and do it there? That would make it more symmetric with the fact that you have the countertpart in "post_disable". Overall: I'm probably not familiar enough with this code to give it a full review. I'm hoping that Dmitry knows it well enough... ;-) -Doug