All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Chris Ruehl <chris.ruehl@gtsys.com.hk>
Cc: "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] phy: rockchip-emmc: emmc_phy_init() always return 0
Date: Mon, 7 Dec 2020 08:29:59 -0800	[thread overview]
Message-ID: <CAD=FV=XkdnLt9PHM+TNWtDw5R9D1uqrJp2KoXpTG8oCQ=ECA3A@mail.gmail.com> (raw)
In-Reply-To: <1288be76-7599-92dd-561a-636872dd0186@gtsys.com.hk>

Hi,

On Sun, Dec 6, 2020 at 8:13 PM Chris Ruehl <chris.ruehl@gtsys.com.hk> wrote:
>
> To be backwards compatible, and keep it optional, I can check if clock-names is
> defined and if not, set emmcclk=null and return 0.
> But if emmcclk is defined and an error returned from clk_get(), escalate it.

...but how is this different than just checking for the -ENODEV (or
maybe -ENOENT?) error return (other than being more complicated and
requiring more code?)  ...or, perhaps even better, just use
clk_get_optional()?

-Doug

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2020-12-07 16:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  3:10 [PATCH] phy: rockchip-emmc: emmc_phy_init() always return 0 Chris Ruehl
2020-12-01  3:10 ` Chris Ruehl
2020-12-01  3:10 ` Chris Ruehl
2020-12-01 16:05 ` Doug Anderson
2020-12-01 16:05   ` Doug Anderson
2020-12-01 16:05   ` Doug Anderson
2020-12-02  8:36   ` Chris Ruehl
2020-12-02  8:36     ` Chris Ruehl
2020-12-02  8:36     ` Chris Ruehl
2020-12-04  3:01     ` Chris Ruehl
2020-12-04  3:01       ` Chris Ruehl
2020-12-04  3:01       ` Chris Ruehl
2020-12-04 17:53       ` Doug Anderson
2020-12-04 17:53         ` Doug Anderson
2020-12-04 17:53         ` Doug Anderson
2020-12-07  4:12         ` Chris Ruehl
2020-12-07 16:29           ` Doug Anderson [this message]
2020-12-09  1:29             ` Chris Ruehl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=XkdnLt9PHM+TNWtDw5R9D1uqrJp2KoXpTG8oCQ=ECA3A@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=chris.ruehl@gtsys.com.hk \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.