All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	Taniya Das <tdas@codeaurora.org>,
	Michael Turquette <mturquette@baylibre.com>,
	David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] arm64: dts: sdm845: Add videocc node
Date: Tue, 27 Nov 2018 11:26:30 -0800	[thread overview]
Message-ID: <CAD=FV=XoriDM2Dmj0bYwbqZ+ej6Ybf_XX5DOTSW1_X3eGRkohQ@mail.gmail.com> (raw)
In-Reply-To: <154330186815.88331.12720647562079303842@swboyd.mtv.corp.google.com>

Hi,

On Mon, Nov 26, 2018 at 10:57 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> > > +               videocc: clock-controller@ab00000 {
> > > +                       compatible = "qcom,sdm845-videocc";
> > > +                       reg = <0xab00000 0x10000>;
> > > +                       #clock-cells = <1>;
> > > +                       #power-domain-cells = <1>;
> >
> > Any reason not to include "#reset-cells = <1>;" here?  The bindings
> > list it as optional but I see no reason why we should leave it off.
> > The file "include/dt-bindings/clock/qcom,videocc-sdm845.h" seems to
> > include some #defines for resets.  Even though the driver doesn't seem
> > like it supports it yet, it still should be fine to list it here.
>
> We should update the binding to make it a required property. It doesn't
> make any sense why that property would be optional given that the
> hardware either has support for resets or it doesn't.

Patch sent for the bindings change.

https://lkml.kernel.org/r/20181127192443.136158-1-dianders@chromium.org

      reply	other threads:[~2018-11-27 19:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 10:35 [PATCH] arm64: dts: sdm845: Add videocc node Taniya Das
2018-11-05 23:21 ` Stephen Boyd
2018-11-05 23:21   ` Stephen Boyd
2018-11-06 17:23   ` Taniya Das
2018-11-27  0:35 ` Doug Anderson
2018-11-27  6:57   ` Stephen Boyd
2018-11-27 19:26     ` Doug Anderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=XoriDM2Dmj0bYwbqZ+ej6Ybf_XX5DOTSW1_X3eGRkohQ@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tdas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.