Re: [PATCH meta-oe 1/9] schroedinger: Imported from OE classic

[Joel A Fernandes <agnel.joel@gmail.com>]

On Sat, Aug 27, 2011 at 2:08 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> Op 27 aug. 2011, om 05:47 heeft Joel A Fernandes het volgende geschreven:
>
>> On Fri, Aug 26, 2011 at 3:01 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>>
>>> Op 26 aug. 2011, om 02:28 heeft Joel A Fernandes het volgende geschreven:
>>>
>>>> Signed-off-by: Joel A Fernandes <joelagnel@ti.com>
>>>> ---
>>>> .../schroedinger/gst-plugin-schroedinger_1.0.9.bb  |   15 +++++++++++++++
>>>> .../schroedinger/schroedinger.inc                  |   19 +++++++++++++++++++
>>>> .../schroedinger/schroedinger/configure.ac.patch   |   13 +++++++++++++
>>>> .../schroedinger/schroedinger_1.0.9.bb             |   13 +++++++++++++
>>>> 4 files changed, 60 insertions(+), 0 deletions(-)
>>>> create mode 100644 meta-oe/recipes-multimedia/schroedinger/gst-plugin-schroedinger_1.0.9.bb
>>>> create mode 100644 meta-oe/recipes-multimedia/schroedinger/schroedinger.inc
>>>> create mode 100644 meta-oe/recipes-multimedia/schroedinger/schroedinger/configure.ac.patch
>>>> create mode 100644 meta-oe/recipes-multimedia/schroedinger/schroedinger_1.0.9.bb
>>>>
>>>> diff --git a/meta-oe/recipes-multimedia/schroedinger/gst-plugin-schroedinger_1.0.9.bb b/meta-oe/recipes-multimedia/schroedinger/gst-plugin-schroedinger_1.0.9.bb
>>>> new file mode 100644
>>>> index 0000000..0a95646
>>>> --- /dev/null
>>>> +++ b/meta-oe/recipes-multimedia/schroedinger/gst-plugin-schroedinger_1.0.9.bb
>>>> @@ -0,0 +1,15 @@
>>>> +require schroedinger.inc
>>>> +PR = "r0"
>>>> +
>>>
>>>> +DEPENDS += "gstreamer gst-plugins-base"
>>>> +
>>>> +SRC_URI[schroedingertargz.md5sum] = "d67ec48b7c506db8c8b49156bf409e60"
>>>> +SRC_URI[schroedingertargz.sha256sum] = "345abcaa72ff0f2e9c1075e22f7141475ee4e6eea23a7f568b69ffc13cc1c723"
>>>> +
>>>> +S = "${WORKDIR}/schroedinger-${PV}"
>>>> +
>>>> +PACKAGES = "gst-plugin-schroedinger gst-plugin-schroedinger-dev gst-plugin-schroedinger-dbg"
>>>> +FILES_gst-plugin-schroedinger += "${libdir}/gstreamer-0.10/libgstschro.so"
>>>> +FILES_gst-plugin-schroedinger-dev += "${libdir}/gstreamer-0.10/libgstschro.*"
>>>> +FILES_gst-plugin-schroedinger-dbg += "${libdir}/gstreamer-0.10/.debug/libgstschro.so"
>>>> +
>>>> diff --git a/meta-oe/recipes-multimedia/schroedinger/schroedinger.inc b/meta-oe/recipes-multimedia/schroedinger/schroedinger.inc
>>>> new file mode 100644
>>>> index 0000000..386fc73
>>>> --- /dev/null
>>>> +++ b/meta-oe/recipes-multimedia/schroedinger/schroedinger.inc
>>>> @@ -0,0 +1,19 @@
>>>> +HOMEPAGE = "http://schrodinger.sourceforge.net/"
>>>> +LICENSE = "MPL GPL LGPL MIT"
>>>> +DEPENDS = "liboil orc-native orc"
>>>> +
>>>> +INC_PR = "r1"
>>>
>>> reset that
>>
>> Sure
>>
>>>
>>>> +
>>>> +SRC_URI = "http://www.diracvideo.org/download/schroedinger/${P}.tar.gz;name=schroedingertargz"
>>>> +SRC_URI += "file://configure.ac.patch"
>>>> +
>>>> +EXTRA_OECONF += "STAGING_DIR=${STAGING_DIR_NATIVE}"
>>>> +
>>>> +inherit autotools
>>>> +
>>>> +do_configure_append () {
>>>> +        # Fix stupid libtool... handling.
>>>> +        # rpath handling can't be disabled and the Makefile's can't be regenerated..
>>>> +        # (GNU sed required)
>>>> +        sed -i s/^hardcode_libdir_flag_spec/#hardcode_libdir_flag_spec/ ${S}/*-libtool
>>>> +}
>>>> diff --git a/meta-oe/recipes-multimedia/schroedinger/schroedinger/configure.ac.patch b/meta-oe/recipes-multimedia/schroedinger/schroedinger/configure.ac.patch
>>>> new file mode 100644
>>>> index 0000000..ac5e7ee
>>>> --- /dev/null
>>>> +++ b/meta-oe/recipes-multimedia/schroedinger/schroedinger/configure.ac.patch
>>>> @@ -0,0 +1,13 @@
>>>> +Index: schroedinger-1.0.9/configure.ac
>>>> +===================================================================
>>>> +--- schroedinger-1.0.9.orig/configure.ac
>>>> ++++ schroedinger-1.0.9/configure.ac
>>>> +@@ -54,7 +54,7 @@ if test "x${HAVE_ORC}" != xyes ; then
>>>> +   AC_ERROR([orc-0.4 >= $ORC_VER is required])
>>>> + fi
>>>> + SCHRO_PKG_DEPS="$SCHRO_PKG_DEPS orc-0.4 >= $ORC_VER"
>>>> +-ORCC=`$PKG_CONFIG --variable=orcc orc-0.4`
>>>> ++ORCC=$STAGING_DIR`$PKG_CONFIG --variable=orcc orc-0.4`
>>>> + AC_SUBST(ORCC)
>>>> +
>>>> + AC_ARG_WITH([thread],
>>>> diff --git a/meta-oe/recipes-multimedia/schroedinger/schroedinger_1.0.9.bb b/meta-oe/recipes-multimedia/schroedinger/schroedinger_1.0.9.bb
>>>> new file mode 100644
>>>> index 0000000..2994428
>>>> --- /dev/null
>>>> +++ b/meta-oe/recipes-multimedia/schroedinger/schroedinger_1.0.9.bb
>>>> @@ -0,0 +1,13 @@
>>>> +require schroedinger.inc
>>>> +
>>>> +PR = "${INC_PR}.0"
>>>> +
>>>> +inherit autotools
>>>> +
>>>> +SRC_URI[schroedingertargz.md5sum] = "d67ec48b7c506db8c8b49156bf409e60"
>>>> +SRC_URI[schroedingertargz.sha256sum] = "345abcaa72ff0f2e9c1075e22f7141475ee4e6eea23a7f568b69ffc13cc1c723"
>>>
>>> Why isn't this in the .inc and why is there a seperate recipe for the gst plugin?
>>
>> It is that way in OE classic:
>> http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/schroedinger/schroedinger_1.0.9.bb
>
> That's an observation, not a reason. Please fix it when adding it to meta-oe, no need to forward port crap when we can get rid of it.
> _______________________________________________

I will drop this recipe and add the gst-plugins-bad dependency to VLC